Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ci_multus] Refactor role #2483

Merged
merged 1 commit into from
Nov 4, 2024
Merged

[ci_multus] Refactor role #2483

merged 1 commit into from
Nov 4, 2024
+702 −318

Conversation

lewisdenny
Copy link
Collaborator

@lewisdenny lewisdenny commented Oct 23, 2024 •
edited
Loading

The ci_multus role was created but unused, this patch refreshes it as we will begin to use it in the new job to test Ironic.

Depends-On: #2494

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 23, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@lewisdenny lewisdenny force-pushed the refresh_ci_multus branch 4 times, most recently from 1548a0f to 847f821 Compare October 23, 2024 03:00
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/02e366f78a7d431ea57f78af10bf6247

✔️ noop SUCCESS in 0s
❌ podified-multinode-edpm-deployment-crc-bootstrap-staging-ironic ERROR Unable to find playbook /var/lib/zuul/builds/da2b3f44847a4502aa4d68ad41e942c2/untrusted/project_0/github.com/openstack-k8s-operators/ci-framework/ci/playbooks/edpm/fail.yml in 8s
✔️ cifmw-molecule-ci_multus SUCCESS in 20m 40s

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/6bde197d301d4cdf839ccdd6530577a8

✔️ noop SUCCESS in 0s
❌ podified-multinode-edpm-deployment-crc-bootstrap-staging-ironic RETRY_LIMIT in 8m 13s
✔️ cifmw-molecule-ci_multus SUCCESS in 15m 11s

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/853a8a89411a40dd83e88f4e5ddec82d

✔️ noop SUCCESS in 0s
❌ podified-multinode-edpm-deployment-crc-bootstrap-staging-ironic RETRY_LIMIT in 7m 54s
✔️ cifmw-molecule-ci_multus SUCCESS in 16m 17s

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/f8081759826d4834b1e9dafe39ee3e1c

✔️ noop SUCCESS in 0s
❌ podified-multinode-edpm-deployment-crc-bootstrap-staging-ironic RETRY_LIMIT in 8m 01s
✔️ cifmw-molecule-ci_multus SUCCESS in 12m 18s

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/968286885ed8495ebc6dedba4d34982f

✔️ noop SUCCESS in 0s
❌ podified-multinode-edpm-deployment-crc-bootstrap-staging-ironic RETRY_LIMIT in 8m 20s
✔️ cifmw-molecule-ci_multus SUCCESS in 15m 18s

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/73f876d0d656433eb018fb79940eedb3

✔️ noop SUCCESS in 0s
❌ podified-multinode-edpm-deployment-crc-bootstrap-staging-ironic RETRY_LIMIT in 8m 54s
✔️ cifmw-molecule-ci_multus SUCCESS in 19m 34s

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/200ca10fe5d84da0a505969ace4236f6

✔️ noop SUCCESS in 0s
❌ podified-multinode-edpm-deployment-crc-bootstrap-staging-ironic RETRY_LIMIT in 8m 45s
✔️ cifmw-molecule-ci_multus SUCCESS in 12m 42s

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/ccf772b9246e433f87487394964d4bd5

✔️ noop SUCCESS in 0s
❌ podified-multinode-edpm-deployment-crc-bootstrap-staging-ironic RETRY_LIMIT in 8m 55s
✔️ cifmw-molecule-ci_multus SUCCESS in 23m 53s

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/e1382b6a222140cc9bb55436814bfc5d

✔️ noop SUCCESS in 0s
❌ podified-multinode-edpm-deployment-crc-bootstrap-staging-ironic RETRY_LIMIT in 8m 25s
✔️ cifmw-molecule-ci_multus SUCCESS in 14m 10s

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/80fd3621d337418ea9bc8157b2d591b0

✔️ noop SUCCESS in 0s
❌ podified-multinode-edpm-deployment-crc-bootstrap-staging-ironic RETRY_LIMIT in 8m 09s
❌ cifmw-molecule-ci_multus FAILURE in 18m 18s

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/855cc28097de45c7a75165420e1ceafa

✔️ noop SUCCESS in 0s
❌ podified-multinode-edpm-deployment-crc-bootstrap-staging-ironic RETRY_LIMIT in 8m 08s
❌ cifmw-molecule-ci_multus FAILURE in 21m 37s

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/ea002e2a23a94b16ba1e366f66190b9c

✔️ noop SUCCESS in 0s
❌ podified-multinode-edpm-deployment-crc-bootstrap-staging-ironic RETRY_LIMIT in 8m 05s
✔️ cifmw-molecule-ci_multus SUCCESS in 18m 37s

@lewisdenny lewisdenny force-pushed the refresh_ci_multus branch 3 times, most recently from bc10cbf to e9e1037 Compare October 30, 2024 00:00
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/f0bda93907774b11a5eaee31d4cd41c1

❌ openstack-k8s-operators-content-provider FAILURE Job openstack-k8s-operators-content-provider requires artifact(s) cifmw-molecule provided by build a89d05265ce74fbfbb1815f70d694980 (triggered by change 2494 on project openstack-k8s-operators/ci-framework), but that build failed with result "FAILURE"
⚠️ podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ cifmw-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 7m 19s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 33s
✔️ build-push-container-cifmw-client SUCCESS in 37m 10s
✔️ cifmw-molecule-ci_multus SUCCESS in 16m 39s

@lewisdenny
Copy link
Collaborator Author

recheck

@lewisdenny lewisdenny marked this pull request as ready for review October 30, 2024 18:48
@lewisdenny lewisdenny requested a review from a team October 30, 2024 18:48
pablintino
pablintino reviewed Oct 31, 2024
View reviewed changes
.markdownlint.yaml Outdated Show resolved Hide resolved
roles/ci_multus/tasks/main.yml Outdated Show resolved Hide resolved
roles/ci_multus/molecule/resources/verify_clean.yml Outdated Show resolved Hide resolved
roles/ci_multus/molecule/resources/verify.yml Outdated Show resolved Hide resolved
roles/ci_multus/templates/nad.yml.j2 Outdated Show resolved Hide resolved
@lewisdenny
Copy link
Collaborator Author

Thank you for the review Pablo, please check once more.

One more thing I changed was to backup the manifest before cleaning so we can still check cleaning works but also check the manifest is rendered correctly.

@lewisdenny lewisdenny requested review from pablintino and a team November 1, 2024 01:38
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/e52428886abd4986886c82fdafa19c29

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 32m 46s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 12m 22s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 20m 44s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 10s
❌ cifmw-pod-pre-commit FAILURE in 5m 35s
✔️ build-push-container-cifmw-client SUCCESS in 36m 30s
✔️ cifmw-molecule-ci_multus SUCCESS in 15m 11s
❌ cifmw-molecule-ci_nmstate FAILURE in 20m 31s

@lewisdenny
[ci_multus] Refactor role
c9370fa 
The ci_multus role was created but unused, this patch refreshes it as we
will begin to use it in the new job to test Ironic.
@frenzyfriday
Copy link
Contributor

/lgtm

becaus the podified-multinode-edpm-deployment-crc-bootstrap-staging-ironic job is green on patch #2495 😅

@openshift-ci openshift-ci bot added the lgtm label Nov 4, 2024
@pablintino
Copy link
Collaborator

/approve

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pablintino

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Nov 4, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 5c02344 into openstack-k8s-operators:main Nov 4, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablintino pablintino Awaiting requested review from pablintino

Assignees

@frenzyfriday frenzyfriday

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lewisdenny @frenzyfriday @pablintino