Update Molecule config for local use #2494
Conversation
lewisdenny
commented
Oct 29, 2024
lewisdenny
commented
- Change container name to instance to match what runs in CI so scenarios can be written to run locally and in CI without tweaks
- Remove unused TRIPLEO_ANSIBLE overrides
- Remove unused YAML anchors
|
Skipping CI for Draft Pull Request. |
- Change container name to instance to match what runs in CI so scenarios can be written to run locally and in CI without tweaks - Remove unused TRIPLEO_ANSIBLE overrides - Remove unused YAML anchors
lewisdenny
force-pushed
the
update_molecule_podman_config
branch
from
bfa5ae8
to
3767e98
Compare
|
recheck |
|
recheck |
|
recheck |
|
recheck |
|
recheck |
|
@openstack-k8s-operators/cifmw-squad Hey folks, requesting an override for this patch -_- |
|
/override rdoproject.org/github-check |
|
@pablintino: Overrode contexts on behalf of pablintino: rdoproject.org/github-check In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pablintino The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| config_options: | ||
| defaults: | ||
| remote_tmp: /tmp | ||
|
|
||
| scenario: |
There was a problem hiding this comment.
lgtm, but I am trying to get some context:
what was this scenario being used for?
There was a problem hiding this comment.
So how the Molecule test works is it merges the configs together, each test under roles//molecule/* has it's own partial config. The idea being that config_podman.yml holds the common config for all the tests and then the test overrides/sets what is needed for the role. For example setting hostvars.
Scenarios is not something that should be defined as a default but left to each test to set themselves :)
|
/lgtm |
openshift-merge-bot
bot
merged commit 6f73675
into
openstack-k8s-operators:main
