send COLORTERM environment variable #496
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
most terminals that support truecolor set the `COLORTERM=truecolor` environment variable. currently, openssh only sends `TERM` by default. I believe we could send COLORTERM, too, so things running on the target server may properly detect colors. That said, it has been a long time since I last did any C, and I don't know the codebase, but this is a try... happy to work more on it with some guidance if you think this is a good thing to do. Cheers!
|
This isn't sufficient, as TERM has special handling in the ssh session protocol (see https://datatracker.ietf.org/doc/html/rfc4254#section-6.2) that doesn't exist for COLORTERM. Fortunately you can get COLORTERM sent without any code changes at all, using the existing environment variable passing support. Just put |
|
Hey! Thanks for the response! Yep, I'm aware of My idea was to send/accept Not sure if it makes sense, nor if its something SSH wants as a project, but I thought it would be nice. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
most terminals that support truecolor set the
COLORTERM=truecolorenvironment variable.currently, openssh only sends
TERMby default. I believe we could send COLORTERM, too, so things running on the target server may properly detect colors.That said, it has been a long time since I last did any C, and I don't know the codebase, but this is a try... happy to work more on it with some guidance if you think this is a good thing to do.
Cheers!