Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V2.1 spring security upgrade #1148

Merged
merged 8 commits into from
Oct 4, 2022
Merged

V2.1 spring security upgrade #1148

merged 8 commits into from
Oct 4, 2022

Conversation

hilpitome
Copy link
Contributor

No description provided.

@hilpitome hilpitome changed the base branch from master to v2.1 September 12, 2022 08:29
pom.xml Outdated
@@ -28,6 +28,7 @@
<opensrp.connector.version>2.4.1-SNAPSHOT</opensrp.connector.version>
<opensrp.interface.version>2.0.1-SNAPSHOT</opensrp.interface.version>
<powermock.version>2.0.5</powermock.version>
<opensrp-server-openlmis-stock-version>1.1.2-SNAPSHOT</opensrp-server-openlmis-stock-version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is supposed to be an update of dependencies. Why was this added?

pom.xml Outdated
<artifactId>lombok</artifactId>
<version>${lombok.version}</version>
</path>
</annotationProcessorPaths>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should all these dependencies be added? Is this a mistake of cherry-picking from the master server-web? Kindly check

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will check

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kindly check this again

pom.xml Outdated
<properties>
<plan.generation.profile>plan-generation</plan.generation.profile>
</properties>
</profile>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These also

try {
writeListener.onWritePossible();
} catch (IOException e){
writeListener.onError(e);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's log this also

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noted

try {
readListener.onDataAvailable();
} catch (IOException e) {
readListener.onError(e);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Log this error

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noted as well

pom.xml Outdated
<artifactId>lombok</artifactId>
<version>${lombok.version}</version>
</path>
</annotationProcessorPaths>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kindly check this again

@hilpitome hilpitome merged commit 893d719 into v2.1 Oct 4, 2022
@hilpitome hilpitome deleted the v2.1-spring-security-upgrade branch October 4, 2022 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants