added migration for invalidating the client to trigger a revalidation [DO NOT MERGE] #2108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Remove nexus.pentaho from the repositories in one of the |
hilpitome
reviewed
Jan 24, 2023
Comment on lines
+137
to
+138
| db.execSQL("UPDATE client Set validationStatus = 'Invalid'"); | ||
| } |
There was a problem hiding this comment.
I think it is better to use constants for the field and field value in this query to limit mistakes
ekigamba
suggested changes
Jan 27, 2023
| @@ -268,7 +268,7 @@ android { | |||
| buildConfigField "String", 'DEFAULT_LOCATION', '"VILLAGE/COMMUNAUTE"' | |||
| buildConfigField "int", "MAX_CONNECTION_TIMEOUT", '5' | |||
| buildConfigField "int", "MAX_READ_TIMEOUT", '5' | |||
| buildConfigField "int", "DATABASE_VERSION", '12' | |||
| buildConfigField "int", "DATABASE_VERSION", '13' | |||
There was a problem hiding this comment.
Label the PR to indicate the update is for DRC only
|
Kindly fix the build errors |
junaidwarsivd
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue ref https://github.com/opensrp/support/issues/234