Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide QR when using summary mode #3661

Merged
merged 1 commit into from
Dec 16, 2024
Merged

Conversation

FikriMilano
Copy link
Collaborator

IMPORTANT: Where possible all PRs must be linked to a Github issue

Provide QR when using summary mode. Without this change, when you open a form with summary mode, no previously answered questions will be displayed. Summary mode needs QR when opening a form. Same thing like edit or read only mode.

Engineer Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app
  • I have checked that this PR does NOT introduce breaking changes that require an update to Content and/or Configs? If it does add a sample here or a link to exactly what changes need to be made to the content.

Code Reviewer Checklist

  • I have verified Unit tests have been written for any new feature(s) and edge cases
  • I have verified any strings visible on UI components are in the strings.xml file
  • I have verifed the CHANGELOG.md file has any notable changes to the codebase
  • I have verified the solution has been implemented in a configurable and generic way for reuseable components
  • I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

@FikriMilano FikriMilano self-assigned this Dec 16, 2024
Copy link

codecov bot commented Dec 16, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 26.8%. Comparing base (0571c2d) to head (1c76b0c).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...e/quest/ui/questionnaire/QuestionnaireViewModel.kt 0.0% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##              main   #3661     +/-   ##
=========================================
- Coverage     26.8%   26.8%   -0.1%     
  Complexity     801     801             
=========================================
  Files          284     284             
  Lines        15053   15054      +1     
  Branches      2667    2668      +1     
=========================================
  Hits          4036    4036             
- Misses       10500   10501      +1     
  Partials       517     517             
Flag Coverage Δ
engine 62.5% <ø> (ø)
geowidget 16.0% <ø> (ø)
quest 5.1% <0.0%> (-0.1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...e/quest/ui/questionnaire/QuestionnaireViewModel.kt 4.6% <0.0%> (-0.1%) ⬇️

@FikriMilano FikriMilano added this pull request to the merge queue Dec 16, 2024
Merged via the queue into main with commit 7767726 Dec 16, 2024
4 of 5 checks passed
@FikriMilano FikriMilano deleted the hotfix-get-qr-on-summary-mode branch December 16, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants