-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Maximum Heap Size From 6 to 10 GB #3656
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3656 +/- ##
=======================================
Coverage 38.8% 38.9%
- Complexity 1155 1160 +5
=======================================
Files 284 284
Lines 15032 15060 +28
Branches 2663 2669 +6
=======================================
+ Hits 5846 5861 +15
- Misses 8346 8356 +10
- Partials 840 843 +3
Flags with carried forward coverage won't be shown. Click here to find out more. |
@dubdabasoduba Did you try disabling minification in Quest?
|
I have investigated and noted the build runs out of memory with minification enabled. Can we disable the minification for now? I would want to test these changes locally first. The current workaround is to disable minification. |
Here is the PR for the workaround #3660 |
@ellykits We can use the workaround right now but we do need minification added on the APKs by default for the future. |
IMPORTANT: Where possible all PRs must be linked to a Github issue
Fixes [link to issue]
Engineer Checklist
strings.xml
file./gradlew spotlessApply
and./gradlew spotlessCheck
to check my code follows the project's style guideCode Reviewer Checklist
strings.xml
file