Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Maximum Heap Size From 6 to 10 GB #3656

Merged
merged 6 commits into from
Dec 16, 2024

Conversation

dubdabasoduba
Copy link
Member

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes [link to issue]

Engineer Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app
  • I have checked that this PR does NOT introduce breaking changes that require an update to Content and/or Configs? If it does add a sample here or a link to exactly what changes need to be made to the content.

Code Reviewer Checklist

  • I have verified Unit tests have been written for any new feature(s) and edge cases
  • I have verified any strings visible on UI components are in the strings.xml file
  • I have verifed the CHANGELOG.md file has any notable changes to the codebase
  • I have verified the solution has been implemented in a configurable and generic way for reuseable components
  • I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

@dubdabasoduba dubdabasoduba self-assigned this Dec 11, 2024
Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 38.9%. Comparing base (1325652) to head (130b63a).
Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##              main   #3656   +/-   ##
=======================================
  Coverage     38.8%   38.9%           
- Complexity    1155    1160    +5     
=======================================
  Files          284     284           
  Lines        15032   15060   +28     
  Branches      2663    2669    +6     
=======================================
+ Hits          5846    5861   +15     
- Misses        8346    8356   +10     
- Partials       840     843    +3     
Flag Coverage Δ
engine 62.5% <ø> (ø)
geowidget 16.0% <ø> (ø)
quest 25.1% <ø> (+<0.1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

@dubdabasoduba dubdabasoduba requested a review from qiarie December 13, 2024 10:15
@ellykits
Copy link
Collaborator

@dubdabasoduba Did you try disabling minification in Quest?

 isMinifyEnabled = false
 isShrinkResources = false

@ellykits
Copy link
Collaborator

I have investigated and noted the build runs out of memory with minification enabled. Can we disable the minification for now? I would want to test these changes locally first. The current workaround is to disable minification.

@ellykits ellykits added the DNM DO NOT MERGE label Dec 13, 2024
@ellykits
Copy link
Collaborator

Here is the PR for the workaround #3660

@dubdabasoduba
Copy link
Member Author

I have investigated and noted the build runs out of memory with minification enabled. Can we disable the minification for now? I would want to test these changes locally first. The current workaround is to disable minification.

@ellykits We can use the workaround right now but we do need minification added on the APKs by default for the future.

@dubdabasoduba dubdabasoduba merged commit b97dd66 into main Dec 16, 2024
5 checks passed
@dubdabasoduba dubdabasoduba deleted the feature/fix_java_heap_error branch December 16, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants