Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate FHIR SDK Artifacts to the latest version changes #3655

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

ndegwamartin
Copy link
Contributor

Upgrades Engine and SDC artifact

Fixes [link to issue]

Engineer Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app
  • I have checked that this PR does NOT introduce breaking changes that require an update to Content and/or Configs? If it does add a sample here or a link to exactly what changes need to be made to the content.

Code Reviewer Checklist

  • I have verified Unit tests have been written for any new feature(s) and edge cases
  • I have verified any strings visible on UI components are in the strings.xml file
  • I have verifed the CHANGELOG.md file has any notable changes to the codebase
  • I have verified the solution has been implemented in a configurable and generic way for reuseable components
  • I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 26.8%. Comparing base (aef0fdc) to head (19f97bb).
Report is 6 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##              main   #3655     +/-   ##
=========================================
- Coverage     28.1%   26.8%   -1.4%     
- Complexity     798     801      +3     
=========================================
  Files          282     284      +2     
  Lines        14495   15053    +558     
  Branches      2584    2667     +83     
=========================================
- Hits          4084    4036     -48     
- Misses        9872   10500    +628     
+ Partials       539     517     -22     
Flag Coverage Δ
engine 62.5% <ø> (-1.7%) ⬇️
geowidget 16.0% <ø> (ø)
quest 5.1% <ø> (-0.8%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 30 files with indirect coverage changes

@ndegwamartin ndegwamartin added this pull request to the merge queue Dec 11, 2024
Merged via the queue into main with commit 516f977 Dec 11, 2024
5 checks passed
@ndegwamartin ndegwamartin deleted the ndegwamartin-patch-1 branch December 11, 2024 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants