Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate FHIR SDK Artifacts to the latest version changes #3640

Merged
merged 4 commits into from
Dec 1, 2024

Conversation

ndegwamartin
Copy link
Contributor

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes [link to issue]

Engineer Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app
  • I have checked that this PR does NOT introduce breaking changes that require an update to Content and/or Configs? If it does add a sample here or a link to exactly what changes need to be made to the content.

Code Reviewer Checklist

  • I have verified Unit tests have been written for any new feature(s) and edge cases
  • I have verified any strings visible on UI components are in the strings.xml file
  • I have verifed the CHANGELOG.md file has any notable changes to the codebase
  • I have verified the solution has been implemented in a configurable and generic way for reuseable components
  • I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

Copy link

codecov bot commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.3%. Comparing base (8ee171a) to head (4073325).
Report is 5 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##              main   #3640   +/-   ##
=======================================
  Coverage     27.3%   27.3%           
+ Complexity     787     785    -2     
=======================================
  Files          282     282           
  Lines        14699   14699           
  Branches      2634    2633    -1     
=======================================
  Hits          4023    4023           
  Misses       10132   10132           
  Partials       544     544           
Flag Coverage Δ
engine 63.8% <ø> (ø)
geowidget 16.0% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

LZRS
LZRS previously approved these changes Nov 29, 2024
@ndegwamartin ndegwamartin added this pull request to the merge queue Nov 29, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 29, 2024
qiarie
qiarie previously approved these changes Nov 29, 2024
dubdabasoduba
dubdabasoduba previously approved these changes Nov 29, 2024
@ndegwamartin ndegwamartin dismissed stale reviews from dubdabasoduba and qiarie via da78e99 November 30, 2024 11:40
ellykits
ellykits previously approved these changes Dec 1, 2024
@ndegwamartin ndegwamartin added this pull request to the merge queue Dec 1, 2024
@ellykits ellykits removed this pull request from the merge queue due to a manual request Dec 1, 2024
@ellykits ellykits merged commit 6197f7d into main Dec 1, 2024
5 checks passed
@ellykits ellykits deleted the ndegwamartin-patch-1 branch December 1, 2024 12:44
Lentumunai-Mark pushed a commit that referenced this pull request Dec 2, 2024
* Migrate FHIR SDK Artifacts to the latest version changes

* Reduce the verbosity of logs on CI 🧱

* Refactor FhirCarePlanGeneratorTest unit test for Future Proofing 💚

---------

Co-authored-by: Benjamin Mwalimu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants