Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor implementation for loading data on repositories to improve performance #3634

Merged
merged 34 commits into from
Dec 4, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
fc8bfeb
Start register data refactor
ellykits Nov 19, 2024
17919e5
Merge branch 'main' into register-performance-improv
ellykits Nov 19, 2024
59f7595
Fix loading related resources data
ellykits Nov 20, 2024
be52ef9
Optimize import
ellykits Nov 20, 2024
dd458d7
Refactor implementation for counting related resources
ellykits Nov 21, 2024
4e6c8c6
Merge branch 'main' into register-performance-improv
ellykits Nov 21, 2024
3b2b79f
Refactor implementation for loading profile data
ellykits Nov 22, 2024
7cf7744
Refactor the rest of implementation using DefaultRepository
ellykits Nov 22, 2024
ce65a39
Merge branch 'main' into register-performance-improv
ellykits Nov 22, 2024
1a9d3ac
Use coding system on REL filter query
ellykits Nov 22, 2024
2de6d3f
Fix count with REL filter applied
ellykits Nov 22, 2024
28a6891
Refactor retrieval of REL tag locationIds
ellykits Nov 25, 2024
20efd0a
Revert paging3 implementation
ellykits Nov 25, 2024
636a739
Set pager prefetch size to half of page size
ellykits Nov 25, 2024
46362b5
Run spotless
ellykits Nov 25, 2024
557e024
Refactor code
ellykits Nov 25, 2024
58f1d66
Fix redundant count of related resources
ellykits Nov 26, 2024
2160588
Refactor implementation
ellykits Nov 26, 2024
c97acc8
Remove unnecessary coroutine context switching
ellykits Nov 26, 2024
fec8fd3
Merge branch 'main' into register-performance-improv
ellykits Nov 26, 2024
0e74101
Fix failing engine tests
ellykits Nov 27, 2024
5a99c87
Fix failing tests
ellykits Nov 27, 2024
c49d53b
Run spotlessApply
ellykits Nov 27, 2024
78e636c
Merge branch 'main' into register-performance-improv
ellykits Nov 27, 2024
1d61f35
Run spotless
ellykits Nov 28, 2024
69ef4bd
Fix failing lint check
ellykits Nov 28, 2024
1d1481e
Run spotlessApply
ellykits Nov 28, 2024
e46af39
Fix failing lint check
ellykits Nov 28, 2024
d868458
Run spotlessApply
ellykits Nov 28, 2024
9ea20f8
Merge branch 'main' into register-performance-improv
ellykits Dec 1, 2024
b18aa83
Merge branch 'main' into register-performance-improv
ellykits Dec 4, 2024
90bfcc5
Fix failing tests
ellykits Dec 4, 2024
1ac4e8b
Run spotlessApply
ellykits Dec 4, 2024
4345469
Format code
ellykits Dec 4, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
data class MigrationConfig(
val updateValues: List<UpdateValueConfig>,
val resourceConfig: FhirResourceConfig,
val rules: List<RuleConfig>,
val rules: List<RuleConfig> = emptyList(),

Check warning on line 28 in android/engine/src/main/java/org/smartregister/fhircore/engine/configuration/migration/MigrationConfig.kt

View check run for this annotation

Codecov / codecov/patch

android/engine/src/main/java/org/smartregister/fhircore/engine/configuration/migration/MigrationConfig.kt#L28

Added line #L28 was not covered by tests
val version: Int,
val purgeAffectedResources: Boolean = false,
val createLocalChangeEntitiesAfterPurge: Boolean = true,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ data class RegisterConfiguration(
val registerCard: RegisterCardConfig = RegisterCardConfig(),
val fabActions: List<NavigationMenuConfig> = emptyList(),
val noResults: NoResultsConfig? = null,
val pageSize: Int = 10,
val pageSize: Int = 20,
val activeResourceFilters: List<ActiveResourceFilterConfig> =
listOf(
ActiveResourceFilterConfig(resourceType = ResourceType.Patient, active = true),
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ data class RegisterContentConfig(
val separator: String? = null,
val display: String? = null,
val placeholderColor: String? = null,
val rules: List<RuleConfig>? = null,
val rules: List<RuleConfig> = emptyList(),
val visible: Boolean? = null,
val computedRules: List<String>? = null,
val searchByQrCode: Boolean? = null,
Expand Down
Loading
Loading