Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re populate questionnaire response ID when removing unanswered questions #3614

Merged
merged 5 commits into from
Nov 15, 2024

Conversation

Rkareko
Copy link
Contributor

@Rkareko Rkareko commented Nov 15, 2024

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes #3611

Engineer Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app
  • I have checked that this PR does NOT introduce breaking changes that require an update to Content and/or Configs? If it does add a sample here or a link to exactly what changes need to be made to the content.

Code Reviewer Checklist

  • I have verified Unit tests have been written for any new feature(s) and edge cases
  • I have verified any strings visible on UI components are in the strings.xml file
  • I have verifed the CHANGELOG.md file has any notable changes to the codebase
  • I have verified the solution has been implemented in a configurable and generic way for reuseable components
  • I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

@Rkareko Rkareko self-assigned this Nov 15, 2024
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 27.3%. Comparing base (978d050) to head (7b0e8d1).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
...e/quest/ui/questionnaire/QuestionnaireViewModel.kt 0.0% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##              main   #3614     +/-   ##
=========================================
+ Coverage     27.1%   27.3%   +0.1%     
- Complexity     778     780      +2     
=========================================
  Files          281     281             
  Lines        14622   14651     +29     
  Branches      2616    2628     +12     
=========================================
+ Hits          3976    4008     +32     
+ Misses       10104   10099      -5     
- Partials       542     544      +2     
Flag Coverage Δ
engine 63.8% <ø> (+<0.1%) ⬆️
geowidget 16.0% <ø> (ø)
quest 5.9% <0.0%> (+0.2%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...e/quest/ui/questionnaire/QuestionnaireViewModel.kt 5.9% <0.0%> (+2.5%) ⬆️

... and 1 file with indirect coverage changes

@Rkareko Rkareko marked this pull request as ready for review November 15, 2024 11:33
@pld pld merged commit 22a080b into main Nov 15, 2024
4 of 5 checks passed
@pld pld deleted the 3611-save-draft-more-than-once branch November 15, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Save Draft changes functionality creates multiple Questionnaire Responses instead of updating existing one
2 participants