-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show the LoaderDialog when syncing the Location data #3598
Show the LoaderDialog when syncing the Location data #3598
Conversation
Update the LoaderDialog: - Make box and progressBar size dynamic - Make the progressDialog message as optional - Add the ability to show either the ProgressBar or LineSpinFadeLoaderProgressIndicator
Show a non blocking dialog when applying location filtering
Text( | ||
text = it, | ||
color = Color.White, | ||
fontSize = 14.sp, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ellykits @qaziabubakar-vd Does this font size align with the default font size in other areas of the app?
|
||
if (showPercentageProgress) { | ||
Text( | ||
fontSize = 15.sp, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ellykits @qaziabubakar-vd Does this font size align with the default font size in other areas of the app?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't changed any font sizes, we were showing this same font size before in the LoaderDialog class, I just refactored it a little for my implementation.
I can confirm with @ellykits if the size is aligned with the rest of the app.
Share screenshot/video with demo for review @qaziabubakar-vd |
Here is the video recording of the implementation for showing the LoaderDialog: |
For showing the LoaderDialog for the CustomSyncWorker, that is still a WIP. Summary of Attempted Solutions so far
Next Steps, Current flow that I am trying:
This approach might give us more control into what the worker is doing at runtime and help identify bottlenecks or delays in the |
* Implement LineSpinFadeLoaderProgressIndicator Signed-off-by: Elly Kitoto <[email protected]> * Run spotless Signed-off-by: Elly Kitoto <[email protected]> * Fix spacing Signed-off-by: Elly Kitoto <[email protected]> * Show the loader dialog when syncing the location data (#3598) * Show the LoaderDialog when syncing the Location data Update the LoaderDialog: - Make box and progressBar size dynamic - Make the progressDialog message as optional - Add the ability to show either the ProgressBar or LineSpinFadeLoaderProgressIndicator * Add an option in the LoaderDialog to show a dialog with non blocking UI Show a non blocking dialog when applying location filtering * clean-up: rename variables * fix tests * 🚧 Increase the loading dialog size on the geowidget screen * Fix showing map snackbar messages Signed-off-by: Elly Kitoto <[email protected]> * Formate code Signed-off-by: Elly Kitoto <[email protected]> --------- Signed-off-by: Elly Kitoto <[email protected]> Co-authored-by: qaziabubakar-vd <[email protected]> Co-authored-by: Benjamin Mwalimu <[email protected]> Co-authored-by: qaziabubakar-vd <[email protected]>
Show the LoaderDialog when syncing the Location data
Update the LoaderDialog:
- Make box and progressBar size dynamic
- Make the progressDialog message as optional
- Add the ability to show either the ProgressBar or LineSpinFadeLoaderProgressIndicator
IMPORTANT: Where possible all PRs must be linked to a Github issue
Fixes [https://github.com//issues/3544]
Engineer Checklist
strings.xml
file./gradlew spotlessApply
and./gradlew spotlessCheck
to check my code follows the project's style guideCode Reviewer Checklist
strings.xml
file