Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Save draft MVP functionality #3596

Merged
merged 14 commits into from
Nov 13, 2024
Merged

Implement Save draft MVP functionality #3596

merged 14 commits into from
Nov 13, 2024

Conversation

Rkareko
Copy link
Contributor

@Rkareko Rkareko commented Nov 7, 2024

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes #3541

Engineer Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app
  • I have checked that this PR does NOT introduce breaking changes that require an update to Content and/or Configs? If it does add a sample here or a link to exactly what changes need to be made to the content.

Code Reviewer Checklist

  • I have verified Unit tests have been written for any new feature(s) and edge cases
  • I have verified any strings visible on UI components are in the strings.xml file
  • I have verifed the CHANGELOG.md file has any notable changes to the codebase
  • I have verified the solution has been implemented in a configurable and generic way for reuseable components
  • I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

Update save draft questionnaire response to have subject and questionnaire values
@Rkareko Rkareko self-assigned this Nov 7, 2024
Copy link

codecov bot commented Nov 7, 2024

Codecov Report

Attention: Patch coverage is 20.00000% with 32 lines in your changes missing coverage. Please review.

Project coverage is 27.1%. Comparing base (6fc15b0) to head (b86ac44).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...e/quest/ui/questionnaire/QuestionnaireViewModel.kt 4.3% 22 Missing ⚠️
...re/quest/ui/questionnaire/QuestionnaireActivity.kt 0.0% 6 Missing ⚠️
...re/engine/util/extension/QuestionnaireExtension.kt 20.0% 3 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##              main   #3596     +/-   ##
=========================================
- Coverage     27.1%   27.1%   -0.1%     
  Complexity     775     775             
=========================================
  Files          279     280      +1     
  Lines        14563   14606     +43     
  Branches      2608    2617      +9     
=========================================
+ Hits          3957    3967     +10     
- Misses       10065   10097     +32     
- Partials       541     542      +1     
Flag Coverage Δ
engine 63.7% <63.6%> (-0.1%) ⬇️
geowidget 16.0% <ø> (ø)
quest 5.7% <3.4%> (+<0.1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...tregister/fhircore/engine/ui/base/AlertDialogue.kt 79.6% <100.0%> (+0.9%) ⬆️
...re/engine/util/extension/QuestionnaireExtension.kt 55.3% <20.0%> (-1.6%) ⬇️
...re/quest/ui/questionnaire/QuestionnaireActivity.kt 3.7% <0.0%> (-0.1%) ⬇️
...e/quest/ui/questionnaire/QuestionnaireViewModel.kt 3.3% <4.3%> (+<0.1%) ⬆️

@Rkareko Rkareko marked this pull request as ready for review November 8, 2024 07:32
@Rkareko Rkareko requested review from ellykits and allan-on November 8, 2024 07:32
Copy link
Contributor

@f-odhiambo f-odhiambo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick feedback

  1. Edit not working in the PR
  2. The questionnaire is not dismissed once the user makes the selection
  3. Add docs to accompany this PR
    CC @Rkareko

@Rkareko
Copy link
Contributor Author

Rkareko commented Nov 12, 2024

Quick feedback

1. Edit not working in the PR

2. The questionnaire is not dismissed once the user makes the selection

3. Add docs to accompany this PR
   CC @Rkareko

these have been addressed

ellykits
ellykits previously approved these changes Nov 12, 2024
Copy link
Contributor

@f-odhiambo f-odhiambo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@f-odhiambo f-odhiambo enabled auto-merge November 12, 2024 14:31
@f-odhiambo f-odhiambo added this pull request to the merge queue Nov 13, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Nov 13, 2024
@Rkareko Rkareko merged commit e794590 into main Nov 13, 2024
4 of 5 checks passed
@Rkareko Rkareko deleted the 3541-save-draft-dialog branch November 13, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MVP drafting feature
3 participants