-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Save draft MVP functionality #3596
Conversation
Update save draft questionnaire response to have subject and questionnaire values
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3596 +/- ##
=========================================
- Coverage 27.1% 27.1% -0.1%
Complexity 775 775
=========================================
Files 279 280 +1
Lines 14563 14606 +43
Branches 2608 2617 +9
=========================================
+ Hits 3957 3967 +10
- Misses 10065 10097 +32
- Partials 541 542 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quick feedback
- Edit not working in the PR
- The questionnaire is not dismissed once the user makes the selection
- Add docs to accompany this PR
CC @Rkareko
close form when draft is saved
these have been addressed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
IMPORTANT: Where possible all PRs must be linked to a Github issue
Fixes #3541
Engineer Checklist
strings.xml
file./gradlew spotlessApply
and./gradlew spotlessCheck
to check my code follows the project's style guideCode Reviewer Checklist
strings.xml
file