Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom search param for Patient name and identifier #3563

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

Rkareko
Copy link
Contributor

@Rkareko Rkareko commented Oct 18, 2024

IMPORTANT: Where possible all PRs must be linked to a Github issue

Part of the Fixes for #3543

Engineer Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app
  • I have checked that this PR does NOT introduce breaking changes that require an update to Content and/or Configs? If it does add a sample here or a link to exactly what changes need to be made to the content.

Code Reviewer Checklist

  • I have verified Unit tests have been written for any new feature(s) and edge cases
  • I have verified any strings visible on UI components are in the strings.xml file
  • I have verifed the CHANGELOG.md file has any notable changes to the codebase
  • I have verified the solution has been implemented in a configurable and generic way for reuseable components
  • I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

@Rkareko Rkareko self-assigned this Oct 18, 2024
Copy link

codecov bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.2%. Comparing base (6014982) to head (196b9c5).
Report is 7 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##              main   #3563   +/-   ##
=======================================
  Coverage     27.2%   27.2%           
- Complexity     756     761    +5     
=======================================
  Files          278     278           
  Lines        14239   14285   +46     
  Branches      2582    2586    +4     
=======================================
+ Hits          3883    3896   +13     
- Misses        9818    9850   +32     
- Partials       538     539    +1     
Flag Coverage Δ
engine 63.7% <ø> (-0.1%) ⬇️
geowidget 15.4% <ø> (ø)
quest 5.6% <ø> (-0.1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@Rkareko Rkareko requested review from ellykits and LZRS October 18, 2024 06:47
@Rkareko Rkareko added this pull request to the merge queue Oct 18, 2024
Merged via the queue into main with commit 2fe2a47 Oct 18, 2024
5 checks passed
@Rkareko Rkareko deleted the patient-search-custom-search-param branch October 18, 2024 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants