Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support search by dynamic queries #3550

Merged
merged 10 commits into from
Oct 19, 2024
Merged

Support search by dynamic queries #3550

merged 10 commits into from
Oct 19, 2024

Conversation

ellykits
Copy link
Collaborator

@ellykits ellykits commented Oct 9, 2024

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes [link to issue]

Engineer Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app
  • I have checked that this PR does NOT introduce breaking changes that require an update to Content and/or Configs? If it does add a sample here or a link to exactly what changes need to be made to the content.

Code Reviewer Checklist

  • I have verified Unit tests have been written for any new feature(s) and edge cases
  • I have verified any strings visible on UI components are in the strings.xml file
  • I have verifed the CHANGELOG.md file has any notable changes to the codebase
  • I have verified the solution has been implemented in a configurable and generic way for reuseable components
  • I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

@codecov Codecov
Copy link

codecov bot commented Oct 9, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0.87719% with 113 lines in your changes missing coverage. Please review.

Project coverage is 27.2%. Comparing base (2fe2a47) to head (e9a0bf5).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...er/fhircore/quest/ui/register/RegisterViewModel.kt 0.0% 113 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##              main   #3550    +/-   ##
========================================
  Coverage     27.2%   27.2%            
- Complexity     761     775    +14     
========================================
  Files          278     278            
  Lines        14285   14425   +140     
  Branches      2586    2591     +5     
========================================
+ Hits          3896    3935    +39     
- Misses        9850    9951   +101     
  Partials       539     539
Flag Coverage Δ
engine 63.8% <ø> (+<0.1%) ⬆️
geowidget 15.4% <ø> (ø)
quest 5.8% <0.8%> (+0.1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ister/fhircore/quest/ui/register/RegisterScreen.kt 0.0% <ø> (ø)
...ster/fhircore/quest/ui/register/RegisterUiState.kt 100.0% <100.0%> (ø)
...er/fhircore/quest/ui/register/RegisterViewModel.kt 0.0% <0.0%> (ø)

... and 3 files with indirect coverage changes

@Rkareko Rkareko mentioned this pull request Oct 17, 2024
Closed
@ellykits ellykits marked this pull request as ready for review October 19, 2024 10:36
@ellykits
Copy link
Collaborator Author

I'd like to merge this for now. We can track the implementation for the remaining tests in this new issue #3570 during CHT.

@ellykits ellykits merged commit ff5c2b9 into main Oct 19, 2024
4 of 5 checks passed
@ellykits ellykits deleted the search-by-dynamic-query branch October 19, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ellykits @dubdabasoduba @Rkareko @pld