Manual APK release by flavor workflow configuration #3108
Conversation
ndegwamartin
force-pushed
the
manual-apk-release
branch
2 times, most recently
from
745d7c8 to
f788a78
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3108 +/- ##
==========================================
- Coverage 64.5% 29.8% -34.7%
+ Complexity 1075 652 -423
==========================================
Files 218 236 +18
Lines 9635 11074 +1439
Branches 1897 1928 +31
==========================================
- Hits 6218 3306 -2912
- Misses 2234 7338 +5104
+ Partials 1183 430 -753
Flags with carried forward coverage won't be shown. Click here to find out more. |
ndegwamartin
changed the title
ndegwamartin
requested review from
f-odhiambo,
dubdabasoduba,
ellykits,
Rkareko and
bonfaceshisakha
There was a problem hiding this comment.
Can we have some docs to guide on how to go about this? @ndegwamartin :)
|
Has this been tested @f-odhiambo and @ndegwamartin? |
|
@ellykits if you mean under development then yep! Check the APK and AAB artifacts here: |
| val calendar = Calendar.getInstance() | ||
| calendar.apply { | ||
| timeInMillis = | ||
| (timeInMillis - (1L * calendar.getActualMaximum(Calendar.DAY_OF_YEAR) * 24 * 3600 * 1000)) |
There was a problem hiding this comment.
I think this fix from @marklosh looks cleaner to me, fewer special numbers :D, https://github.com/opensrp/fhircore/pull/3116/files#diff-f7b77a5722cb99a28fd93c5bab900a5b20dfc103e66d798be9ccb8194c5c64f4R265
There was a problem hiding this comment.
Agreed, reverting this
ndegwamartin
force-pushed
the
manual-apk-release
branch
from
8b8c96f to
f06836a
Compare
* Update/Fix manual APK release workflow configuration * Fix unit test - Leap year bug ✅
Manual APK release Github Actions workflow configuration
Closes #2883