Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix read-only linkIds for questionnaires in Edit mode #3070

Closed
wants to merge 16 commits into from

Conversation

DebbieArita
Copy link
Contributor

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes [link to issue]

Engineer Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app
  • I have checked that this PR does NOT introduce breaking changes that require an update to Content and/or Configs? If it does add a sample here or a link to exactly what changes need to be made to the content.

Code Reviewer Checklist

  • I have verified Unit tests have been written for any new feature(s) and edge cases
  • I have verified any strings visible on UI components are in the strings.xml file
  • I have verifed the CHANGELOG.md file has any notable changes to the codebase
  • I have verified the solution has been implemented in a configurable and generic way for reuseable components
  • I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

@DebbieArita DebbieArita requested a review from ellykits February 14, 2024 13:42
Copy link

codecov bot commented Feb 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 29.9%. Comparing base (ac82739) to head (b953a48).
Report is 17 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##              main   #3070     +/-   ##
=========================================
+ Coverage     29.6%   29.9%   +0.3%     
- Complexity     658     671     +13     
=========================================
  Files          239     239             
  Lines        11204   11210      +6     
  Branches      1948    1945      -3     
=========================================
+ Hits          3323    3360     +37     
+ Misses        7447    7413     -34     
- Partials       434     437      +3     
Flag Coverage Δ
engine 66.5% <ø> (+0.3%) ⬆️
geowidget 47.2% <ø> (ø)
quest 5.7% <0.0%> (+0.2%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...hircore/engine/util/extension/ResourceExtension.kt 65.8% <ø> (-0.2%) ⬇️
...e/quest/ui/questionnaire/QuestionnaireViewModel.kt 3.5% <0.0%> (-0.1%) ⬇️

... and 3 files with indirect coverage changes

@ellykits
Copy link
Collaborator

@DebbieArita Fix failing CI so we can merge this.

@ellykits
Copy link
Collaborator

I am closing this PR. A new fix will be applied instead of this one.

@ellykits ellykits closed this May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants