Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test register screen composable #3062

Merged
merged 53 commits into from
Mar 19, 2024
Merged

Conversation

Raynafs
Copy link
Contributor

@Raynafs Raynafs commented Feb 13, 2024

IMPORTANT: Where possible all PRs must be linked to a Github issue

Engineer Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app
  • I have checked that this PR does NOT introduce breaking changes that require an update to Content and/or Configs? If it does add a sample here or a link to exactly what changes need to be made to the content.

Code Reviewer Checklist

  • I have verified Unit tests have been written for any new feature(s) and edge cases
  • I have verified any strings visible on UI components are in the strings.xml file
  • I have verifed the CHANGELOG.md file has any notable changes to the codebase
  • I have verified the solution has been implemented in a configurable and generic way for reuseable components
  • I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

@Raynafs Raynafs added Code Health Work In Progress Describes an items that is not complete. Mostly used for scoping issues of discussions labels Feb 13, 2024
@Raynafs Raynafs self-assigned this Feb 13, 2024
Copy link

codecov bot commented Feb 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 44 lines in your changes are missing coverage. Please review.

Project coverage is 29.6%. Comparing base (ac82739) to head (145a962).
Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##              main   #3062   +/-   ##
=======================================
  Coverage     29.6%   29.6%           
  Complexity     658     658           
=======================================
  Files          239     239           
  Lines        11204   11216   +12     
  Branches      1948    1950    +2     
=======================================
+ Hits          3323    3328    +5     
- Misses        7447    7452    +5     
- Partials       434     436    +2     
Flag Coverage Δ
engine 66.1% <0.0%> (-0.1%) ⬇️
geowidget 47.2% <ø> (ø)
quest 5.4% <0.0%> (-0.1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...core/engine/ui/components/register/LoaderDialog.kt 0.0% <0.0%> (ø)
...e/quest/ui/register/components/RegisterCardList.kt 0.0% <0.0%> (ø)
...ister/fhircore/quest/ui/register/RegisterScreen.kt 0.0% <0.0%> (ø)

@Raynafs Raynafs removed the Work In Progress Describes an items that is not complete. Mostly used for scoping issues of discussions label Feb 15, 2024
@Raynafs Raynafs requested a review from ellykits February 15, 2024 09:41
@ellykits
Copy link
Collaborator

It's interesting how codecov/patch is 0% here. Verify code coverage by running the jacoco test report gradle task locally.

@Raynafs
Copy link
Contributor Author

Raynafs commented Mar 15, 2024

It's interesting how codecov/patch is 0% here. Verify code coverage by running the jacoco test report gradle task locally.

Yes sure working on it,

@ndegwamartin ndegwamartin merged commit 73a67d3 into main Mar 19, 2024
4 of 5 checks passed
@ndegwamartin ndegwamartin deleted the test-register-screen-composable branch March 19, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants