Test changemanagingentity opens bottomsheet model #3031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3031 +/- ##
==========================================
- Coverage 64.5% 29.8% -34.7%
+ Complexity 1075 652 -423
==========================================
Files 218 236 +18
Lines 9635 11074 +1439
Branches 1897 1928 +31
==========================================
- Hits 6218 3306 -2912
- Misses 2234 7338 +5104
+ Partials 1183 430 -753
Flags with carried forward coverage won't be shown. Click here to find out more. |
SebaMutuku
changed the title
ellykits
requested changes
Feb 6, 2024
| @@ -210,4 +222,77 @@ class ProfileViewModelTest : RobolectricTest() { | |||
| profileViewModel.onEvent(event) | |||
| } | |||
| } | |||
|
|
|||
| @Test | |||
| fun testManagingEntityShowsProfileBottomSheetFragment() = runTest { | |||
There was a problem hiding this comment.
Rename test case to indicate what is actually being tested, what should be the expected behaviour?
E.g. testThatManagingEntityProfileBottomSheetIsShownOnActionTriggered
Comment on lines
275
to
281
| every { | ||
| fhirPathDataExtractor.extractValue( | ||
| managingEntityResource, | ||
| "name", | ||
| ) | ||
| } returns "memebr 1" | ||
| every { fhirPathDataExtractor.extractValue(managingEntityResource, any()) } returns "true" |
There was a problem hiding this comment.
Is it possible to avoid using mocks here? fhirPathDataExtractor is simply a utility class.
pld
approved these changes
Feb 6, 2024
Rkareko
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: Where possible all PRs must be linked to a Github issue
CHT
Engineer Checklist
strings.xmlfile./gradlew spotlessApplyand./gradlew spotlessCheckto check my code follows the project's style guideCode Reviewer Checklist
strings.xmlfile