-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GeoWidget Decouple Refactor #3020
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3020 +/- ##
=========================================
- Coverage 29.6% 27.9% -1.7%
- Complexity 658 689 +31
=========================================
Files 239 263 +24
Lines 11204 12381 +1177
Branches 1948 2164 +216
=========================================
+ Hits 3323 3465 +142
- Misses 7447 8457 +1010
- Partials 434 459 +25
Flags with carried forward coverage won't be shown. Click here to find out more.
|
FikriMilano
force-pushed
the
3002-geowidget-decouple-refactor
branch
from
February 1, 2024 13:27
d395a2b
to
e353865
Compare
- Responsible to launch the Geowidget module fragment - A place to define callbacks, listeners, and passing data to the map -
- Responsible in getting the locations to be populated into the geowidget module - The locationsFlow is the data source of truth - Responsible to launch a questionnaire and receiving its response
FikriMilano
force-pushed
the
3002-geowidget-decouple-refactor
branch
from
February 2, 2024 13:20
ad02569
to
52ab271
Compare
…' into 3002-geowidget-decouple-refactor
# Conflicts: # android/engine/src/main/java/org/smartregister/fhircore/engine/configuration/app/ApplicationConfiguration.kt # android/engine/src/main/java/org/smartregister/fhircore/engine/util/SharedPreferenceKey.kt # android/quest/src/main/java/org/smartregister/fhircore/quest/navigation/MainNavigationScreen.kt # android/quest/src/main/java/org/smartregister/fhircore/quest/navigation/NavigationArg.kt # android/quest/src/main/java/org/smartregister/fhircore/quest/ui/main/AppMainActivity.kt # android/quest/src/main/java/org/smartregister/fhircore/quest/util/LocationUtils.kt # android/quest/src/main/res/navigation/application_nav_graph.xml
* Fix configuration of add location button on map view * feedback updated
…' into 3002-geowidget-decouple-refactor
# Conflicts: # android/engine/src/main/java/org/smartregister/fhircore/engine/configuration/app/ApplicationConfiguration.kt
…' into 3002-geowidget-decouple-refactor
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: Where possible all PRs must be linked to a Github issue
Fixes #3002
Todo:
Engineer Checklist
strings.xml
file./gradlew spotlessApply
and./gradlew spotlessCheck
to check my code follows the project's style guideCode Reviewer Checklist
strings.xml
file