-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Location co-ordinates on questionnaire submission #2997
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2997 +/- ##
=========================================
- Coverage 29.8% 29.6% -0.2%
- Complexity 652 658 +6
=========================================
Files 236 239 +3
Lines 11086 11204 +118
Branches 1929 1948 +19
=========================================
+ Hits 3306 3323 +17
- Misses 7350 7447 +97
- Partials 430 434 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
...est/src/main/java/org/smartregister/fhircore/quest/ui/questionnaire/QuestionnaireActivity.kt
Outdated
Show resolved
Hide resolved
...est/src/main/java/org/smartregister/fhircore/quest/ui/questionnaire/QuestionnaireActivity.kt
Outdated
Show resolved
Hide resolved
|
||
if (applicationConfiguration.logQuestionnaireLocation) { | ||
fusedLocationClient = LocationServices.getFusedLocationProviderClient(this) | ||
getLocation() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this running in the foreground or background? If there is not a GPS fix, what happens?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pld There are some updates to the flow.
The GPS location request is made in the background when a questionnaire is launched. This is done after config, permissions and location services checks are complete. On submit, the GPS location - if available - is used to create the location resource.
is this tied to a specific issue? |
…into questionnaire-location
android/quest/src/main/java/org/smartregister/fhircore/quest/util/LocationUtils.kt
Outdated
Show resolved
Hide resolved
android/quest/src/main/java/org/smartregister/fhircore/quest/util/ResourceUtils.kt
Outdated
Show resolved
Hide resolved
…til/LocationUtils.kt Co-authored-by: Benjamin Mwalimu <[email protected]>
return true | ||
} | ||
|
||
fun getLocationPermissionLauncher( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@qiarie Update the link shared above. The above is a PR link for branch 0.2.5 but not a GitHub issue.
IMPORTANT: Where possible all PRs must be linked to a Github issue
Fixes #3072
Engineer Checklist
strings.xml
file./gradlew spotlessApply
and./gradlew spotlessCheck
to check my code follows the project's style guideCode Reviewer Checklist
strings.xml
file