Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MWCore] Internal release 0.1.21 - Prod 0.0.9 #2993

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

sevenreup
Copy link

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes [link to issue]

Engineer Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app
  • I have checked that this PR does NOT introduce breaking changes that require an update to Content and/or Configs? If it does add a sample here or a link to exactly what changes need to be made to the content.

Code Reviewer Checklist

  • I have verified Unit tests have been written for any new feature(s) and edge cases
  • I have verified any strings visible on UI components are in the strings.xml file
  • I have verifed the CHANGELOG.md file has any notable changes to the codebase
  • I have verified the solution has been implemented in a configurable and generic way for reuseable components
  • I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

Copy link

codecov bot commented Jan 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7a87706) 68.3% compared to head (74fb282) 68.3%.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff               @@
##             mwcore-dev   #2993     +/-   ##
==============================================
- Coverage          68.3%   68.3%   -0.1%     
+ Complexity          901     900      -1     
==============================================
  Files               164     164             
  Lines              7346    7346             
  Branches           1037    1037             
==============================================
- Hits               5021    5020      -1     
- Misses             1667    1668      +1     
  Partials            658     658             
Flag Coverage Δ
engine 68.3% <ø> (-0.1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

@sevenreup sevenreup requested a review from calmwalija January 23, 2024 13:47
@sevenreup sevenreup self-assigned this Jan 23, 2024
@sevenreup sevenreup requested a review from evance-mose January 23, 2024 13:47
@sevenreup sevenreup merged commit 96d01d0 into mwcore-dev Jan 24, 2024
4 checks passed
@sevenreup sevenreup deleted the internal-release-0.1.21 branch January 24, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants