Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MWCore] Validate extracted fhir resources #2875

Closed
wants to merge 1 commit into from

Conversation

LZRS
Copy link
Contributor

@LZRS LZRS commented Nov 21, 2023

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes #2853

Engineer Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app
  • I have checked that this PR does NOT introduce breaking changes that require an update to Content and/or Configs? If it does add a sample here or a link to exactly what changes need to be made to the content.

Code Reviewer Checklist

  • I have verified Unit tests have been written for any new feature(s) and edge cases
  • I have verified any strings visible on UI components are in the strings.xml file
  • I have verifed the CHANGELOG.md file has any notable changes to the codebase
  • I have verified the solution has been implemented in a configurable and generic way for reuseable components
  • I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

@LZRS LZRS self-assigned this Nov 21, 2023
@LZRS LZRS changed the title work in progress [MWCore] Validate extracted fhir resources Nov 21, 2023
@LZRS LZRS force-pushed the fix-sync-bundle-invalid-resource branch 3 times, most recently from 19f19d4 to 1178abe Compare November 27, 2023 09:30
Copy link

codecov bot commented Nov 27, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (96d01d0) 68.3% compared to head (b57ec78) 68.5%.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff               @@
##             mwcore-dev   #2875     +/-   ##
==============================================
+ Coverage          68.3%   68.5%   +0.1%     
- Complexity          901     903      +2     
==============================================
  Files               164     165      +1     
  Lines              7346    7370     +24     
  Branches           1037    1042      +5     
==============================================
+ Hits               5021    5049     +28     
+ Misses             1667    1665      -2     
+ Partials            658     656      -2     
Flag Coverage Δ
engine 68.5% <84.8%> (+0.1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...martregister/fhircore/engine/sync/AppSyncWorker.kt 78.5% <ø> (-7.2%) ⬇️
...core/engine/ui/questionnaire/ExtractionProgress.kt 100.0% <100.0%> (+50.0%) ⬆️
...e/engine/ui/questionnaire/QuestionnaireActivity.kt 78.9% <80.0%> (+1.5%) ⬆️
.../engine/ui/questionnaire/QuestionnaireViewModel.kt 75.2% <90.0%> (+1.4%) ⬆️
...re/engine/util/extension/FhirValidatorExtension.kt 71.4% <71.4%> (ø)

@LZRS LZRS force-pushed the fix-sync-bundle-invalid-resource branch 2 times, most recently from e5fb8fe to e3ab0e0 Compare November 27, 2023 21:45
@LZRS LZRS marked this pull request as ready for review November 28, 2023 06:39
@LZRS LZRS force-pushed the fix-sync-bundle-invalid-resource branch 2 times, most recently from 7920d27 to e54f30c Compare January 25, 2024 05:42
@LZRS LZRS force-pushed the fix-sync-bundle-invalid-resource branch from e54f30c to b57ec78 Compare January 25, 2024 05:43
@LZRS LZRS marked this pull request as draft January 25, 2024 14:18
@LZRS LZRS added the DNM DO NOT MERGE label Jan 25, 2024
@LZRS
Copy link
Contributor Author

LZRS commented May 14, 2024

Re-evaluated due to performance cost

@LZRS LZRS closed this May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DNM DO NOT MERGE Malawi CORE
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant