Optimization PR Clean up

opensrp · Sep 27, 2023 · 4890535 · 4890535
1 parent 402512d
commit 4890535
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 6 deletions.
diff --git a/src/main/java/org/smartregister/model/location/LocationHierarchyTree.java b/src/main/java/org/smartregister/model/location/LocationHierarchyTree.java
@@ -58,12 +58,9 @@ public void addLocation(Location location) {
      * @param locations
      */
     public void buildTreeFromList(List<Location> locations) {
-        long start = System.currentTimeMillis();
         for (Location location : locations) {
             addLocation(location);
         }
-        logger.info(String.format("LocationHierarchyTree.buildTreeFromList took : %d ms", System.currentTimeMillis() - start));
-
     }
 
     public Tree getLocationsHierarchy() {

diff --git a/src/test/java/org/smartregister/model/location/LocationHierarchyTreeTest.java b/src/test/java/org/smartregister/model/location/LocationHierarchyTreeTest.java
@@ -52,10 +52,9 @@ public void testAddLocationWithoutChildLocations() {
 
     @Test
     public void testBuildTreeFromList() {
-        List<Location> locationList = TestUtils.getTestLocations();
+        List<Location> locationList = getLocationList();
         LocationHierarchyTree locationHierarchyTree = new LocationHierarchyTree();
         locationHierarchyTree.buildTreeFromList(locationList);
-
         Tree tree = locationHierarchyTree.getLocationsHierarchy();
         assertNotNull(tree);
         assertNotNull(tree.getTree());

diff --git a/src/test/java/org/smartregister/model/location/utils/TestUtils.java b/src/test/java/org/smartregister/model/location/utils/TestUtils.java
@@ -14,7 +14,6 @@ public static List<Location> getTestLocations() {
 
         List<Location> locationList = new ArrayList<>();
 
-
         int parentId = 1;
 
         for (Integer i = 1; i <  TOTAL_LOCATIONS + 1; i++) {
Original file line number	Diff line number	Diff line change
Expand Up		@@ -14,7 +14,6 @@ public static List<Location> getTestLocations() {

		List<Location> locationList = new ArrayList<>();


		int parentId = 1;

		for (Integer i = 1; i < TOTAL_LOCATIONS + 1; i++) {
Expand Down