Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add #[\ReturnTypeWillChange] where needed #24

Merged
merged 1 commit into from
Mar 14, 2022

Conversation

Slamdunk
Copy link
Contributor

@Slamdunk Slamdunk added the bug Something isn't working label Mar 14, 2022
@codecov
Copy link

codecov bot commented Mar 14, 2022

Codecov Report

Merging #24 (6f39704) into main (152b978) will not change coverage.
The diff coverage is 97.05%.

Impacted file tree graph

@@            Coverage Diff            @@
##               main      #24   +/-   ##
=========================================
  Coverage     96.05%   96.05%           
  Complexity     1274     1274           
=========================================
  Files           106      106           
  Lines          3426     3426           
=========================================
  Hits           3291     3291           
  Misses          135      135           
Impacted Files Coverage Δ
src/Reader/ODS/RowIterator.php 95.50% <83.33%> (ø)
src/Reader/CSV/RowIterator.php 100.00% <100.00%> (ø)
src/Reader/CSV/SheetIterator.php 100.00% <100.00%> (ø)
src/Reader/ODS/SheetIterator.php 100.00% <100.00%> (ø)
src/Reader/XLSX/RowIterator.php 98.11% <100.00%> (ø)
src/Reader/XLSX/SheetIterator.php 100.00% <100.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 152b978...6f39704. Read the comment docs.

@Slamdunk Slamdunk merged commit 3eae85f into openspout:main Mar 14, 2022
@Slamdunk Slamdunk deleted the return_type_will_change branch March 14, 2022 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant