Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated index.html 'Become a sponsor' image object #290

Closed
wants to merge 2 commits into from
Closed

Updated index.html 'Become a sponsor' image object #290

wants to merge 2 commits into from

Conversation

sparsh-99
Copy link

@sparsh-99 sparsh-99 commented Jun 16, 2020

Fixes #285

Styled an image object by reducing its width as it is left-indent a bit.

  • Change its width from 150 to 140 to align it in the center.

Reduces the width of the 'Become a sponsor' image object to align it centered.
@stygian-96
Copy link

stygian-96 commented Jul 16, 2020

@sparsh-99 I inspected your update in chrome browser by doing the same change that you have made and I found that it has added some extra space over the image!!!

Screenshots -->

Before changing the width

Before

After changing the width

After

@sparsh-99
Copy link
Author

@stygian-96 The problem is in mobile view, the left margin is somewhat to the left. I only changed that.

@stygian-96
Copy link

@stygian-96 The problem is in mobile view, the left margin is somewhat to the left. I only changed that.

@sparsh-99 I inspected it in the mobile view too and I faced the same issue, it is adding some extra space on the top of the image.

Screenshots -->

Before :
Before-2

After :
After-2

@sparsh-99
Copy link
Author

I think you did some mistake, I inspect my changes once again. I think, I good to go for the PR.

Screenshots:-

Screenshot (64)

Screenshot (65)

vinitshahdeo
vinitshahdeo previously approved these changes Aug 9, 2020
@jancborchardt
Copy link
Member

I’m a bit confused, as the current https://opensourcedesign.net does already have the width set to 140px – but that actually seems to cause the issue with the misalignment for me?

@sparsh-99
Copy link
Author

sparsh-99 commented Nov 5, 2020

I’m a bit confused, as the current https://opensourcedesign.net does already have the width set to 140px – but that actually seems to cause the issue with the misalignment for me?

@jancborchardt The width 140px is set to of that "<image" tag but what I am proposing is the change in the width of the "<object" tag from 150px to 140px which not only aligning the button but also shrinking the extra space between the next paragraph.

  1. What you are looking for is this:-

Screenshot (175)

  1. and What I am proposing in the index.html file is this:-

Screenshot (176)

Are you getting the point @jancborchardt ?

@Erioldoesdesign
Copy link
Member

Not sure if this needs another look by someone who has better understanding of the changes but the PR is quite old now!

@Erioldoesdesign Erioldoesdesign added needs testing Needs another person other than the author of the issue to test waiting on reviewers Waiting on comment by reviewers - 3-6 month waiting period labels Jun 22, 2021
@Erioldoesdesign
Copy link
Member

Unless someone stops me, I'm going to close this PR without merging - especially since we're doing lots of redesign work on the website

Arhell
Arhell previously approved these changes Sep 21, 2021
Copy link

@alisamadiii alisamadiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed your codes, I find Object tag which I have to go and learn it.
Wish you all the best.

@Erioldoesdesign
Copy link
Member

@jancborchardt take another look maybe?

@SaptakS SaptakS dismissed stale reviews from Arhell and vinitshahdeo via 0c4c61a September 27, 2023 17:26
@Erioldoesdesign
Copy link
Member

@SaptakS should we merge this or close do you think?

@SaptakS
Copy link
Contributor

SaptakS commented Nov 2, 2023

@Erioldoesdesign this branch has conflicts that need to be resolved. Also, I think I am not happy with the solution. The width of the image is always calculated based on the height (since aspect ratio). Fixing the width works but is finicky and should be fixed as an attribute on our codeside in the <object> element with a width attribute equal to the width of the image (i.e. 140px). So might be easier to close this PR and create a new one.

cc @sparsh-99

@Erioldoesdesign
Copy link
Member

Closing this PR and it can be referenced in a new PR if someone else works on a similar issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs testing Needs another person other than the author of the issue to test waiting on reviewers Waiting on comment by reviewers - 3-6 month waiting period
Development

Successfully merging this pull request may close these issues.

[CSS]: Button Alignment Main Page