Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image Optimized & Projects.md updated #262

Merged
merged 3 commits into from
Apr 1, 2020
Merged

Image Optimized & Projects.md updated #262

merged 3 commits into from
Apr 1, 2020

Conversation

Druhin13
Copy link
Contributor

#256 Link Updated (Gnome blog link)

Images Optimized -
28,613.95 kb -> 26,067.84 kb (8.9%)

ImgBotApp and others added 3 commits March 20, 2020 04:41
@ImgBotApp
[ImgBot] Optimize images
9f47544 
*Total -- 28,613.95kb -> 26,067.84kb (8.9%)

/images/opensourcedesign-logo-inverted.svg -- 1.70kb -> 0.49kb (71.39%)
/images/summit/map-marker.svg -- 2.15kb -> 0.71kb (67.18%)
/images/summit/star.svg -- 2.16kb -> 0.72kb (66.8%)
/images/supporters/osi.svg -- 8.65kb -> 3.24kb (62.5%)
/images/promo/poster.png -- 364.43kb -> 147.16kb (59.62%)
/images/nyc_image4.png -- 1,142.66kb -> 681.29kb (40.38%)
/images/summit/phplist-logo.svg -- 5.84kb -> 3.59kb (38.61%)
/images/opensourcedesign-logo-margin.png -- 4.34kb -> 2.72kb (37.37%)
/images/summit/ura-logo.svg -- 2.44kb -> 1.54kb (36.57%)
/images/opensourcedesign-logo-text-inverted.png -- 37.21kb -> 24.37kb (34.49%)
/images/articles/nyc_thaw.png -- 200.99kb -> 132.60kb (34.02%)
/images/nyc_image5.png -- 454.68kb -> 316.23kb (30.45%)
/images/interviews/julia/screencat.png -- 121.49kb -> 88.65kb (27.03%)
/images/events/osd-logo.png -- 6.79kb -> 5.08kb (25.11%)
/images/osd-vs-od.png -- 110.85kb -> 85.24kb (23.1%)
/images/opensourcedesign-logo-text-narrow-inverted.svg -- 12.00kb -> 9.40kb (21.7%)
/images/summit/logo-2017.svg -- 17.28kb -> 13.56kb (21.53%)
/images/opensourcedesign-logo-text-narrow.svg -- 11.17kb -> 8.83kb (20.89%)
/images/summit/logo.svg -- 18.60kb -> 14.85kb (20.14%)
/images/summit/supporters.svg -- 0.88kb -> 0.71kb (19.91%)
/images/opensourcedesign-logo-text-inverted.svg -- 9.88kb -> 8.00kb (18.98%)
/images/summit/oficina.svg -- 4.39kb -> 3.64kb (17.12%)
/images/events/fossasia.svg -- 11.26kb -> 9.34kb (17.01%)
/images/articles/osd_collaboration_tools.png -- 126.60kb -> 105.13kb (16.96%)
/images/summit/schedule.svg -- 1.13kb -> 0.96kb (15.52%)
/images/summit/poster summit.png -- 2,916.98kb -> 2,468.40kb (15.38%)
/images/summit/opentechfund-logo.svg -- 3.89kb -> 3.31kb (14.98%)
/images/opensourcedesign-logo.svg -- 0.43kb -> 0.37kb (13.41%)
/images/cardsorting3.jpg -- 168.76kb -> 146.15kb (13.4%)
/images/articles/nyc_youtube.png -- 142.59kb -> 125.21kb (12.19%)
/images/opensourcedesign-logo-small-inverted.png -- 0.60kb -> 0.54kb (10.82%)
/images/summit/mozilla-logo.svg -- 1.43kb -> 1.29kb (9.72%)
/images/promo/card.svg -- 35.52kb -> 32.42kb (8.72%)
/images/promo/poster.svg -- 32.61kb -> 29.81kb (8.59%)
/images/summit/background.jpg -- 183.75kb -> 169.87kb (7.55%)
/_includes/img/opencollective-logo.svg -- 1.58kb -> 1.46kb (7.37%)
/images/2017-fosdem-picture-original.jpg -- 6,352.75kb -> 5,953.79kb (6.28%)
/images/cardsorting1.jpg -- 226.38kb -> 212.22kb (6.25%)
/images/nycgroup.jpg -- 147.77kb -> 138.82kb (6.06%)
/images/summit/redhat-logo.svg -- 11.78kb -> 11.07kb (6.02%)
/images/summit/background.png -- 149.64kb -> 141.06kb (5.73%)
/images/IMG_20171214_205528.jpg -- 3,570.38kb -> 3,373.87kb (5.5%)
/images/events/osd-group-photo.jpg -- 346.75kb -> 328.09kb (5.38%)
/images/summit/stickermule-logo.svg -- 6.25kb -> 5.91kb (5.33%)
/images/map-marker.png -- 0.94kb -> 0.89kb (5.28%)
/images/events/osd-agenda-sun.jpg -- 154.05kb -> 145.99kb (5.23%)
/images/cardsorting2.jpg -- 225.72kb -> 214.16kb (5.12%)
/images/nyc_image3.jpg -- 302.81kb -> 287.49kb (5.06%)
/images/articles/nyc_IMG_2479.jpg -- 2,577.95kb -> 2,453.88kb (4.81%)
/images/articles/nyc_IMG_2470.jpg -- 2,009.97kb -> 1,923.94kb (4.28%)
/images/events/osd-whiteboard-sun.jpg -- 187.83kb -> 180.09kb (4.12%)
/images/IMG_0298.jpg -- 1,315.37kb -> 1,261.83kb (4.07%)
/images/events/osd-agenda-sat.jpg -- 136.38kb -> 131.00kb (3.95%)
/images/events/osd-events.jpg -- 194.38kb -> 186.90kb (3.85%)
/images/2017-fosdem-picture-compressed-blur30px.jpg -- 140.05kb -> 135.42kb (3.3%)
/images/events/osd-david-tereza.jpg -- 211.77kb -> 204.94kb (3.23%)
/images/articles/dog.png -- 152.08kb -> 147.51kb (3%)
/images/events/osd-sam-workshop.jpg -- 142.90kb -> 138.65kb (2.97%)
/images/supporters/stickermule.svg -- 5.72kb -> 5.59kb (2.2%)
/fonts/glyphicons-halflings-regular.svg -- 106.19kb -> 103.92kb (2.14%)
/images/summit/megaphone.svg -- 0.75kb -> 0.74kb (1.95%)
/images/summit/FOSDEM_18_photo.jpg -- 87.08kb -> 85.67kb (1.62%)
/images/opensourcedesign-logo-text.svg -- 7.33kb -> 7.21kb (1.57%)
/fonts/fontawesome-webfont.svg -- 306.05kb -> 301.86kb (1.37%)
/images/events/2018-opensourcedesign-fosdem.jpg -- 1,962.81kb -> 1,937.77kb (1.28%)
/images/supporters/eff.svg -- 5.94kb -> 5.87kb (1.18%)
/images/events/2018-fosdem-booth.jpg -- 1,015.57kb -> 1,010.21kb (0.53%)
/images/events/fosdem.svg -- 32.09kb -> 31.95kb (0.45%)
/images/opensourcedesign-logo-margin.svg -- 0.48kb -> 0.48kb (0.4%)
/images/events/apachecon.svg -- 40.57kb -> 40.42kb (0.36%)
/_includes/img/opensourcedesign-logo.svg -- 0.33kb -> 0.33kb (0.29%)
/images/supporters/redhat.svg -- 2.37kb -> 2.37kb (0.12%)
/images/supporters/mozilla.svg -- 1.29kb -> 1.29kb (0.08%)
/images/supporters/creativecommons.svg -- 9.46kb -> 9.45kb (0.04%)
/images/supporters/opentechfund.svg -- 2.84kb -> 2.84kb (0.03%)
/images/events/2017-promo.jpg -- 295.47kb -> 295.45kb (0.01%)

Signed-off-by: ImgBotApp <[email protected]>
@Druhin13
Link Update
3370b97 
Link Update - GNOME Design blog
@Druhin13
Merge pull request #1 from Druhin13/imgbot
3a374d2 
Optimized Images
RDIL
RDIL requested changes Mar 20, 2020
View reviewed changes
Copy link
Member

@RDIL RDIL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with the link change, but I think further testing is required for the images locally, just to be sure they still work. I trust imgbot, but at the same time I don't want to break the website, so therefore I'm putting this on hold.

@RDIL RDIL added content Writing and/or design of content needs testing Needs another person other than the author of the issue to test on hold An issue that is on hold for a reason - describe reason in comments labels Mar 20, 2020
@RDIL RDIL self-assigned this Mar 23, 2020
@RDIL
Copy link
Member

RDIL commented Mar 23, 2020 •
edited
Loading

Update:
The images appear to be working fine. Not sure if the changes to the sponsor logos work though, I know a lot of companies have their logos under a you-can-use-it-just-don't-modify-it type license.

/cc @jancborchardt

@RDIL
Copy link
Member

RDIL commented Mar 31, 2020

Yeah, that's going to be my final ruling. If OSD owns the image, you can minify it. Otherwise, please revert the brand logo/asset changes @Druhin13.

@RDIL RDIL added waiting on author Waiting on comment by the author of the issue - 3-6 month waiting period and removed needs testing Needs another person other than the author of the issue to test labels Mar 31, 2020
@jancborchardt
Copy link
Member

@RDIL I’d assume any brand logos are only governed by how it appears visually, not by how it actually is represented in the file, like SVG, PNG, minified or not.

RDIL
RDIL approved these changes Mar 31, 2020
View reviewed changes
Copy link
Member

@RDIL RDIL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay then.

@jancborchardt jancborchardt merged commit fcc5161 into opensourcedesign:master Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RDIL RDIL RDIL approved these changes

@jancborchardt jancborchardt jancborchardt approved these changes

Assignees

@RDIL RDIL

Labels
content Writing and/or design of content on hold An issue that is on hold for a reason - describe reason in comments waiting on author Waiting on comment by the author of the issue - 3-6 month waiting period
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Druhin13 @RDIL @jancborchardt @ImgBotApp