Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Work in progress] Add affiliation part to front page #215

Merged
merged 1 commit into from
Jun 16, 2019
Merged

Conversation

jancborchardt
Copy link
Member

@jancborchardt jancborchardt commented Jan 24, 2019

Added the logos as a starting step for Missing Affiliation page on the website #168 :) (They are already minified via scour.)

@aaqaishtyaq we should put them on the frontpage on the bottom so they are present, but not in the footer so they are not on all pages. Sounds good?

Also we should link the logos to their websites, what do you think @opensourcedesign/website

Signed-off-by: Jan-Christoph Borchardt <[email protected]>
@jancborchardt jancborchardt added enhancement An issue that improves in some way the open source design wesbsite design An issue that needs design before development content Writing and/or design of content labels Jan 24, 2019
@RDIL RDIL self-requested a review January 24, 2019 12:50
@jancborchardt
Copy link
Member Author

And just to specifiy @RDIL cause you added the tag to the issue: This would not be a new page, but on the bottom of the front page.

We should not create new pages, but we are rather about to reduce the pages, as specified in the website discussion at https://discourse.opensourcedesign.net/t/open-source-design-website-review/773 🙂

@RDIL
Copy link
Member

RDIL commented Jan 24, 2019

Ah okay

@jancborchardt
Copy link
Member Author

@AnXh3L0 this is the pull request with the assets. :)

The code for the Open Collective embed seems to be this:

// Not sure if this JS file is needed?
<script src="https://opencollective.com/opensourcedesign/banner.js"></script>

// Sponsors
<object type="image/svg+xml" data="https://opencollective.com/opensourcedesign/tiers/sponsor.svg?avatarHeight=36&width=600"></object>

// Backers
<object type="image/svg+xml" data="https://opencollective.com/opensourcedesign/tiers/backer.svg?avatarHeight=36&width=600"></object>

// One-time sponsor
<object type="image/svg+xml" data="https://opencollective.com/opensourcedesign/tiers/one-time-sponsor.svg?avatarHeight=36&width=600"></object>

@AnXh3L0
Copy link
Member

AnXh3L0 commented Jun 6, 2019

At the moment, I have added two new sections for Supporters and Affiliates, need some ideas/thoughts on how to improve it visually.

image

@evalica
Copy link
Member

evalica commented Jun 6, 2019

We could also separate the OpenCollective backers in a different category. So that would mean 3 categories: Affiliates, Supporters and Backers.

Also I would have the Affiliates at the top, since they are well known, plus fewer than the Backers, that the list could increase.

@jancborchardt
Copy link
Member Author

jancborchardt commented Jun 9, 2019

@AnXh3L0 the only feedback to improve it visually is to increase the whitespace above the Open Collective row a bit, as well as the whitespace above the "Affiliates" text. Then it looks great! :)

@evalica I actually would say the sorting is good:

  • Supporters on top, since they did significant monetary or structural support
  • Backers inside of supporters since it’s also monetary support
  • Affiliates on the bottom since it’s "just" affiliation. I would say the Supporters are actually more well-known than the affiliates we have at the moment.

@elioqoshi
Copy link
Member

Since this is approved, let's go ahead and merge this. We can revisit the sorting in the new website redesign:
#242

@elioqoshi elioqoshi merged commit 3817d89 into master Jun 16, 2019
@AnXh3L0
Copy link
Member

AnXh3L0 commented Jun 16, 2019

@elioqoshi the changes I made weren't in this branch yet, that's why they aren't online.

@elioqoshi
Copy link
Member

Ah okay sorry I was not aware. Ping us when they are

@jancborchardt
Copy link
Member Author

@AnXh3L0 can you do a pull request with your changes then? I can do the additional adjustments too. :)

@jancborchardt jancborchardt deleted the supporters branch June 20, 2019 00:45
@AnXh3L0
Copy link
Member

AnXh3L0 commented Jun 20, 2019

Yes, I can do a PR by the end of this week.

@jancborchardt
Copy link
Member Author

@AnXh3L0 when you do a PR, I just remembered we should also add the Open Source Initiative to the affiliates! :) This would be the page to link to: https://opensource.org/affiliates

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Writing and/or design of content design An issue that needs design before development enhancement An issue that improves in some way the open source design wesbsite
Development

Successfully merging this pull request may close these issues.

6 participants