Memory Spaces #567
Open
Memory Spaces #567
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add shmem_space_malloc and shmem_space_free
…e-agnostic. - Added spaces description to programming model overview. - Added a spaces intro.
…rify default alias vs multiple enabled spaces; legacy allocs are SHMEM_TEAM_WORLD-collective
- Added content/shmem_space_calloc.tex and included in main_spec.tex
- Aligned spaces intro with env vars: SHMEM_<DEVICE>_SYMMETRIC_SIZE, SHMEM_ENABLE_<DEVICE>, SHMEM_DEFAULT_SPACE
- Clarified SHMEM_SPACE_DEFAULT is a single alias; multiple spaces may be enabled concurrently
- Focused teams intro on SHMEM_TEAM_<DEVICE>; moved space details to spaces_intro.tex
- Scoped underscore wrapping to \ENVVAR{} only to fix env-var wrapping
Remove TODO from content/programming_model_overview.tex
michael-beebe
commented
Aug 29, 2025
| define accessibility and operational properties of those objects. Allocations | ||
| within a space are collective and symmetric across the \acp{PE} for which the | ||
| space is available. Collective and communication operations operate on data | ||
| resident in one or more spaces as permitted by the implementation |
michael-beebe
commented
Aug 29, 2025
| \item g or G multiplies by \(2^{30}\) (gibibytes) | ||
| \item t or T multiplies by \(2^{40}\) (tebibytes) | ||
| \end{itemize} | ||
| For example, string \enquote{20m} is equivalent to the integer value |
michael-beebe
commented
Aug 29, 2025
| implementation-defined and must be at least as large as the integer | ||
| ceiling of the product of the numeric prefix and the scaling factor. | ||
| The allowed character suffixes are as in \ENVVAR{SHMEM\_SYMMETRIC\_SIZE}. | ||
| Device tokens are implementation-defined. |
There was a problem hiding this comment.
Need a clear definition for "device tokens".
michael-beebe
commented
Aug 29, 2025
| @@ -0,0 +1,100 @@ | |||
| The \openshmem spaces facility introduces named symmetric heaps associated with | |||
| particular memory domains, referred to as \emph{spaces}. The set of supported | |||
| domains and any associated tokens are implementation-defined. | |||
jdinan
reviewed
Aug 29, 2025
| symmetric data objects in these heaps. | ||
|
|
||
| The symmetric memory allocation routines differ from the private heap | ||
| In addition to the traditional (legacy) symmetric heap used by |
There was a problem hiding this comment.
I don't think we use the term "legacy" elsewhere in the spec, e.g. to refer to operations that use the default context. Unless they are being deprecated, I would suggest that we don't introduce this term.
jdinan
reviewed
Aug 29, 2025
|
|
||
| \subsubsection*{Default Space and Backward Compatibility} | ||
|
|
||
| Implementations may provide a default space that legacy allocation routines use |
There was a problem hiding this comment.
Do we really mean "may" here or do we want a stronger "must" requirement?
jdinan
reviewed
Aug 29, 2025
| Implementations may provide a default space that legacy allocation routines use | ||
| for backward compatibility. Legacy allocation routines are collective | ||
| operations over \LibHandleRef{SHMEM\_TEAM\_WORLD}. When a default space is | ||
| provided, the traditional \FUNC{shmem\_malloc} and \FUNC{shmem\_calloc} |
There was a problem hiding this comment.
Please strike usage of "traditional" and "legacy".
michael-beebe
commented
Aug 29, 2025
| indicate that the handle does not reference a valid memory space. Applications | ||
| can use an equality comparison to test whether a given space handle references | ||
| a valid memory space. See Section~\ref{subsec:library_handles} for predefined | ||
| handles and Section~\ref{sec:memory_management} for allocation interfaces. |
There was a problem hiding this comment.
Double check that memory_management is the correct section.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.