Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update core.yaml #1226

Closed
wants to merge 1 commit into from
Closed

Update core.yaml #1226

wants to merge 1 commit into from

Conversation

jarifibrahim
Copy link
Contributor

About

This description was generated using this script:

#!/bin/bash
set -e
GHORG=${GHORG:-fabric8-services}
GHREPO=${GHREPO:-fabric8-wit}
cat <<EOF
# About
This description was generated using this script:
\`\`\`sh
`cat $0`
\`\`\`
Invoked as:

    `echo GHORG=${GHORG} GHREPO=${GHREPO} $(basename $0) ${@:1}`

# Changes
EOF
git log \
  --pretty="%n**Commit:** https://github.com/${GHORG}/${GHREPO}/commit/%H%n**Author:** %an (%ae)%n**Date:** %aI%n%n%s%n%n%b%n%n----%n" \
  --reverse ${@:1} \
  | sed -E "s/([\s|\(| ])#([0-9]+)/\1${GHORG}\/${GHREPO}#\2/g"

Invoked as:

GHORG=fabric8-services GHREPO=fabric8-wit changes.sh d89ac3376facfd0d94c45c5162d37d6cba445ebb...cf91483b2b36315cc1e2ffbeddb272cdb419ab01

Changes

Commit: fabric8-services/fabric8-wit@9784eee
Author: Konrad Kleine ([email protected])
Date: 2018-12-05T14:27:24+01:00

Also add @fabric8-services/fabric8-wit-team to my ownership (fabric8-services/fabric8-wit#2364)

Commit: fabric8-services/fabric8-wit@6f27f8b
Author: ckrych ([email protected])
Date: 2018-12-06T18:55:22+01:00

Do not run parallel integration test (fabric8-services/fabric8-wit#2368)

Commit: fabric8-services/fabric8-wit@58492e8
Author: Ibrahim Jarif ([email protected])
Date: 2018-12-10T17:15:44+05:30

Add GO_TEST_BINARIES_PARALLEL_FLAG to test-package function (fabric8-services/fabric8-wit#2370)

fixes fabric8-services/fabric8-wit#2368 (comment)

Commit: fabric8-services/fabric8-wit@ce00568
Author: ckrych ([email protected])
Date: 2018-12-10T14:31:24+01:00

API to obfuscate user details in the DB (fabric8-services/fabric8-wit#2358)

This API overwrites the user details with obfuscated strings - to be called using an Auth Service account only.

fixes https://openshift.io/openshiftio/Openshift_io/plan/detail/804

Commit: fabric8-services/fabric8-wit@fe049a7
Author: Dhriti Shikhar ([email protected])
Date: 2018-12-17T16:10:16+05:30

removes update trackerquery action (fabric8-services/fabric8-wit#2381)

Commit: fabric8-services/fabric8-wit@6423598
Author: Ibrahim Jarif ([email protected])
Date: 2018-12-19T09:53:07+05:30

Use golang 1.9.4 from website (fabric8-services/fabric8-wit#2383)

  1. go1.9.4 from website to run tests without coverage and build the binary
  2. go1.11 from epel to run tests with coverage (we need go >= 1.10 because test cache was introduced in go 1.10)

Commit: fabric8-services/fabric8-wit@4cf253e
Author: Ibrahim Jarif ([email protected])
Date: 2018-12-19T10:52:10+05:30

Use go1.9.4 to build the binary (fabric8-services/fabric8-wit#2384)

The cico_build_deploy.sh script did not set the USE_GO_VERSION_FROM_WEBSITE flag and because of that go1.11 was used from epel to build the binary (see build https://ci.centos.org/job/devtools-fabric8-wit-build-master/618/consoleFull) .

Commit: fabric8-services/fabric8-wit@0791099
Author: Ibrahim Jarif ([email protected])
Date: 2018-12-19T15:01:24+05:30

Use only go1.9 for all builds (fabric8-services/fabric8-wit#2385)

Commit: fabric8-services/fabric8-wit@6c2caea
Author: ckrych ([email protected])
Date: 2018-12-19T13:08:25+01:00

Add swagger_ui to macOS doker-compose (fabric8-services/fabric8-wit#2380)

Commit: fabric8-services/fabric8-wit@bfd2c3d
Author: Konrad Kleine ([email protected])
Date: 2018-12-20T10:46:36+01:00

Add "system_remote_item_url" and "system_remote_tracker_id" WIT fields (fabric8-services/fabric8-wit#2366)

  • Add KindRemoteTracker and two new planner item fields
  • Declare KindRemoteTracker as simple type
  • Relabel system_remote_item_url field

Commit: fabric8-services/fabric8-wit@5c95c04
Author: Michael Kleinhenz ([email protected])
Date: 2018-12-20T12:43:11+01:00

Parent-Child Relationships in CSV Export (fabric8-services/fabric8-wit#2372)

This adds A column _Parent and a column _Childs to the CSV export. The columns are added by default and contain the parent number and the child numbers (if any) of the Work Item represented by the corresponding line.

This implements https://openshift.io/openshiftio/Openshift_io/plan/detail/1147

Commit: fabric8-services/fabric8-wit@ac1460f
Author: Dhriti Shikhar ([email protected])
Date: 2018-12-21T14:27:33+05:30

Adds WIT parameter in TrackerQuery payload (fabric8-services/fabric8-wit#2360)

Commit: fabric8-services/fabric8-wit@74531c7
Author: Dhriti Shikhar ([email protected])
Date: 2018-12-28T17:09:56+05:30

Add permissions to trackerqueries (fabric8-services/fabric8-wit#2382)

Commit: fabric8-services/fabric8-wit@f6f1d58
Author: Dhriti Shikhar ([email protected])
Date: 2019-01-03T20:27:00+05:30

adds tests for delete trackerquery on controller level (fabric8-services/fabric8-wit#2388)

Adds missing tests for delete trackerquery on controller level.

Commit: fabric8-services/fabric8-wit@74e6bd8
Author: Dhriti Shikhar ([email protected])
Date: 2019-01-08T13:54:15+05:30

List all TrackerQueries for a space (fabric8-services/fabric8-wit#2387)

Commit: fabric8-services/fabric8-wit@6854cf0
Author: Baiju Muthukadan ([email protected])
Date: 2019-01-14T12:09:54+05:30

Add remote item URL & tracker ID to WI (fabric8-services/fabric8-wit#2389)

Commit: fabric8-services/fabric8-wit@1d94740
Author: Dhriti Shikhar ([email protected])
Date: 2019-01-14T15:22:06+05:30

Test Fixture for Tracker Query (fabric8-services/fabric8-wit#2390)

Commit: fabric8-services/fabric8-wit@b30cc39
Author: Dhriti Shikhar ([email protected])
Date: 2019-01-14T18:53:10+05:30

refactor trackerquery controller level tests (fabric8-services/fabric8-wit#2391)

Commit: fabric8-services/fabric8-wit@04d74e1
Author: Dhriti Shikhar ([email protected])
Date: 2019-01-14T21:27:59+05:30

Enables searching of workitems by trackerquery id (fabric8-services/fabric8-wit#2392)

Commit: fabric8-services/fabric8-wit@8c71948
Author: Dhriti Shikhar ([email protected])
Date: 2019-01-16T11:38:10+05:30

Delete trackerquery (fabric8-services/fabric8-wit#2394)

Commit: fabric8-services/fabric8-wit@a9703fb
Author: ckrych ([email protected])
Date: 2019-01-21T14:28:10+01:00

Add Delete user API by username to be called by the auth service (fabric8-services/fabric8-wit#2386)

  • Add Delete user API by username to be called by admin-console service account

  • delete assocaited space owned by an identities being deleted

  • Add Delete user API by username to be called by admin-console service account

  • delete assocaited space owned by an identities being deleted

  • Delete user ans associated resources should be called from auth service

  • make codacy happy with coding styling

  • Update account/user.go

Co-Authored-By: corinnekrych [email protected]

  • Update account/user.go

Co-Authored-By: corinnekrych [email protected]

  • clean code with review's comments

  • Update account/user.go

Co-Authored-By: corinnekrych [email protected]

  • refactor delete user test in sub-test

  • refactor delete user remove unnecessary tf.Users(1)

  • refactor delete user remove to assert wuth CheckExists

  • Update design/account.go

Co-Authored-By: corinnekrych [email protected]

  • Update space/space.go

Co-Authored-By: corinnekrych [email protected]

  • refactor space test to use nest sub-test

  • refactor migration tests to use gorm.Dialect

  • add test for deleting users with mutiple identities

  • refactor account/user_blackbox_test.go to fail the sub-test instead of entire test

  • refactor controller/users.go to group if statement

  • refactor controller/users.go tests into subtest

  • remove user should keep all data committed on spaces not owned by this user, whereas data in owned spaces are all deleted

  • fix unit test for create wit revision, unknown modifier is allowed

  • refactor

  • refactor

  • refactor

  • PermanetDelete of a space to check for spaceId nil

  • make codacy happy

  • migration test to check modifier_id colunm is not dropped

Commit: fabric8-services/fabric8-wit@e553514
Author: Dhriti Shikhar ([email protected])
Date: 2019-01-21T20:10:44+05:30

Adds Space, WorkItemType, Tracker dependency in TrackerQuery test (fabric8-services/fabric8-wit#2399)

Commit: fabric8-services/fabric8-wit@874db20
Author: Ibrahim Jarif ([email protected])
Date: 2019-01-22T15:22:52+05:30

Fix typo: entires => entries (fabric8-services/fabric8-wit#2398)

Commit: fabric8-services/fabric8-wit@587d0d2
Author: Ibrahim Jarif ([email protected])
Date: 2019-01-22T18:12:15+05:30

Add support for system_* fields along with system.* fields (fabric8-services/fabric8-wit#2341)

Commit: fabric8-services/fabric8-wit@73cd088
Author: Ibrahim Jarif ([email protected])
Date: 2019-01-23T17:30:26+05:30

Revert "Add support for system_* fields along with system.* fields (fabric8-services/fabric8-wit#2341)" (fabric8-services/fabric8-wit#2401)

This reverts commit 587d0d29ce0d13e9c2c0edc3ef1816e8debb121a.

Revert "Add support for system_* fields along with system.* fields (fabric8-services/fabric8-wit#2341)"
This reverts commit 587d0d29ce0d13e9c2c0edc3ef1816e8debb121a.

#2341 was merged but the core-97 deployment was failing. This PR reverts the changes.

A possible reason for the deployment failure could be the huge database migration. The field rename PR updates every row of 3 tables. This is a database intensive operation and would take some amount of time to complete. But since it didn't complete within the timeout, openshift marks the pod as unhealthy and kills it. A new pod would come up and the same cycle would repeat.

Kibana logs - https://logs.dsaas-stg.openshift.com/app/kibana#/discover?_g=(refreshInterval:(display:Off,pause:!f,value:0),time:(from:'2019-01-22T12:50:00.000Z',mode:absolute,to:'2019-01-22T13:20:00.000Z'))&_a=(columns:!(_source),filters:!(),index:'project.dsaas-preview.6e520a9f-d097-11e8-9fb7-121499db9246.*',interval:auto,query:(query_string:(analyze_wildcard:!t,query:'kubernetes.labels.deployment:core-97')),sort:!('@timestamp',desc))

This shows the Kibana logs for the actual pod: kubernetes.pod_name:"core-97-6cjh9" AND kubernetes.namespace_name:"dsaas-preview"

Commit: fabric8-services/fabric8-wit@6eeb10f
Author: Dhriti Shikhar ([email protected])
Date: 2019-01-25T15:40:57+05:30

Adds test for non existing tracker query in search (fabric8-services/fabric8-wit#2400)

Commit: fabric8-services/fabric8-wit@befa5bc
Author: Alexey Kazakov ([email protected])
Date: 2019-02-13T15:00:35-05:00

Proxy /logout/v2 to Auth service (fabric8-services/fabric8-wit#2403)

  • Proxy /logout/v2 to Auth service

  • Update golden files for endpoint/list controller

Commit: fabric8-services/fabric8-wit@f7b1641
Author: Xavier Coulon ([email protected])
Date: 2019-02-20T16:43:26+01:00

Add security constraint in design for user deletion and obfuscation (fabric8-services/fabric8-wit#2405)

Fixes fabric8-services/fabric8-wit#2404

Signed-off-by: Xavier Coulon [email protected]

Commit: fabric8-services/fabric8-wit@cf91483
Author: Ibrahim Jarif ([email protected])
Date: 2019-02-21T09:41:40+05:30

Delete workspaces: Don't rely on links in the list workspaces response (fabric8-services/fabric8-wit#2402)

The response for workspace list returned from che starter does not contain a delete link.
This PR removes the check for the delete link in the response payload.

@centos-ci
Copy link
Collaborator

The E2E smoke test with feature level set to 'beta' failed.

Link URL
job log https://ci.centos.org/job/devtools-saas-openshiftio-e2e-smoketest-beta/586/console
failure message http://artifacts.ci.centos.org/devtools/e2e/devtools-saas-openshiftio-e2e-smoketest-beta/586/failures.txt
artifacts http://artifacts.ci.centos.org/devtools/e2e/devtools-saas-openshiftio-e2e-smoketest-beta/586

Please review the job results and re-run the job by commenting [e2e-test-beta] if necessary.

@kwk
Copy link
Contributor

kwk commented Feb 21, 2019

@jarifibrahim are you sure you want to merge this? It is quite a lot.

@jarifibrahim
Copy link
Contributor Author

@jarifibrahim are you sure you want to merge this? It is quite a lot.

@kwk I'm not very sure. I'll break this PR into two separate PRs. Does this sound good?

@kwk
Copy link
Contributor

kwk commented Feb 21, 2019

@jarifibrahim are you sure you want to merge this? It is quite a lot.

@kwk I'm not very sure. I'll break this PR into two separate PRs. Does this sound good?

@jarifibrahim I would try to make as many as needed in order to get confirmation from the authors of the PRs that it can go in. IMHO to make this clear once and for all, create a PR for each update (except mine of course ;)) and assign it to the author of the PRs. We need to merge more often.

@jarifibrahim
Copy link
Contributor Author

@jarifibrahim are you sure you want to merge this? It is quite a lot.

@kwk I'm not very sure. I'll break this PR into two separate PRs. Does this sound good?

@jarifibrahim I would try to make as many as needed in order to get confirmation from the authors of the PRs that it can go in. IMHO to make this clear once and for all, create a PR for each update (except mine of course ;)) and assign it to the author of the PRs. We need to merge more often.

Sure @kwk. This sounds fine but one PR for each update won't be practical. I'll split this PR into 4 PRs and ask all the authors to approve it. That would speed up the process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add security constraint in design when obfuscating or deleting user account
3 participants
@jarifibrahim @centos-ci @kwk