Che #13915 - New nightly job for 'che-plugin-registry' #1043
Conversation
l0rd
changed the title
l0rd
changed the title
| git_repo: che-plugin-registry | ||
| ci_project: 'devtools' | ||
| ci_cmd: '/bin/bash cico_build_nightly.sh' | ||
| timeout: '10m' |
There was a problem hiding this comment.
Any specific reason why decreasing timeout from 30 to 10 minutes? I can imagine, that docker build&push could in some circumstances take more than that.
There was a problem hiding this comment.
What annoyed me was the inconsistency with the CI build above https://github.com/openshiftio/openshiftio-cico-jobs/pull/1043/files#diff-a0fd432ddaac45438209cf6e0a7298c0R4471.
There was a problem hiding this comment.
But in the meantime we have introduced the patched images build in the nightly script so I guess I understand now why @ibuziuk set 30 min here. I revert this change and will update the build-master job as well (one day we may decide to run the patched images build on the build-master)
l0rd
changed the title
|
@ibuziuk are please have look |
devtools-ci-index.yaml
Outdated
| @@ -2118,7 +2118,7 @@ | |||
| secrets: | |||
| - *quay-eclipse-che-credentials | |||
| triggers: | |||
| - timed: '*/30 * * * *' | |||
| - timed: '59 23 * * *' | |||
There was a problem hiding this comment.
Just wondering why you opt for "At 23:59" ?
Anyway, I believe this change is not needed since #1039 was merged today
| - '{ci_project}-{git_repo}-build-master': | ||
| git_organization: eclipse | ||
| git_repo: che-devfile-registry | ||
| ci_project: 'devtools' | ||
| ci_cmd: '/bin/bash cico_build.sh' | ||
| saas_git: saas-openshiftio | ||
| timeout: '10m' | ||
| timeout: '30m' |
There was a problem hiding this comment.
why it is required to increase the master build timing? AFAIK, as part of it, only registry itself is built which is not time consuming
Signed-off-by: Mario Loriedo <[email protected]>
l0rd
force-pushed
the
plugin-registry-nightly
branch
from
6e4045f to
d2fd7c5
Compare
|
@aditya-konarde @pbergene maybe you could give a hand with merging this one? |
|
@l0rd could you please merge this one ? |
Related to che-plugin-registry PR eclipse-che/che-plugin-registry#184
Related to che issue eclipse-che/che#13915
Need eclipse-che/che-plugin-registry#184 to be merged