Skip to content
This repository has been archived by the owner on Jan 29, 2020. It is now read-only.

rh-che #1455 Adding job for daily builds of OpenShift compatible images with 'arbitrary-users-patch' #1034

Closed
wants to merge 1 commit into from

Conversation

ibuziuk
Copy link
Contributor

@ibuziuk ibuziuk commented Jul 10, 2019

@ibuziuk
Copy link
Contributor Author

ibuziuk commented Jul 10, 2019

@l0rd instead of hooking into the existing https://ci.centos.org/job/devtools-che-devfile-registry-build-master/ I believe it would be better to create a brand-new job that would re-build patched images periodically on a daily basis similar to what we have for https://ci.centos.org/job/devtools-eclipse-che-build-dockerfiles/

- timed: '0 0 * * *'
publishers:
- email:
recipients: [email protected]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure what these recipients are but if it's for build failures notifications you may add more addresses here (e.g. Vitalii, Angel and myself)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch

@l0rd
Copy link
Collaborator

l0rd commented Jul 10, 2019

@ibuziuk that's LGTM. I don't know if you can do it in the same PR but we need to reuse these credentials to:

  • Update the devfile registry ci job to push rhel images to quay.io/openshiftio and centos images to quay.io/eclipse-che (maybe that means to split the job in 2 distinct jobs)
  • Update the devfile registry periodic job (the one you are adding with this PR) so that it does a build of the devfile registry image (centos only) and tag it as nightly

As described in eclipse-che/che#13813

1 similar comment
@l0rd
Copy link
Collaborator

l0rd commented Jul 10, 2019

@ibuziuk that's LGTM. I don't know if you can do it in the same PR but we need to reuse these credentials to:

  • Update the devfile registry ci job to push rhel images to quay.io/openshiftio and centos images to quay.io/eclipse-che (maybe that means to split the job in 2 distinct jobs)
  • Update the devfile registry periodic job (the one you are adding with this PR) so that it does a build of the devfile registry image (centos only) and tag it as nightly

As described in eclipse-che/che#13813

@ibuziuk
Copy link
Contributor Author

ibuziuk commented Jul 11, 2019

@l0rd I will take care of eclipse-che/che#13813 in a separate PR ;-)

…ge runtime images periodically

Signed-off-by: Ilya Buziuk <[email protected]>
@ibuziuk ibuziuk marked this pull request as ready for review July 11, 2019 07:41
@ibuziuk
Copy link
Contributor Author

ibuziuk commented Jul 11, 2019

Closed for now in favour of #1035 - let's verify first that vault credentials are valid before creating periodic jobs

@ibuziuk ibuziuk closed this Jul 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants