Add ocp-operator-deployment unit tests for eco-ci-cd

[RileyFW]

Wires up the ocp_operator_deployment role's operator_group_spec and validation test suites as a presubmit, mirroring the existing container-image-mirror, collect-metrics, and ocp-version-facts step registry patterns.

Summary by CodeRabbit

Adds eco-ci-cd presubmit coverage for the ocp_operator_deployment role.

• Runs functional tests when playbooks/roles/ocp_operator_deployment/ changes.
• Executes the operator_group_spec and validation test suites.
• Registers the CI step with commands, resource requests, documentation, metadata, and ownership.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 2717cbc3-294d-4074-8eab-20351d9ff05b

📥 Commits

Reviewing files that changed from the base of the PR and between cd55f77 and ba8f5a7.

⛔ Files ignored due to path filters (1)

• ci-operator/jobs/openshift-kni/eco-ci-cd/openshift-kni-eco-ci-cd-main-presubmits.yaml is excluded by !ci-operator/jobs/**

📒 Files selected for processing (5)

• ci-operator/config/openshift-kni/eco-ci-cd/openshift-kni-eco-ci-cd-main.yaml
• ci-operator/step-registry/telcov10n/functional/eco-ci-cd/tests/ocp-operator-deployment/OWNERS
• ci-operator/step-registry/telcov10n/functional/eco-ci-cd/tests/ocp-operator-deployment/telcov10n-functional-eco-ci-cd-tests-ocp-operator-deployment-commands.sh
• ci-operator/step-registry/telcov10n/functional/eco-ci-cd/tests/ocp-operator-deployment/telcov10n-functional-eco-ci-cd-tests-ocp-operator-deployment-ref.metadata.json
• ci-operator/step-registry/telcov10n/functional/eco-ci-cd/tests/ocp-operator-deployment/telcov10n-functional-eco-ci-cd-tests-ocp-operator-deployment-ref.yaml

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.

---

Walkthrough

The change adds a CI step for OCP operator deployment functional tests. The step initializes repository metadata, runs operator-group and validation suites, declares ownership and metadata, and triggers when the operator deployment role changes.

Changes

OCP operator deployment testing

Layer / File(s)	Summary
Register and execute the functional test step ci-operator/step-registry/telcov10n/functional/eco-ci-cd/tests/ocp-operator-deployment/*	The step definition, command script, metadata, and ownership link define the test and run both deployment test suites.
Connect the step to CI changes ci-operator/config/openshift-kni/eco-ci-cd/openshift-kni-eco-ci-cd-main.yaml	The configuration triggers the test when playbooks/roles/ocp_operator_deployment/ changes.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: 🔵 Low · up to ba8f5

The PR adds presubmit coverage for operator-deployment tests. It is mergeable with owner awareness after confirming the new test step does not duplicate an existing workflow.

Sequence Diagram(s)

sequenceDiagram
  participant CI as CI operator
  participant Step as OCP operator deployment step
  participant Script as Test command script
  participant Suites as Deployment test suites
  CI->>Step: Start the registered test
  Step->>Script: Run the command script
  Script->>Suites: Execute operator-group and validation tests

Loading

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly identifies the addition of OCP operator deployment tests for eco-ci-cd, which matches the main purpose of the changes.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files. (4 skipped: 4 unsupported.)
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The diff adds CI wiring, a shell runner, metadata, and YAML only; added lines contain no Ginkgo It, Describe, Context, or When calls and no test titles.
Test Structure And Quality	✅ Passed	The PR changes CI YAML, a shell runner, metadata, and OWNERS only; it introduces no Ginkgo It, BeforeEach, AfterEach, Eventually, or Consistently code.
Microshift Test Compatibility	✅ Passed	The commit adds CI wiring and shell commands for Python run_tests.py suites; it adds no Ginkgo It/Describe/Context/When tests, so this compatibility check is inapplicable.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	The commit adds CI wiring, metadata, and a shell runner for existing Python suites; it adds no Ginkgo It/Describe/Context/When e2e test or multi-node assumption.
Topology-Aware Scheduling Compatibility	✅ Passed	The diff adds only CI presubmit wiring, a step reference, and a test runner; it changes no operator/controller deployment or topology-sensitive scheduling constraints.
Ote Binary Stdout Contract	✅ Passed	The PR changes only CI YAML, metadata, and a Bash launcher; no Go/OTE binary or process-level setup code, and no stdout-writing OTE construct is introduced.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	The PR adds CI wiring and a Bash launcher only; the complete diff contains no new Ginkgo tests, IPv4 literals, IP parsing, or external connectivity references.
No-Weak-Crypto	✅ Passed	The PR adds CI wiring and test-launcher code only; the added lines contain no MD5/SHA1/DES/RC4/Blowfish/ECB use, custom crypto, or secret/token comparisons.
Container-Privileges	✅ Passed	The changed CI manifests and test step add no privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, allowPrivilegeEscalation, or root security settings.
No-Sensitive-Data-In-Logs	✅ Passed	The changed runner has no logging, echo, printf, or xtrace statements. The presubmit only references credential mounts and runs the two test scripts.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-merge-bot]

[REHEARSALNOTIFIER]
@RileyFW: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
pull-ci-openshift-kni-eco-ci-cd-main-ocp-operator-deployment-test	openshift-kni/eco-ci-cd	presubmit	Presubmit changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

[RileyFW]

/pj-rehearse auto-ack

[openshift-merge-bot]

@RileyFW: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[RileyFW]

/pj-rehearse auto-ack

[openshift-merge-bot]

@RileyFW: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[openshift-ci]

@RileyFW: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[ccardenosa]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ccardenosa, RileyFW

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• ci-operator/config/openshift-kni/eco-ci-cd/OWNERS [RileyFW,ccardenosa]
• ci-operator/jobs/openshift-kni/eco-ci-cd/OWNERS [RileyFW,ccardenosa]
• ci-operator/step-registry/telcov10n/functional/OWNERS [RileyFW,ccardenosa]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment