Skip to content

upgrade golang to 1.26 - #83830

Open
spolti wants to merge 1 commit into
openshift:mainfrom
spolti:rest-proxy
Open

upgrade golang to 1.26#83830
spolti wants to merge 1 commit into
openshift:mainfrom
spolti:rest-proxy

Conversation

@spolti

@spolti spolti commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Updates the OpenDataHub rest-proxy stable 2.x CI build configuration to use Go 1.26.
  • Keeps the existing RHEL 8 and OpenShift 4.23 build base unchanged.

Signed-off-by: Spolti <fspolti@redhat.com>
@coderabbitai

coderabbitai Bot commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 80e887ab-3665-4ba6-b4e8-24a6fea475a9

📥 Commits

Reviewing files that changed from the base of the PR and between 56c76a6 and e2ed361.

📒 Files selected for processing (1)
  • ci-operator/config/opendatahub-io/rest-proxy/opendatahub-io-rest-proxy-stable-2.x.yaml

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.


Walkthrough

The REST proxy stable 2.x build configuration now uses the Go 1.26 build root image with the existing RHEL 8 and OpenShift 4.23 base.

Changes

REST Proxy Build Configuration

Layer / File(s) Summary
Update the build root image
ci-operator/config/opendatahub-io/rest-proxy/opendatahub-io-rest-proxy-stable-2.x.yaml
The build configuration changes the image tag from Go 1.25 to Go 1.26. RHEL 8 and OpenShift 4.23 remain unchanged.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to e2ed3

The PR makes a localized CI configuration image-tag update. It is merge-ready after the routine make update check confirms no unexpected generated changes; no actionable merge-blocking risk is currently identified.

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: upgrading the Go version from 1.25 to 1.26.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The pull request changes only a YAML build-root tag from Go 1.25 to 1.26. It adds no Ginkgo test title or dynamic test-name content.
Test Structure And Quality ✅ Passed The diff changes only one YAML build-root tag from Go 1.25 to 1.26; it introduces no Ginkgo tests, cluster operations, waits, or assertions for this check to assess.
Microshift Test Compatibility ✅ Passed The pull request changes only a YAML build-root Go image tag; it adds no Ginkgo tests or test references to unsupported MicroShift APIs or features.
Single Node Openshift (Sno) Test Compatibility ✅ Passed The HEAD^..HEAD diff changes only one YAML build-root tag from Go 1.25 to 1.26; it adds no Ginkgo e2e tests or multi-node assumptions.
Topology-Aware Scheduling Compatibility ✅ Passed The only PR change updates a CI build_root image tag from Go 1.25 to Go 1.26; it adds no deployment, replica, affinity, node, topology, or disruption scheduling constraint.
Ote Binary Stdout Contract ✅ Passed The patch changes only one YAML build-root tag from Go 1.25 to 1.26; it adds no process-level code or stdout writes.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The commit changes only one CI YAML image-stream tag and adds no Ginkgo e2e tests, IPv4 assumptions, or external connectivity requirements.
No-Weak-Crypto ✅ Passed The only change is the build-root tag from Go 1.25 to Go 1.26; the patch adds no MD5, SHA1, DES, RC4, Blowfish, ECB, or crypto implementation.
Container-Privileges ✅ Passed The PR diff changes only the Go build-root image tag. The changed CI YAML contains no privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, root, or allowPrivilegeEscalation settings.
No-Sensitive-Data-In-Logs ✅ Passed The only change is the build image tag from Go 1.25 to Go 1.26; the diff adds no logging or sensitive-data output.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 21, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@spolti: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-opendatahub-io-rest-proxy-stable-2.x-images opendatahub-io/rest-proxy presubmit Ci-operator config changed
pull-ci-opendatahub-io-rest-proxy-stable-2.x-pr-image-mirror opendatahub-io/rest-proxy presubmit Ci-operator config changed
pull-ci-opendatahub-io-rest-proxy-stable-2.x-unit opendatahub-io/rest-proxy presubmit Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@spolti

spolti commented Aug 21, 2026

Copy link
Copy Markdown
Contributor Author

/pj-rehearse

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@spolti: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci

openshift-ci Bot commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

@spolti: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@brettmthompson brettmthompson left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 21, 2026
@openshift-ci

openshift-ci Bot commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brettmthompson, spolti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants