Skip to content

setup assisted-installer version v2.55 - #83826

Open
danmanor wants to merge 1 commit into
openshift:mainfrom
danmanor:assisted-installer/setup-version-v2.55-1ac7af87-3d7e-4b28-9670-96bf05cbf973
Open

setup assisted-installer version v2.55#83826
danmanor wants to merge 1 commit into
openshift:mainfrom
danmanor:assisted-installer/setup-version-v2.55-1ac7af87-3d7e-4b28-9670-96bf05cbf973

Conversation

@danmanor

@danmanor danmanor commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

The PR updates the Assisted Installer v2.55 CI configurations.

  • It sets always_run: false for selected subsystem-test and e2e-metal-assisted jobs.
  • It replaces skip_if_only_changed with pipeline_skip_if_only_changed for pipeline-level change filtering.
  • The changes affect both the Assisted Installer Agent and Assisted Installer component repositories.

@coderabbitai

coderabbitai Bot commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 8d7a11f8-18cc-4feb-a928-2b7dd30ce4b0

📥 Commits

Reviewing files that changed from the base of the PR and between 2b7cd0a and 51e48a8.

⛔ Files ignored due to path filters (2)
  • ci-operator/jobs/openshift/assisted-installer-agent/openshift-assisted-installer-agent-v2.55-presubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/assisted-installer/openshift-assisted-installer-v2.55-presubmits.yaml is excluded by !ci-operator/jobs/**
📒 Files selected for processing (2)
  • ci-operator/config/openshift/assisted-installer-agent/openshift-assisted-installer-agent-v2.55.yaml
  • ci-operator/config/openshift/assisted-installer/openshift-assisted-installer-v2.55.yaml

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.


Walkthrough

The v2.55 assisted installer configurations now set affected tests to always_run: false and use pipeline_skip_if_only_changed for pipeline-level filtering.

Changes

Assisted installer pipeline filtering

Layer / File(s) Summary
Pipeline filter configuration
ci-operator/config/openshift/assisted-installer-agent/..., ci-operator/config/openshift/assisted-installer/...
The test definitions explicitly set always_run: false and replace skip_if_only_changed with pipeline_skip_if_only_changed.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 51e48

This PR updates assisted-installer v2.55 CI definitions and presubmit jobs. No actionable merge-blocking risk remains beyond normal generated-configuration and presubmit validation.

Possibly related PRs

Suggested labels: approved

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the assisted-installer version setup addressed by the changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.)
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The commit changes CI YAML filtering and generated job annotations only; it adds no Ginkgo test titles or dynamic values to test names.
Test Structure And Quality ✅ Passed The commit changes only CI YAML declarations and generated presubmit annotations; it adds no Ginkgo test code or It/Eventually/BeforeEach/AfterEach changes.
Microshift Test Compatibility ✅ Passed The diff changes only CI YAML configuration and presubmit job files; it adds no Ginkgo tests or MicroShift-incompatible API usage.
Single Node Openshift (Sno) Test Compatibility ✅ Passed The PR changes only CI configuration and generated presubmit YAML; the exact diff adds no Ginkgo tests or multi-node test behavior to assess.
Topology-Aware Scheduling Compatibility ✅ Passed The PR changes only CI operator test-filtering YAML and generated Prow annotations; the diff adds no deployment manifests, operator/controller code, or scheduling constraints.
Ote Binary Stdout Contract ✅ Passed The PR changes only four YAML CI configuration files; the diff adds scheduling/filtering fields and removes skip fields, with no process-level code or stdout writes.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The diff changes only four YAML CI configuration/job files; it adds no Ginkgo test source, IPv4 literals, or external connectivity behavior.
No-Weak-Crypto ✅ Passed The commit only changes CI filtering fields and generated job annotations; its added lines contain no MD5, SHA1, DES, RC4, Blowfish, ECB, crypto, or comparison logic.
Container-Privileges ✅ Passed The commit changes only test filtering and presubmit annotations; the added lines contain no privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, or allowPrivilegeEscalation settings.
No-Sensitive-Data-In-Logs ✅ Passed The commit changes only YAML test scheduling and generated annotations; the added-line scan found no logging or sensitive-data fields, and existing token mounts are unchanged.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci

openshift-ci Bot commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danmanor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 21, 2026
@openshift-ci
openshift-ci Bot requested review from danielerez and gamli75 August 21, 2026 15:43
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@danmanor: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-assisted-installer-agent-v2.55-e2e-metal-assisted openshift/assisted-installer-agent presubmit Ci-operator config changed
pull-ci-openshift-assisted-installer-agent-v2.55-subsystem-test openshift/assisted-installer-agent presubmit Ci-operator config changed
pull-ci-openshift-assisted-installer-v2.55-e2e-metal-assisted openshift/assisted-installer presubmit Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci

openshift-ci Bot commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

@danmanor: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants