Skip to content

cri-o/cri-o: make e2e-aws-ovn and e2e-gcp-ovn optional - #83823

Open
bitoku wants to merge 1 commit into
openshift:mainfrom
bitoku:cri-o-e2e-optional
Open

cri-o/cri-o: make e2e-aws-ovn and e2e-gcp-ovn optional#83823
bitoku wants to merge 1 commit into
openshift:mainfrom
bitoku:cri-o-e2e-optional

Conversation

@bitoku

@bitoku bitoku commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

cri-o/cri-o e2e-{aws,gcp}-ovn Failure Report (past 30 days)

Failure rates

Job Runs Passed Failed Aborted Failure Rate
e2e-aws-ovn 183 61 80 42 43.7%
e2e-gcp-ovn 191 51 95 45 49.7%

Retest impact (e2e-aws-ovn)

  • 184 total runs across 55 PRs — 70% were retests
  • Only 19/55 PRs (35%) passed on the first attempt
  • Worst case: a single PR required 13 runs to get a green result

Override usage

  • /override e2e-aws-ovn used in 7 PRs (4.9% of 142 PRs)
  • /override e2e-gcp-ovn used in 9 PRs (6.3% of 142 PRs)

Recommendation

Mark both jobs optional: true. Nearly half of all runs fail, most PRs require multiple retests, and we are already overriding these gates regularly.

Assisted-by: Claude Code https://claude.com/claude-code

Summary by CodeRabbit

The cri-o/cri-o CI configuration now marks the e2e-aws-ovn and e2e-gcp-ovn jobs as optional. Their failures will no longer block pull requests.

@coderabbitai

coderabbitai Bot commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 45c82a2f-4995-4ed5-9558-0fa1cf289ceb

📥 Commits

Reviewing files that changed from the base of the PR and between ebe19bb and 96de5d0.

⛔ Files ignored due to path filters (1)
  • ci-operator/jobs/cri-o/cri-o/cri-o-cri-o-main-presubmits.yaml is excluded by !ci-operator/jobs/**
📒 Files selected for processing (1)
  • ci-operator/config/cri-o/cri-o/cri-o-cri-o-main.yaml

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.


Walkthrough

The CI configuration marks the AWS and GCP OVN end-to-end tests as optional. Their skip conditions and execution workflows remain unchanged.

Changes

OVN test configuration

Layer / File(s) Summary
Mark OVN tests optional
ci-operator/config/cri-o/cri-o/cri-o-cri-o-main.yaml
The e2e-aws-ovn and e2e-gcp-ovn tests are now optional. Their skip conditions and execution workflows remain unchanged.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 96de5

The PR makes the two OVN presubmit jobs optional. Regenerating CI outputs before merge is a routine validation step, and no actionable merge-blocking risk remains.

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely identifies the two jobs made optional, matching the main change.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The diff only adds optional: true to two CI job definitions and their generated presubmits; it changes no Ginkgo test titles or dynamic test-name values.
Test Structure And Quality ✅ Passed The PR changes only YAML job configuration and generated presubmit entries; no Ginkgo test code or It blocks changed, so the listed test-quality checks are not applicable.
Microshift Test Compatibility ✅ Passed The diff only marks two CI jobs optional in YAML; it adds no Ginkgo tests or references to MicroShift-incompatible APIs or features.
Single Node Openshift (Sno) Test Compatibility ✅ Passed The pull request changes only CI YAML and generated presubmit configuration; it adds no Ginkgo e2e tests or multi-node assumptions requiring SNO review.
Topology-Aware Scheduling Compatibility ✅ Passed The diff only adds optional: true to two CI tests and generated Prow jobs; it adds no deployment, controller, or topology-related scheduling constraints.
Ote Binary Stdout Contract ✅ Passed The patch changes only two YAML files to mark e2e-aws-ovn and e2e-gcp-ovn optional; it changes no process-level OTE source or stdout behavior.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The commit adds only optional CI settings in two YAML files; it adds no Ginkgo test declarations or test code, so this compatibility check is not applicable.
No-Weak-Crypto ✅ Passed The HEAD^..HEAD diff adds only optional: true for two CI jobs and generated entries; no MD5, SHA1, DES, RC4, Blowfish, ECB, custom crypto, or secret comparisons were added.
Container-Privileges ✅ Passed The PR adds only optional: true to two test definitions and generated jobs; it adds no privileged, host namespace, SYS_ADMIN, root, or allowPrivilegeEscalation settings.
No-Sensitive-Data-In-Logs ✅ Passed The PR only adds optional: true to two test declarations and generated Prow jobs; it adds no logging or sensitive-data output.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci
openshift-ci Bot requested review from QiWang19 and littlejawa August 21, 2026 14:59
@openshift-ci

openshift-ci Bot commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bitoku

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 21, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@bitoku: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-cri-o-cri-o-main-e2e-aws-ovn cri-o/cri-o presubmit Ci-operator config changed
pull-ci-cri-o-cri-o-main-e2e-gcp-ovn cri-o/cri-o presubmit Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci

openshift-ci Bot commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

@bitoku: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant