SPLAT-2899: Fixed config for vSphere zones MCO bootimages presubmit

[vr4manta]

SPLAT-2899

Changes

• Configured pool count to 3 for the vSphere zones MCO bootimages presubmit due to parent workflow defaulting to 4 pools for max of 3 vcenters

Notes

Zonal jobs are going to replace multi vCenter jobs since each zonal job may be multi vCenter due to pool configs. This also may change when vSphere moves from IBM cloud to AWS.

Summary by CodeRabbit

The OpenShift CI configurations for the Machine Config Operator now set POOL_COUNT to "3" for the e2e-vsphere-zones-mco-bootimages test across the main and release 4.23–5.2 branches. This matches the maximum of three supported vCenters.

[openshift-ci-robot]

@vr4manta: This pull request references SPLAT-2899 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "5.1.0" version, but no target version was set.

Details

In response to this:

SPLAT-2899

Changes

• Configured pool count to 3 for the vSphere zones MCO bootimages presubmit due to parent workflow defaulting to 4 pools for max of 3 vcenters

Notes

Zonal jobs are going to replace multi vCenter jobs since each zonal job may be multi vCenter due to pool configs. This also may change when vSphere moves from IBM cloud to AWS.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[vr4manta]

/pj-rehearse pull-ci-openshift-machine-config-operator-main-e2e-vsphere-zones-mco-bootimages

[openshift-merge-bot]

@vr4manta: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 4f541868-f0c6-41c8-a090-e25c1b3763cc

📥 Commits

Reviewing files that changed from the base of the PR and between 14c7874 and 872a3da.

📒 Files selected for processing (5)

• ci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-main.yaml
• ci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-release-4.23.yaml
• ci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-release-5.0.yaml
• ci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-release-5.1.yaml
• ci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-release-5.2.yaml

🚧 Files skipped from review as they are similar to previous changes (4)

• ci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-release-5.1.yaml
• ci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-release-5.0.yaml
• ci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-release-4.23.yaml
• ci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-main.yaml

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.

---

Walkthrough

The vSphere zones MCO bootimages test now sets POOL_COUNT to "3" in the main configuration and release configurations 4.23 through 5.2.

Changes

MCO test configuration

Layer / File(s)	Summary
Set vSphere test pool counts ci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-*.yaml	Sets POOL_COUNT to "3" for the vSphere zones MCO bootimages test across five configurations.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to 872a3

This PR makes a localized CI pool-count configuration adjustment across five release configurations. No actionable merge-blocking risk remains; merge is appropriate after the routine generated-configuration update check.

Suggested reviewers: cheesesashimi, dkhater-redhat, deepsm007

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly identifies the issue and the vSphere zones MCO bootimages presubmit configuration change.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (5 skipped: 5 unsupported.)
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The commit changes only five YAML environments by adding static POOL_COUNT: "3"; it changes no Ginkgo It, Describe, Context, or When test titles.
Test Structure And Quality	✅ Passed	The commit adds only POOL_COUNT to five CI YAML files; it changes no Ginkgo test code, setup, cleanup, waits, or assertions.
Microshift Test Compatibility	✅ Passed	The commit changes only five CI YAML files by adding POOL_COUNT; it adds no Ginkgo tests and introduces no MicroShift-incompatible API or feature reference.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	The PR changes only five CI YAML files by adding POOL_COUNT; the diff adds no Ginkgo test or test source, so the SNO multi-node check is not applicable.
Topology-Aware Scheduling Compatibility	✅ Passed	The diff only adds POOL_COUNT: "3" to five ci-operator test environment blocks; it changes no deployment manifest, operator, controller, or scheduling constraint.
Ote Binary Stdout Contract	✅ Passed	The HEAD^→HEAD diff changes only five YAML env blocks; every added line is POOL_COUNT: "3", with no process-level code or stdout write changed.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	The HEAD diff changes only five CI YAML files by adding POOL_COUNT: "3" to an existing test; it adds no Ginkgo test or IPv4/external connectivity behavior.
No-Weak-Crypto	✅ Passed	The HEAD^..HEAD diff contains only five additions of POOL_COUNT: "3" in CI YAML; it introduces no MD5, SHA1, DES, RC4, 3DES, Blowfish, ECB, crypto, or token comparison code.
Container-Privileges	✅ Passed	HEAD changes only add POOL_COUNT: "3" to five CI test env blocks; no privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, root, or allowPrivilegeEscalation settings were introduced.
No-Sensitive-Data-In-Logs	✅ Passed	The diff adds only POOL_COUNT: "3" in five YAML test environments. Existing logging exposes only this numeric count; no passwords, tokens, PII, hostnames, or customer data are added.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

[vr4manta]

/pj-rehearse pull-ci-openshift-machine-config-operator-main-e2e-vsphere-zones-mco-bootimages

[openshift-merge-bot]

@vr4manta: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[jcpowermac]

/lgtm

[coderabbitai]

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

[openshift-merge-bot]

[REHEARSALNOTIFIER]
@vr4manta: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
pull-ci-openshift-machine-config-operator-release-5.0-e2e-vsphere-zones-mco-bootimages	openshift/machine-config-operator	presubmit	Ci-operator config changed
pull-ci-openshift-machine-config-operator-main-e2e-vsphere-zones-mco-bootimages	openshift/machine-config-operator	presubmit	Ci-operator config changed
pull-ci-openshift-machine-config-operator-release-5.1-e2e-vsphere-zones-mco-bootimages	openshift/machine-config-operator	presubmit	Ci-operator config changed
pull-ci-openshift-machine-config-operator-release-4.23-e2e-vsphere-zones-mco-bootimages	openshift/machine-config-operator	presubmit	Ci-operator config changed
pull-ci-openshift-machine-config-operator-release-5.2-e2e-vsphere-zones-mco-bootimages	openshift/machine-config-operator	presubmit	Ci-operator config changed

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

[djoshy]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: djoshy, jcpowermac, vr4manta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• ci-operator/config/openshift/machine-config-operator/OWNERS [djoshy]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[vr4manta]

/pj-rehearse pull-ci-openshift-machine-config-operator-main-e2e-vsphere-zones-mco-bootimages

[openshift-merge-bot]

@vr4manta: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[openshift-ci]

@vr4manta: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.