OCPEDGE-2933: feat: add MAC-keyed FC TNF IPI install weekly lanes

[fracappa]

MAC-based fencing credentials has been recently introduced in Openshift.

This PR introduces a CI lane to validate this new installation method in the IPI path.

This PR depends on: openshift-metal3/dev-scripts#1916

Summary by CodeRabbit

Adds weekly OpenShift CI lanes for two-node fencing with MAC-based credentials.

• Adds the baremetalds-two-node-fencing-mac workflow for TNF IPI installations.
• Configures fencing credentials with FENCING_CREDENTIAL_IDENTIFIER=macAddress.
• Enables weekly nightly-5.0 and nightly-5.1 periodic jobs on the Equinix edge-enablement profile.
• Adds ownership and workflow metadata for the new CI path.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 8f4dbc90-3ced-47a5-b149-efef81fa6493

📥 Commits

Reviewing files that changed from the base of the PR and between 03e96ee and 4365dc1.

⛔ Files ignored due to path filters (1)

• ci-operator/jobs/openshift/release/openshift-release-main-periodics.yaml is excluded by !ci-operator/jobs/**

📒 Files selected for processing (5)

• ci-operator/config/openshift/release/openshift-release-main__nightly-5.0.yaml
• ci-operator/config/openshift/release/openshift-release-main__nightly-5.1.yaml
• ci-operator/step-registry/baremetalds/two-node/fencing/mac/OWNERS
• ci-operator/step-registry/baremetalds/two-node/fencing/mac/baremetalds-two-node-fencing-mac-workflow.metadata.json
• ci-operator/step-registry/baremetalds/two-node/fencing/mac/baremetalds-two-node-fencing-mac-workflow.yaml

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.

---

Walkthrough

The change adds a MAC-address-based two-node fencing workflow and schedules it as a 168-hour periodic test in the nightly 5.0 and 5.1 release configurations.

Changes

Two-node fencing MAC test

Layer / File(s)	Summary
Workflow definition and ownership ci-operator/step-registry/baremetalds/two-node/fencing/mac/*	Adds the baremetalds-two-node-fencing-mac workflow with OpenShift Edge ownership, Equinix edge-enablement infrastructure, two masters, no workers, Redfish BMC support, and MAC-based fencing credentials.
Nightly release scheduling ci-operator/config/openshift/release/openshift-release-main__nightly-5.0.yaml, ci-operator/config/openshift/release/openshift-release-main__nightly-5.1.yaml	Adds the e2e-metal-ovn-two-node-fencing-mac periodic test with the intranet capability and a 168-hour interval.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 4365d

This PR adds weekly CI lanes for MAC-keyed fencing installation. No actionable merge-blocking risk remains beyond completing the repository’s normal workflow and generated-output checks.

Sequence Diagram(s)

sequenceDiagram
  participant PeriodicTestJob
  participant FencingWorkflow
  participant PreSteps
  participant IpiTest
  participant PostSteps
  PeriodicTestJob->>FencingWorkflow: starts baremetalds-two-node-fencing-mac
  FencingWorkflow->>PreSteps: runs baremetalds-ofcir-pre
  FencingWorkflow->>IpiTest: runs baremetalds-ipi-test
  FencingWorkflow->>PostSteps: runs baremetalds-ofcir-post

Loading

Suggested reviewers: dustman9000, vr4manta

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (5 skipped: 5 unsupported.)
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The PR changes only YAML, JSON, and OWNERS files; searches found no added Ginkgo It, Describe, Context, or When titles or dynamic test-title expressions.
Test Structure And Quality	✅ Passed	The diff adds only YAML/JSON/OWNERS and generated Prow configuration. The workflow composes unchanged chains and adds no Ginkgo It, Expect, Eventually, or cleanup code.
Microshift Test Compatibility	✅ Passed	The pull request adds CI workflow and job configuration only; the commit diff adds no Ginkgo It, Describe, Context, or When test.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	The diff adds only CI YAML/JSON metadata and a workflow; it adds no Go files or Ginkgo declarations, so this SNO test-compatibility check is not applicable.
Topology-Aware Scheduling Compatibility	✅ Passed	The diff adds only ci-operator release, periodic-job, and workflow metadata; it adds no deployment, operator, controller, or topology scheduling constraint.
Ote Binary Stdout Contract	✅ Passed	The diff adds only YAML, JSON, OWNERS, and generated Prow configuration; it adds no OTE source or process-level stdout writes.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	The diff adds CI YAML and workflow metadata only; it adds no Ginkgo tests, hardcoded addresses, or external URL/connectivity operations.
No-Weak-Crypto	✅ Passed	The commit adds only CI YAML/JSON wiring; an added-line scan found no MD5, SHA1, DES, RC4, 3DES, Blowfish, ECB, crypto implementation, or secret comparison.
Container-Privileges	✅ Passed	Diff inspection shows the new workflow and generated Prow pods add no privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, root, or allowPrivilegeEscalation settings.
No-Sensitive-Data-In-Logs	✅ Passed	The diff adds a workflow and generated jobs only; its sole new setting is non-secret FENCING_CREDENTIAL_IDENTIFIER=macAddress, with no added log/print commands or credential values.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly describes the added weekly MAC-keyed fencing TNF IPI installation lanes.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: fracappa
Once this PR has been reviewed and has the lgtm label, please assign xueqzhan for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• ci-operator/config/openshift/release/OWNERS
• ci-operator/jobs/openshift/release/OWNERS
• ci-operator/step-registry/baremetalds/two-node/fencing/OWNERS [fracappa]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-merge-bot]

[REHEARSALNOTIFIER]
@fracappa: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
periodic-ci-openshift-release-main-nightly-5.1-e2e-metal-ovn-two-node-fencing-mac	N/A	periodic	Periodic changed
periodic-ci-openshift-release-main-nightly-5.0-e2e-metal-ovn-two-node-fencing-mac	N/A	periodic	Periodic changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

[openshift-ci]

@fracappa: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-ci-robot]

@fracappa: This pull request references OCPEDGE-2933 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target either version "5.1.0." or "openshift-5.1.0.", but it targets "openshift-5.0" instead.

Details

In response to this:

MAC-based fencing credentials has been recently introduced in Openshift.

This PR introduces a CI lane to validate this new installation method in the IPI path.

This PR depends on: openshift-metal3/dev-scripts#1916

Summary by CodeRabbit

Adds weekly OpenShift CI lanes for two-node fencing with MAC-based credentials.

• Adds the baremetalds-two-node-fencing-mac workflow for TNF IPI installations.
• Configures fencing credentials with FENCING_CREDENTIAL_IDENTIFIER=macAddress.
• Enables weekly nightly-5.0 and nightly-5.1 periodic jobs on the Equinix edge-enablement profile.
• Adds ownership and workflow metadata for the new CI path.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[fracappa]

/jira refresh

[openshift-ci-robot]

@fracappa: This pull request references OCPEDGE-2933 which is a valid jira issue.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.