Skip to content

NO-ISSUE: Added periodic job for longrunning testsuite for 4.19 - #82541

Draft
Chandan9112 wants to merge 1 commit into
openshift:mainfrom
Chandan9112:add-disruptive-longrunning-job-4.19
Draft

NO-ISSUE: Added periodic job for longrunning testsuite for 4.19#82541
Chandan9112 wants to merge 1 commit into
openshift:mainfrom
Chandan9112:add-disruptive-longrunning-job-4.19

Conversation

@Chandan9112

@Chandan9112 Chandan9112 commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Cherry-pick of #80958 (nightly-4.20) for nightly-4.19

What

Add the e2e-aws-disruptive-longrunning periodic payload job to the nightly-4.19 CI configuration, enabling long-running disruptive tests to run on 4.19 nightly builds.

Why

The disruptive-longrunning payload job exists for 4.21 and 4.20 but is missing in 4.19. Adding it allows payload testing of long-running disruptive tests (node reboots, MCP rollouts, cluster-wide configuration changes) on 4.19 nightlies.

Changes

  • ci-operator/config/openshift/release/openshift-release-main__nightly-4.19.yaml: Added e2e-aws-disruptive-longrunning periodic job with:
    • Daily schedule (cron: 0 12 * * *)
    • AWS cluster profile (openshift-org-aws)
    • SSH enabled (TEST_REQUIRES_SSH: yes)
    • Suite: openshift/disruptive-longrunning
    • Workflow: openshift-e2e-aws-disruption
    • Resource watch observer enabled

Related PRs

Release Origin PR (suite) Release PR (job)
4.21 #30976 #77488
4.20 #31334 #80958
4.19 #31438 This PR

Note

The corresponding suite definition PR in openshift/origin is #31438 (OCPBUGS-100045). The origin PR must be merged first so the openshift-tests binary recognizes the openshift/disruptive-longrunning suite.

Summary by CodeRabbit

Adds a new daily end-to-end AWS disruptive long-running test job (e2e-aws-disruptive-longrunning) to the OpenShift 4.19 nightly CI configuration. The job runs the openshift/disruptive-longrunning suite with SSH enabled and resource-watch observation (observers-resource-watch) on the AWS cluster profile, using the openshift-e2e-aws-disruption workflow on a 12:00 UTC cron schedule.

The corresponding openshift/origin suite definition PR must merge first so the openshift-tests binary recognizes the suite.

@openshift-ci
openshift-ci Bot requested a review from rphillips July 28, 2026 12:14
@openshift-ci

openshift-ci Bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 28, 2026
@coderabbitai

coderabbitai Bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 59b53c55-24d4-4f58-89e3-65e3a76a238c

📥 Commits

Reviewing files that changed from the base of the PR and between 7f45a8a and 1311d04.

⛔ Files ignored due to path filters (1)
  • ci-operator/jobs/openshift/release/openshift-release-main-periodics.yaml is excluded by !ci-operator/jobs/**
📒 Files selected for processing (1)
  • ci-operator/config/openshift/release/openshift-release-main__nightly-4.19.yaml
🚧 Files skipped from review as they are similar to previous changes (1)
  • ci-operator/config/openshift/release/openshift-release-main__nightly-4.19.yaml

Walkthrough

Adds a daily e2e-aws-disruptive-longrunning test job to the nightly 4.19 release configuration, using the AWS disruption workflow and required suite environment settings.

Changes

Nightly 4.19 test scheduling

Layer / File(s) Summary
Configure AWS disruptive long-running job
ci-operator/config/openshift/release/openshift-release-main__nightly-4.19.yaml
Adds the daily AWS disruptive long-running test with SSH, suite, observer, cluster profile, and workflow configuration.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

  • openshift/release#82414: Updates cron-based nightly OpenShift CI job entries in the same release configuration area.

Suggested labels: needs-ok-to-test

Suggested reviewers: rphillips

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: adding a periodic longrunning job for 4.19.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed Only static CI job/config strings were added; no Ginkgo It/Describe/Context/When titles or dynamic test names changed.
Test Structure And Quality ✅ Passed No Ginkgo test code changed; the PR only adds a CI job entry in YAML, so the test-structure check is not applicable.
Microshift Test Compatibility ✅ Passed PR only adds a CI job in YAML; no new Ginkgo tests or API-using test code were introduced, so MicroShift compatibility isn’t implicated.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR only adds a periodic CI job entry; no Ginkgo test code changed, and the same disruptive-longrunning job already exists in 4.20/4.21 configs.
Topology-Aware Scheduling Compatibility ✅ Passed Only a CI periodic job was added; no deployment manifests, operators, controllers, or topology-sensitive scheduling constraints changed.
Ote Binary Stdout Contract ✅ Passed Only ci-operator YAML/job generation changed; no Go/test binary code or stdout writers were modified.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PASS: This PR only adds a periodic CI job config; no new Ginkgo tests or networking code was added, so the IPv6/disconnected compatibility check is not applicable.
No-Weak-Crypto ✅ Passed Changed lines only add a CI job YAML entry; no MD5/SHA1/DES/RC4/3DES/Blowfish/ECB, custom crypto, or secret/token comparisons appear.
Container-Privileges ✅ Passed The new job/workflow adds only ci-operator pod specs and test env; no privileged, hostPID/Network/IPC, SYS_ADMIN, or allowPrivilegeEscalation fields are present.
No-Sensitive-Data-In-Logs ✅ Passed Diff only adds CI job YAML; no log statements or literal secrets/PII/API keys were introduced, only secret names/paths.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In
`@ci-operator/config/openshift/release/openshift-release-main__nightly-4.19.yaml`:
- Around line 1797-1808: Regenerate the CI artifacts for the
e2e-aws-disruptive-longrunning job by running make update, or the equivalent
make jobs && make ci-operator-config && make registry-metadata sequence. Verify
the generated openshift-release-main-periodics.yaml includes the 4.19 nightly
entry before committing the updated metadata.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: a3264d16-887a-4741-b94d-0f74b7f62df2

📥 Commits

Reviewing files that changed from the base of the PR and between c300612 and 7f45a8a.

📒 Files selected for processing (1)
  • ci-operator/config/openshift/release/openshift-release-main__nightly-4.19.yaml

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jul 28, 2026
@Chandan9112 Chandan9112 changed the title Add e2e-aws-disruptive-longrunning periodic job for nightly-4.19 NO-ISSUE: Added periodic job for longrunning testsuite for 4.19 Jul 28, 2026
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 28, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@Chandan9112: This pull request explicitly references no jira issue.

Details

In response to this:

Cherry-pick of #80958 (nightly-4.20) for nightly-4.19

What

Add the e2e-aws-disruptive-longrunning periodic payload job to the nightly-4.19 CI configuration, enabling long-running disruptive tests to run on 4.19 nightly builds.

Why

The disruptive-longrunning payload job exists for 4.21 and 4.20 but is missing in 4.19. Adding it allows payload testing of long-running disruptive tests (node reboots, MCP rollouts, cluster-wide configuration changes) on 4.19 nightlies.

Changes

  • ci-operator/config/openshift/release/openshift-release-main__nightly-4.19.yaml: Added e2e-aws-disruptive-longrunning periodic job with:
  • Daily schedule (cron: 0 12 * * *)
  • AWS cluster profile (openshift-org-aws)
  • SSH enabled (TEST_REQUIRES_SSH: yes)
  • Suite: openshift/disruptive-longrunning
  • Workflow: openshift-e2e-aws-disruption
  • Resource watch observer enabled

Related PRs

Release Origin PR (suite) Release PR (job)
4.21 #30976 #77488
4.20 #31334 #80958
4.19 #31438 This PR

Note

The corresponding suite definition PR in openshift/origin is #31438 (OCPBUGS-100045). The origin PR must be merged first so the openshift-tests binary recognizes the openshift/disruptive-longrunning suite.

Summary by CodeRabbit

Adds a daily AWS disruptive-longrunning end-to-end test job to the OpenShift 4.19 nightly CI configuration. The job runs the openshift/disruptive-longrunning suite with SSH and resource-watch observation enabled through the AWS disruption workflow.

The corresponding openshift/origin suite definition must merge first so the openshift-tests binary recognizes the suite.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Co-authored-by: Cursor <cursoragent@cursor.com>
@Chandan9112
Chandan9112 force-pushed the add-disruptive-longrunning-job-4.19 branch from 7f45a8a to 1311d04 Compare July 28, 2026 12:51
@openshift-ci

openshift-ci Bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Chandan9112
Once this PR has been reviewed and has the lgtm label, please assign petr-muller for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot Bot removed the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jul 28, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@Chandan9112: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
periodic-ci-openshift-release-main-nightly-4.19-e2e-aws-disruptive-longrunning N/A periodic Periodic changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants