cnf ran: update schedule job

[kononovn]

Summary by CodeRabbit

This PR updates the scheduling logic for the CNF (Cloud Native Function) network functional tests in the Telco v1 OpenShift test suite. Specifically, it modifies ci-operator/step-registry/telcov10n/functional/cnf-network/schedule-job/telcov10n-functional-cnf-network-schedule-job-commands.sh to expand when these tests are scheduled to run.

The script implements a 14-day event cycle scheduling mechanism. Previously, it only triggered test execution on Fridays when there were 1-6 days remaining until the next event. The change adds Saturday as an additional valid test run day (when 0-5 days remain until the event), extending the test scheduling window in the week before events occur.

This adjustment allows the CNF network functional tests to run on both Friday and Saturday in the days leading up to scheduled events, likely to provide more comprehensive pre-event testing coverage for the Telco v1 scenario validation on OpenShift.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: a7a0dcaf-9150-490d-8943-f0d6d85a0e71

📥 Commits

Reviewing files that changed from the base of the PR and between c7b560b and e7dd5ca.

📒 Files selected for processing (1)

• ci-operator/step-registry/telcov10n/functional/cnf-network/schedule-job/telcov10n-functional-cnf-network-schedule-job-commands.sh

---

Walkthrough

The schedule gating script gains an elif branch for Saturday (dow == 6) that mirrors the existing Friday logic: when offset is within 0..5, the script prints the "run CI" message instead of skipping.

Changes

Saturday Schedule Gate

Layer / File(s)	Summary
Saturday branch in schedule gating logic ci-operator/step-registry/telcov10n/functional/cnf-network/schedule-job/telcov10n-functional-cnf-network-schedule-job-commands.sh	Adds an elif dow == 6 branch with the same offset range check (0..5) and "run CI" echo as the Friday branch, so Saturday is treated as a valid execution day.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'cnf ran: update schedule job' is partially related to the changeset. It mentions updating a schedule job, which aligns with the modification to the schedule gating logic, but uses vague terminology ('ran', 'update') that doesn't clearly convey the specific change of adding Saturday execution support.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The PR modifies only a bash shell script for CI scheduling logic; no Ginkgo test files or test names are present or modified. The custom check is not applicable to this PR.
Test Structure And Quality	✅ Passed	PR modifies bash CI script, not Ginkgo tests. Custom check for Ginkgo test quality is inapplicable to this change.
Microshift Test Compatibility	✅ Passed	This PR adds a CI scheduling shell script, not Ginkgo e2e tests. The MicroShift Test Compatibility check applies only when new Ginkgo tests are added, which is not the case here.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	The PR modifies a CI scheduling shell script, not Ginkgo e2e tests. The check for SNO test compatibility is not applicable since no test code was added.
Topology-Aware Scheduling Compatibility	✅ Passed	File is a CI/CD scheduling script in ci-operator/, not a Kubernetes deployment manifest, operator code, or controller. Contains no pod scheduling constraints, affinity rules, or topology assumptions.
Ote Binary Stdout Contract	✅ Passed	PR modifies a bash CI scheduling script, not an OTE binary. The OTE Binary Stdout Contract check is inapplicable to non-Go test code.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	The PR modifies a bash shell script for CI job scheduling logic, not Ginkgo e2e tests. No test code additions detected.
No-Weak-Crypto	✅ Passed	PR adds shell script with scheduling logic (date calculations, day-of-week checks). No weak crypto (MD5, SHA1, DES, RC4, 3DES, Blowfish, ECB), custom crypto, or non-constant-time secret comparisons...
Container-Privileges	✅ Passed	PR modifies only a shell script with scheduling logic. No container/K8s manifests define privileged: true, hostPID, hostNetwork, hostIPC, SYS_ADMIN, or allowPrivilegeEscalation configurations.
No-Sensitive-Data-In-Logs	✅ Passed	The added logging (lines 49-51) only outputs dates and day counts until events, plus operational status. No passwords, tokens, API keys, PII, session IDs, hostnames, or customer data are logged.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[rdiscala]

/lgtm

[openshift-merge-bot]

[REHEARSALNOTIFIER]
@kononovn: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
periodic-ci-openshift-kni-eco-ci-cd-main-cnf-network-phase1-4.20-cnf-network-functional-tests	N/A	periodic	Registry content changed
periodic-ci-openshift-kni-eco-ci-cd-main-cnf-ran-two-sno-4.18-cnf-ran-ztp-tests	N/A	periodic	Registry content changed
periodic-ci-openshift-kni-eco-ci-cd-main-cnf-network-phase1-5.0-cnf-network-functional-tests	N/A	periodic	Registry content changed
periodic-ci-openshift-kni-eco-ci-cd-main-cnf-network-phase1-4.18-cnf-network-functional-tests	N/A	periodic	Registry content changed
periodic-ci-openshift-kni-eco-ci-cd-main-cnf-ran-two-sno-4.22-cnf-ran-ztp-tests	N/A	periodic	Registry content changed
periodic-ci-openshift-kni-eco-ci-cd-main-cnf-network-4.17-cnf-network-functional-tests	N/A	periodic	Registry content changed
periodic-ci-openshift-kni-eco-ci-cd-main-cnf-network-4.16-cnf-network-functional-tests	N/A	periodic	Registry content changed
periodic-ci-openshift-kni-eco-ci-cd-main-cnf-ran-two-sno-4.16-cnf-ran-ztp-tests	N/A	periodic	Registry content changed
periodic-ci-openshift-kni-eco-ci-cd-main-cnf-ran-two-sno-4.14-cnf-ran-ztp-tests	N/A	periodic	Registry content changed
periodic-ci-openshift-kni-eco-ci-cd-main-cnf-ran-two-sno-4.21-cnf-ran-ztp-tests	N/A	periodic	Registry content changed
periodic-ci-openshift-kni-eco-ci-cd-main-cnf-network-phase1-4.19-cnf-network-functional-tests	N/A	periodic	Registry content changed
periodic-ci-openshift-kni-eco-ci-cd-main-cnf-ran-two-sno-4.20-cnf-ran-ztp-tests	N/A	periodic	Registry content changed
periodic-ci-openshift-kni-eco-ci-cd-main-cnf-network-phase1-4.21-cnf-network-functional-tests	N/A	periodic	Registry content changed
periodic-ci-openshift-kni-eco-ci-cd-main-cnf-network-4.14-cnf-network-functional-tests	N/A	periodic	Registry content changed
periodic-ci-openshift-kni-eco-ci-cd-main-cnf-network-4.15-cnf-network-functional-tests	N/A	periodic	Registry content changed
periodic-ci-openshift-kni-eco-ci-cd-main-cnf-network-phase1-4.22-cnf-network-functional-tests	N/A	periodic	Registry content changed
periodic-ci-openshift-kni-eco-ci-cd-main-cnf-network-phase1-4.23-cnf-network-functional-tests	N/A	periodic	Registry content changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kononovn, rdiscala

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• ci-operator/step-registry/telcov10n/functional/cnf-network/schedule-job/OWNERS [kononovn,rdiscala]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@kononovn: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[kononovn]

/pj-rehearse ack

[openshift-merge-bot]

@kononovn: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.