Skip to content

Sync Serverless CI config/#80525

Open
serverless-qe wants to merge 1 commit into
openshift:mainfrom
serverless-qe:sync-serverless-ci
Open

Sync Serverless CI config/#80525
serverless-qe wants to merge 1 commit into
openshift:mainfrom
serverless-qe:sync-serverless-ci

Conversation

@serverless-qe

@serverless-qe serverless-qe commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

This PR updates the CI configuration for the OpenShift Knative Eventing Kafka Broker component to use newer base images in its build pipeline.

Specifically, three CI configuration files are modified to replace the golang builder base image selection:

  • Old: rhel-9-release-golang-1.23-openshift-4.19
  • New: rhel-9-release-golang-1.25-openshift-4.21

The changes propagate this new base image reference across all image build definitions in each configuration file, ensuring that the Kafka Broker and its related test containers (event display, heartbeats, controllers, webhook, consumer utilities, etc.) are built with the updated Go 1.25 and OpenShift 4.21 runtime versions.

This is a straightforward CI infrastructure synchronization that aligns the Serverless component's build pipeline with newer toolchain versions.

@coderabbitai

coderabbitai Bot commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 3af83610-46bf-443e-9634-55a509936487

📥 Commits

Reviewing files that changed from the base of the PR and between b3e0d71 and ab22070.

📒 Files selected for processing (3)
  • ci-operator/config/openshift-knative/eventing-kafka-broker/openshift-knative-eventing-kafka-broker-release-v1.17__414.yaml
  • ci-operator/config/openshift-knative/eventing-kafka-broker/openshift-knative-eventing-kafka-broker-release-v1.17__421.yaml
  • ci-operator/config/openshift-knative/eventing-kafka-broker/openshift-knative-eventing-kafka-broker-release-v1.17__422.yaml

Walkthrough

Three CI operator config files for eventing-kafka-broker release v1.17 (OCP variants __414, __421, __422) update the RHEL9 Golang builder base image from rhel-9-release-golang-1.23-openshift-4.19 to rhel-9-release-golang-1.25-openshift-4.21, renaming the key in base_images and replacing it in every image build inputs block across each file.

Changes

Go 1.25 / OCP 4.21 base image bump for eventing-kafka-broker v1.17

Layer / File(s) Summary
base_images key and tag update
ci-operator/config/openshift-knative/eventing-kafka-broker/openshift-knative-eventing-kafka-broker-release-v1.17__414.yaml, ...release-v1.17__421.yaml, ...release-v1.17__422.yaml
The openshift_release_rhel-9-release-golang base image key and its tag are renamed from the 1.23/4.19 variant to 1.25/4.21 in all three config files.
Image build inputs replacement
ci-operator/config/openshift-knative/eventing-kafka-broker/openshift-knative-eventing-kafka-broker-release-v1.17__414.yaml, ...release-v1.17__421.yaml, ...release-v1.17__422.yaml
All images.items[].inputs blocks referencing openshift_release_rhel-9-release-golang-1.23-openshift-4.19 are updated to openshift_release_rhel-9-release-golang-1.25-openshift-4.21 across broker component and test image Dockerfiles.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested labels

lgtm, approved, rehearsals-ack

🚥 Pre-merge checks | ✅ 14 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'Sync Serverless CI config/' is vague and generic, using a non-descriptive term that doesn't convey meaningful information about the specific changes (base image updates from Go 1.23 to 1.25 across three configuration files). Provide a more specific title that describes the actual change, such as 'Update Go runtime base images to 1.25-openshift-4.21' or 'Bump Go and OpenShift versions in Kafka broker CI configs'.
✅ Passed checks (14 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed No Ginkgo test names found in PR. All 41 modified Go files use standard Go testing framework with static, deterministic test names; check is not applicable.
Test Structure And Quality ✅ Passed PR contains only CI configuration YAML updates, not Ginkgo test code. Custom check for test structure is not applicable to CI configuration files.
Microshift Test Compatibility ✅ Passed PR adds only CI configuration files (YAML configs for ci-operator), not Ginkgo e2e tests. Custom check for MicroShift test compatibility is not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed No Ginkgo e2e tests are being added in this PR. Changes consist of CI configuration YAML updates and utility tool test files using standard Go testing package. SNO compatibility check is not applic...
Topology-Aware Scheduling Compatibility ✅ Passed Pull request contains only CI operator configuration updates (base image and Go version changes), not deployment manifests, operator code, or controllers with scheduling constraints.
Ote Binary Stdout Contract ✅ Passed PR contains only YAML CI configuration files updating golang/OpenShift base images for Knative builds; no OTE binary code or stdout-related violations present.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR modifies only CI/CD configuration files (YAML), not Ginkgo e2e test source code. The custom check applies only to new test code additions, which are absent here.
No-Weak-Crypto ✅ Passed Pull request contains only YAML CI configuration updates with no weak crypto algorithms, custom crypto implementations, or secret comparison code.
Container-Privileges ✅ Passed No privileged container settings (privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, allowPrivilegeEscalation, runAsUser:0) found in the three modified CI configuration files.
No-Sensitive-Data-In-Logs ✅ Passed PR updates only base image versions in CI config files; contains no passwords, API keys, tokens, PII, session IDs, internal hostnames, or customer data.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 15, 2026
@openshift-ci

openshift-ci Bot commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: serverless-qe
Once this PR has been reviewed and has the lgtm label, please assign twogiants for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci

openshift-ci Bot commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Hi @serverless-qe. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci Bot requested review from Cali0707 and creydr June 15, 2026 12:34
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@serverless-qe: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-knative-eventing-kafka-broker-release-v1.17-422-images openshift-knative/eventing-kafka-broker presubmit Ci-operator config changed
pull-ci-openshift-knative-eventing-kafka-broker-release-v1.17-422-test-conformance openshift-knative/eventing-kafka-broker presubmit Ci-operator config changed
pull-ci-openshift-knative-eventing-kafka-broker-release-v1.17-422-test-e2e openshift-knative/eventing-kafka-broker presubmit Ci-operator config changed
pull-ci-openshift-knative-eventing-kafka-broker-release-v1.17-422-test-reconciler openshift-knative/eventing-kafka-broker presubmit Ci-operator config changed
pull-ci-openshift-knative-eventing-kafka-broker-release-v1.17-422-test-reconciler-encryption-auth openshift-knative/eventing-kafka-broker presubmit Ci-operator config changed
pull-ci-openshift-knative-eventing-kafka-broker-release-v1.17-422-test-reconciler-keda openshift-knative/eventing-kafka-broker presubmit Ci-operator config changed
pull-ci-openshift-knative-eventing-kafka-broker-release-v1.17-421-images openshift-knative/eventing-kafka-broker presubmit Ci-operator config changed
pull-ci-openshift-knative-eventing-kafka-broker-release-v1.17-421-test-conformance openshift-knative/eventing-kafka-broker presubmit Ci-operator config changed
pull-ci-openshift-knative-eventing-kafka-broker-release-v1.17-421-test-e2e openshift-knative/eventing-kafka-broker presubmit Ci-operator config changed
pull-ci-openshift-knative-eventing-kafka-broker-release-v1.17-421-test-reconciler openshift-knative/eventing-kafka-broker presubmit Ci-operator config changed
pull-ci-openshift-knative-eventing-kafka-broker-release-v1.17-421-test-reconciler-encryption-auth openshift-knative/eventing-kafka-broker presubmit Ci-operator config changed
pull-ci-openshift-knative-eventing-kafka-broker-release-v1.17-421-test-reconciler-keda openshift-knative/eventing-kafka-broker presubmit Ci-operator config changed
pull-ci-openshift-knative-eventing-kafka-broker-release-v1.17-414-images openshift-knative/eventing-kafka-broker presubmit Ci-operator config changed
pull-ci-openshift-knative-eventing-kafka-broker-release-v1.17-414-test-conformance openshift-knative/eventing-kafka-broker presubmit Ci-operator config changed
pull-ci-openshift-knative-eventing-kafka-broker-release-v1.17-414-test-e2e openshift-knative/eventing-kafka-broker presubmit Ci-operator config changed
pull-ci-openshift-knative-eventing-kafka-broker-release-v1.17-414-test-reconciler openshift-knative/eventing-kafka-broker presubmit Ci-operator config changed
pull-ci-openshift-knative-eventing-kafka-broker-release-v1.17-414-test-reconciler-encryption-auth openshift-knative/eventing-kafka-broker presubmit Ci-operator config changed
pull-ci-openshift-knative-eventing-kafka-broker-release-v1.17-414-test-reconciler-keda openshift-knative/eventing-kafka-broker presubmit Ci-operator config changed
periodic-ci-openshift-knative-eventing-kafka-broker-release-v1.17-414-test-reconciler-c N/A periodic Ci-operator config changed
periodic-ci-openshift-knative-eventing-kafka-broker-release-v1.17-421-test-conformance-c N/A periodic Ci-operator config changed
periodic-ci-openshift-knative-eventing-kafka-broker-release-v1.17-421-test-reconciler-keda-c N/A periodic Ci-operator config changed
periodic-ci-openshift-knative-eventing-kafka-broker-release-v1.17-414-test-reconciler-keda-c N/A periodic Ci-operator config changed
periodic-ci-openshift-knative-eventing-kafka-broker-release-v1.17-414-test-conformance-c N/A periodic Ci-operator config changed
periodic-ci-openshift-knative-eventing-kafka-broker-release-v1.17-414-test-e2e-c N/A periodic Ci-operator config changed
periodic-ci-openshift-knative-eventing-kafka-broker-release-v1.17-421-test-e2e-c N/A periodic Ci-operator config changed

A total of 28 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant