Skip to content

Add josecastillolema to openshift-dpf owners#80520

Open
josecastillolema wants to merge 2 commits into
openshift:mainfrom
josecastillolema:dpf-owners-jose
Open

Add josecastillolema to openshift-dpf owners#80520
josecastillolema wants to merge 2 commits into
openshift:mainfrom
josecastillolema:dpf-owners-jose

Conversation

@josecastillolema

@josecastillolema josecastillolema commented Jun 15, 2026

Copy link
Copy Markdown
Member

Summary by CodeRabbit

This PR updates OpenShift CI’s step ownership for the DPF (Data Plane Function) “hypervisor” components in ci-operator/step-registry. It adds josecastillolema (and also aligns linoyaslan) to the approvers and reviewers lists so they can approve and review changes to the DPF hypervisor CI step configurations.

Concretely, it updates the OWNERS configuration and the corresponding referenced ownership metadata for the DPF hypervisor workflows, including provisioning/cleanup/deprovisioning, cluster deploy/deploy-cluster, environment setup (SSH/network), and test steps (e2e, network-tests, sanity-existing, and test-full-suite). The result is consistent ownership coverage across the DPF hypervisor CI step registry definitions.

Signed-off-by: Jose Castillo Lema <josecastillolema@gmail.com>

    gitleaks.version: 8.30.0
    gitleaks.check-secrets: ENABLED
@coderabbitai

coderabbitai Bot commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 6f1d0032-b268-40ce-86a1-bbc31824ffde

📥 Commits

Reviewing files that changed from the base of the PR and between 986b449 and 5eb8c3d.

📒 Files selected for processing (10)
  • ci-operator/step-registry/dpf/hypervisor/cleanup/dpf-hypervisor-cleanup-ref.metadata.json
  • ci-operator/step-registry/dpf/hypervisor/deploy-cluster/dpf-hypervisor-deploy-cluster-ref.metadata.json
  • ci-operator/step-registry/dpf/hypervisor/deprovision/dpf-hypervisor-deprovision-chain.metadata.json
  • ci-operator/step-registry/dpf/hypervisor/e2e/dpf-hypervisor-e2e-workflow.metadata.json
  • ci-operator/step-registry/dpf/hypervisor/network-tests/dpf-hypervisor-network-tests-ref.metadata.json
  • ci-operator/step-registry/dpf/hypervisor/prepare-environment/dpf-hypervisor-prepare-environment-ref.metadata.json
  • ci-operator/step-registry/dpf/hypervisor/provision/dpf-hypervisor-provision-chain.metadata.json
  • ci-operator/step-registry/dpf/hypervisor/sanity-existing/dpf-hypervisor-sanity-existing-ref.metadata.json
  • ci-operator/step-registry/dpf/hypervisor/setup-ssh/dpf-hypervisor-setup-ssh-ref.metadata.json
  • ci-operator/step-registry/dpf/hypervisor/test-full-suite/dpf-hypervisor-test-full-suite-ref.metadata.json
✅ Files skipped from review due to trivial changes (3)
  • ci-operator/step-registry/dpf/hypervisor/sanity-existing/dpf-hypervisor-sanity-existing-ref.metadata.json
  • ci-operator/step-registry/dpf/hypervisor/network-tests/dpf-hypervisor-network-tests-ref.metadata.json
  • ci-operator/step-registry/dpf/hypervisor/test-full-suite/dpf-hypervisor-test-full-suite-ref.metadata.json

Walkthrough

Twelve OWNERS files under ci-operator/step-registry/dpf/ and its hypervisor/ subdirectories, along with their corresponding metadata JSON files, were updated to add josecastillolema and linoyaslan to both approvers and reviewers lists. Existing approvers (szigmon, tsorya, wabouhamad) are retained; entries are reordered and options: {} remains unchanged throughout.

Changes

DPF Ownership Roster Update

Layer / File(s) Summary
OWNERS and metadata ownership lists expansion
ci-operator/step-registry/dpf/OWNERS, ci-operator/step-registry/dpf/hypervisor/OWNERS, ci-operator/step-registry/dpf/hypervisor/cleanup/OWNERS, ci-operator/step-registry/dpf/hypervisor/deploy-cluster/OWNERS, ci-operator/step-registry/dpf/hypervisor/deprovision/OWNERS, ci-operator/step-registry/dpf/hypervisor/e2e/OWNERS, ci-operator/step-registry/dpf/hypervisor/network-tests/OWNERS, ci-operator/step-registry/dpf/hypervisor/prepare-environment/OWNERS, ci-operator/step-registry/dpf/hypervisor/provision/OWNERS, ci-operator/step-registry/dpf/hypervisor/sanity-existing/OWNERS, ci-operator/step-registry/dpf/hypervisor/setup-ssh/OWNERS, ci-operator/step-registry/dpf/hypervisor/test-full-suite/OWNERS, and corresponding .metadata.json files
All 12 DPF OWNERS files and their metadata JSON counterparts were updated to add josecastillolema and linoyaslan to both approvers and reviewers lists; existing entries (szigmon, tsorya, wabouhamad) are retained with reordered positioning; options: {} is unchanged.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: adding josecastillolema to multiple OWNERS files across the openshift-dpf directory structure.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed This PR modifies only OWNERS and CI step registry metadata files—no Ginkgo or test code files are changed. The check is not applicable to this PR.
Test Structure And Quality ✅ Passed Check is not applicable: PR only modifies OWNERS and metadata.json configuration files, not Ginkgo test code. No test files are present to review against test quality requirements.
Microshift Test Compatibility ✅ Passed PR only updates OWNERS files and CI metadata; no new Ginkgo e2e tests are added, so MicroShift compatibility check does not apply.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR adds only configuration/metadata files (OWNERS, step registry metadata, YAML workflows). No new Ginkgo e2e test code is introduced, so SNO compatibility check is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed PR only modifies OWNERS and metadata.json files (code ownership configuration), not deployment manifests, operator code, or controllers. No scheduling constraints introduced.
Ote Binary Stdout Contract ✅ Passed PR modifies only OWNERS and metadata configuration files; OTE stdout contract applies only to test binary code, which this PR does not contain.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed This PR only modifies OWNERS and metadata JSON files to add approvers/reviewers; no new Ginkgo e2e tests are added, so the IPv6/disconnected network compatibility check does not apply.
No-Weak-Crypto ✅ Passed PR modifies only OWNERS and metadata.json configuration files; contains no cryptographic code, weak crypto, custom crypto implementations, or unsafe comparisons.
Container-Privileges ✅ Passed PR only modifies OWNERS and metadata.json files for code ownership; no container or K8s manifests with privileged settings are changed.
No-Sensitive-Data-In-Logs ✅ Passed PR only modifies OWNERS/metadata config files adding GitHub usernames; no executable code or logging statements present.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from linoyaslan and szigmon June 15, 2026 12:04
@openshift-ci

openshift-ci Bot commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: josecastillolema
Once this PR has been reviewed and has the lgtm label, please assign tsorya for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jun 15, 2026
Signed-off-by: Jose Castillo Lema <josecastillolema@gmail.com>

    gitleaks.version: 8.30.0
    gitleaks.check-secrets: ENABLED
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@josecastillolema: no rehearsable tests are affected by this change

Note: If this PR includes changes to step registry files (ci-operator/step-registry/) and you expected jobs to be found, try rebasing your PR onto the base branch. This helps pj-rehearse accurately detect changes when the base branch has moved forward.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci

openshift-ci Bot commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

@josecastillolema: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant