Skip to content

ROSAENG-1466: Update build_root to use .ci-operator.yaml from repo#80506

Open
rpodishe wants to merge 1 commit into
openshift:mainfrom
rpodishe:ROSAENG-1466-enable-boilerplate
Open

ROSAENG-1466: Update build_root to use .ci-operator.yaml from repo#80506
rpodishe wants to merge 1 commit into
openshift:mainfrom
rpodishe:ROSAENG-1466-enable-boilerplate

Conversation

@rpodishe

@rpodishe rpodishe commented Jun 15, 2026

Copy link
Copy Markdown

Update build_root to use .ci-operator.yaml from repo

Summary by CodeRabbit

This PR updates the OpenShift CI configuration for the openshift/ocm-agent repository so its CI build root is sourced from the repository itself.

Change: In ci-operator/config/openshift/ocm-agent/openshift-ocm-agent-master.yaml, the build_root configuration was switched from referencing an external release image stream tag (rhel-9-release-golang-1.24-openshift-4.20 in openshift) to from_repository: true, enabling ci-operator to use the repository’s .ci-operator.yaml for build-root settings.

Practical impact: Build environment configuration can now be versioned and updated alongside ocm-agent code, without requiring coordination to change the central referenced image-stream-based build root.

Notes: The PR context references JIRA ROSAENG-1466, and a CI bot comment flags that the referenced issue’s target version is not properly configured (expected story target: 5.0.0).

@openshift-ci-robot

openshift-ci-robot commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

@rpodishe: This pull request references ROSAENG-1466 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Update build_root to use .ci-operator.yaml from repo

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 15, 2026
@coderabbitai

coderabbitai Bot commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Walkthrough

The build_root field in the ocm-agent master CI operator config is updated from a pinned image_stream_tag (namespace openshift, tag rhel-9-release-golang-1.24-openshift-4.20) to from_repository: true. No other configuration is modified.

Changes

Build Root Configuration Update

Layer / File(s) Summary
Switch build_root to from_repository
ci-operator/config/openshift/ocm-agent/openshift-ocm-agent-master.yaml
build_root is changed from a specific image_stream_tag (rhel-9-release-golang-1.24-openshift-4.20) to from_repository: true, removing 3 lines of explicit image stream configuration.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: updating build_root configuration to use .ci-operator.yaml from the repository, which aligns with the changeset modifications.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed This PR modifies only a CI/CD YAML configuration file with no Ginkgo test code changes. The custom check for stable test names is inapplicable to non-test configuration changes.
Test Structure And Quality ✅ Passed PR modifies only a CI operator YAML configuration file, not Ginkgo test code. The check for Ginkgo test quality is not applicable to YAML configuration changes.
Microshift Test Compatibility ✅ Passed This PR does not add any Ginkgo e2e tests. It only modifies a CI operator YAML configuration file to change the build_root setting. The MicroShift test compatibility check is not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed This PR modifies only a CI/operator YAML configuration file, not adding any Ginkgo e2e tests. The SNO compatibility check is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed PR only modifies CI-operator build configuration (not deployment manifests, operator code, or controllers). No scheduling constraints are introduced.
Ote Binary Stdout Contract ✅ Passed PR modifies only YAML CI configuration files, not Go source code. OTE Binary Stdout Contract check applies to Go binaries/test code, not configuration files.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR modifies only a CI configuration YAML file (openshift-ocm-agent-master.yaml), not Ginkgo e2e tests. Check is not applicable.
No-Weak-Crypto ✅ Passed No weak cryptographic algorithms, custom crypto implementations, or non-constant-time secret comparisons found in the PR. The change is a YAML configuration update for CI/CD build settings only.
Container-Privileges ✅ Passed File contains no privileged: true, hostPID, hostNetwork, hostIPC, SYS_ADMIN capability, allowPrivilegeEscalation: true, or root-privilege settings.
No-Sensitive-Data-In-Logs ✅ Passed PR only changes build_root config (image_stream_tag → from_repository: true). No logging statements added/modified. Existing CODECOV_TOKEN references predate this PR and are securely handled via en...
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from tkong-redhat and typeid June 15, 2026 06:57
@rpodishe rpodishe force-pushed the ROSAENG-1466-enable-boilerplate branch from aff1648 to f77bbe0 Compare June 15, 2026 07:39
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@rpodishe: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-ocm-agent-master-coverage openshift/ocm-agent presubmit Ci-operator config changed
pull-ci-openshift-ocm-agent-master-e2e-binary-build-success openshift/ocm-agent presubmit Ci-operator config changed
pull-ci-openshift-ocm-agent-master-images openshift/ocm-agent presubmit Ci-operator config changed
pull-ci-openshift-ocm-agent-master-lint openshift/ocm-agent presubmit Ci-operator config changed
pull-ci-openshift-ocm-agent-master-test openshift/ocm-agent presubmit Ci-operator config changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci

openshift-ci Bot commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

@rpodishe: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@TheUndeadKing

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 15, 2026
@openshift-ci

openshift-ci Bot commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rpodishe, TheUndeadKing

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants