Skip to content

ci-operator: capi: update featuregate script after restructuring #74390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
damdo wants to merge 1 commit into
base: master
Choose a base branch
from
Open

ci-operator: capi: update featuregate script after restructuring #74390

damdo wants to merge 1 commit into from
+36 −6

Conversation

@damdo
Copy link
Member

@damdo damdo commented Feb 4, 2026

After the restructuring in openshift/cluster-capi-operator#447
we need to update the script to account for the new deployment and namespaces

@damdo damdo force-pushed the fix-update-capi-conf-apply-feature-gate-commands branch from 2ada207 to 5fe6aca Compare February 4, 2026 14:37
@openshift-ci openshift-ci bot requested review from Fedosin and JoelSpeed February 4, 2026 14:39
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 4, 2026
@damdo
Copy link
Member Author

damdo commented Feb 4, 2026

/assign @mdbooth @JoelSpeed

@damdo damdo force-pushed the fix-update-capi-conf-apply-feature-gate-commands branch from 5fe6aca to 13d3184 Compare February 4, 2026 14:43
mdbooth
mdbooth approved these changes Feb 4, 2026
View reviewed changes
Copy link
Contributor

@mdbooth mdbooth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

This is good if the tests pass

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 4, 2026
@damdo
Copy link
Member Author

damdo commented Feb 4, 2026

/pj-rehearse pull-ci-openshift-cluster-machine-approver-main-e2e-aws-capi-techpreview pull-ci-openshift-cluster-machine-approver-release-4.21-e2e-aws-capi-techpreview

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 4, 2026

@damdo: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@damdo
ci-operator: capi: update featuregate script after restructuring
f7af20f 
After the restructuring in
openshift/cluster-capi-operator#447 we need to
update the script to account for the new deployment and namespaces
@damdo damdo force-pushed the fix-update-capi-conf-apply-feature-gate-commands branch from 13d3184 to f7af20f Compare February 4, 2026 16:34
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 4, 2026
@damdo
Copy link
Member Author

damdo commented Feb 4, 2026

/pj-rehearse pull-ci-openshift-cluster-machine-approver-main-e2e-aws-capi-techpreview pull-ci-openshift-cluster-machine-approver-release-4.21-e2e-aws-capi-techpreview

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 4, 2026

@damdo: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 4, 2026

[REHEARSALNOTIFIER]
@damdo: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-cluster-api-operator-release-4.20-e2e-aws-ovn-techpreview openshift/cluster-api-operator presubmit Registry content changed
pull-ci-openshift-cluster-api-operator-release-4.19-e2e-aws-ovn-techpreview openshift/cluster-api-operator presubmit Registry content changed
pull-ci-openshift-cluster-api-operator-release-4.18-e2e-aws-ovn-techpreview openshift/cluster-api-operator presubmit Registry content changed
pull-ci-openshift-cluster-api-operator-release-4.17-e2e-aws-ovn-techpreview openshift/cluster-api-operator presubmit Registry content changed
pull-ci-openshift-cluster-api-operator-release-4.16-e2e-aws-ovn-techpreview openshift/cluster-api-operator presubmit Registry content changed
pull-ci-openshift-cluster-api-operator-release-4.15-e2e-aws-ovn-techpreview openshift/cluster-api-operator presubmit Registry content changed
pull-ci-openshift-cluster-api-operator-release-4.14-e2e-aws-ovn-techpreview openshift/cluster-api-operator presubmit Registry content changed
pull-ci-openshift-cluster-api-operator-release-4.13-e2e-aws-ovn-techpreview openshift/cluster-api-operator presubmit Registry content changed
pull-ci-openshift-cluster-api-operator-release-4.20-e2e-azure-ovn-techpreview openshift/cluster-api-operator presubmit Registry content changed
pull-ci-openshift-cluster-api-operator-release-4.19-e2e-azure-ovn-techpreview openshift/cluster-api-operator presubmit Registry content changed
pull-ci-openshift-cluster-api-operator-release-4.18-e2e-azure-ovn-techpreview openshift/cluster-api-operator presubmit Registry content changed
pull-ci-openshift-cluster-api-operator-release-4.17-e2e-azure-ovn-techpreview openshift/cluster-api-operator presubmit Registry content changed
pull-ci-openshift-cluster-api-operator-release-4.16-e2e-azure-ovn-techpreview openshift/cluster-api-operator presubmit Registry content changed
pull-ci-openshift-cluster-api-operator-release-4.15-e2e-azure-ovn-techpreview openshift/cluster-api-operator presubmit Registry content changed
pull-ci-openshift-cluster-api-operator-release-4.14-e2e-azure-ovn-techpreview openshift/cluster-api-operator presubmit Registry content changed
pull-ci-openshift-cluster-api-operator-release-4.13-e2e-azure-ovn-techpreview openshift/cluster-api-operator presubmit Registry content changed
pull-ci-openshift-cluster-api-operator-release-4.20-e2e-gcp-ovn-techpreview openshift/cluster-api-operator presubmit Registry content changed
pull-ci-openshift-cluster-api-operator-release-4.19-e2e-gcp-ovn-techpreview openshift/cluster-api-operator presubmit Registry content changed
pull-ci-openshift-cluster-api-operator-release-4.18-e2e-gcp-ovn-techpreview openshift/cluster-api-operator presubmit Registry content changed
pull-ci-openshift-cluster-api-operator-release-4.17-e2e-gcp-ovn-techpreview openshift/cluster-api-operator presubmit Registry content changed
pull-ci-openshift-cluster-api-operator-release-4.16-e2e-gcp-ovn-techpreview openshift/cluster-api-operator presubmit Registry content changed
pull-ci-openshift-cluster-api-operator-release-4.15-e2e-gcp-ovn-techpreview openshift/cluster-api-operator presubmit Registry content changed
pull-ci-openshift-cluster-api-operator-release-4.14-e2e-gcp-ovn-techpreview openshift/cluster-api-operator presubmit Registry content changed
pull-ci-openshift-cluster-api-operator-release-4.13-e2e-gcp-ovn-techpreview openshift/cluster-api-operator presubmit Registry content changed
pull-ci-openshift-cluster-capi-operator-release-4.11-e2e-aws-techpreview openshift/cluster-capi-operator presubmit Registry content changed

A total of 45 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

mdbooth
mdbooth approved these changes Feb 4, 2026
View reviewed changes
Copy link
Contributor

@mdbooth mdbooth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Dependent on tests passing

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 4, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 4, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damdo, mdbooth

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@damdo
Copy link
Member Author

damdo commented Feb 4, 2026

/pj-rehearse pull-ci-openshift-cluster-machine-approver-release-4.21-e2e-aws-capi-techpreview

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 4, 2026

@damdo: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Fedosin Fedosin Awaiting requested review from Fedosin

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

1 more reviewer

@mdbooth mdbooth mdbooth approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mdbooth mdbooth

@JoelSpeed JoelSpeed

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@damdo @openshift-ci-robot @mdbooth @JoelSpeed