Skip to content

Conversation

@harche
Copy link
Contributor

@harche harche commented Feb 4, 2026

Summary

PR #74222 changed the build_root image from golang-1.22 to rhel-8-release-golang-1.22-openshift-4.18, but instaslice-operator requires Go 1.23 (per go.mod).

The rhel-8 image has GOTOOLCHAIN=local which prevents auto-downloading Go 1.23, causing unit tests to fail with:

go: go.mod requires go >= 1.23.0 (running go 1.22.9; GOTOOLCHAIN=local)

This PR updates to rhel-9-release-golang-1.23-openshift-4.20 which has Go 1.23.

Files Changed

  • ci-operator/config/openshift/instaslice-operator/openshift-instaslice-operator-next.yaml
  • ci-operator/config/openshift-priv/instaslice-operator/openshift-priv-instaslice-operator-next.yaml

Related

🤖 Generated with Claude Code

PR openshift#74222 changed the build_root image from golang-1.22 to
rhel-8-release-golang-1.22-openshift-4.18, but instaslice-operator
requires Go 1.23 (per go.mod). The rhel-8 image has GOTOOLCHAIN=local
which prevents auto-downloading Go 1.23, causing unit tests to fail with:

  go: go.mod requires go >= 1.23.0 (running go 1.22.9; GOTOOLCHAIN=local)

Update to rhel-9-release-golang-1.23-openshift-4.20 which has Go 1.23.

Co-Authored-By: Claude Opus 4.5 <[email protected]>
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 4, 2026
@openshift-ci openshift-ci bot requested review from cpmeadors and pruan-rht February 4, 2026 14:02
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@harche: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-instaslice-operator-next-ci-index-das-operator-bundle openshift/instaslice-operator presubmit Ci-operator config changed
pull-ci-openshift-instaslice-operator-next-e2e-bundle openshift/instaslice-operator presubmit Ci-operator config changed
pull-ci-openshift-instaslice-operator-next-e2e-bundle-4-19 openshift/instaslice-operator presubmit Ci-operator config changed
pull-ci-openshift-instaslice-operator-next-e2e-bundle-4-19-runc openshift/instaslice-operator presubmit Ci-operator config changed
pull-ci-openshift-instaslice-operator-next-e2e-bundle-4-20-runc openshift/instaslice-operator presubmit Ci-operator config changed
pull-ci-openshift-instaslice-operator-next-e2e-bundle-runc openshift/instaslice-operator presubmit Ci-operator config changed
pull-ci-openshift-instaslice-operator-next-images openshift/instaslice-operator presubmit Ci-operator config changed
pull-ci-openshift-instaslice-operator-next-unit openshift/instaslice-operator presubmit Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@harche
Copy link
Contributor Author

harche commented Feb 4, 2026

/pj-rehearse pull-ci-openshift-instaslice-operator-next-unit

@openshift-ci-robot
Copy link
Contributor

@harche: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@harche
Copy link
Contributor Author

harche commented Feb 4, 2026

/pj-rehearse pull-ci-openshift-instaslice-operator-next-unit

/hold for rehearsal jobs.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 4, 2026
@harche
Copy link
Contributor Author

harche commented Feb 4, 2026

/pj-rehearse pull-ci-openshift-instaslice-operator-next-e2e-bundle-4-19-runc

@openshift-ci-robot
Copy link
Contributor

@harche: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@harche
Copy link
Contributor Author

harche commented Feb 4, 2026

/pj-rehearse pull-ci-openshift-instaslice-operator-next-e2e-bundle-4-19-runc

@openshift-ci-robot
Copy link
Contributor

@harche: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@kannon92
Copy link
Contributor

kannon92 commented Feb 4, 2026

/lgtm
/approve
/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@kannon92: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Feb 4, 2026
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 4, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 4, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harche, kannon92

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@harche
Copy link
Contributor Author

harche commented Feb 4, 2026

pull-ci-openshift-instaslice-operator-next-e2e-bundle-4-19-runc is failing due to infra issues, not related to the changes in this PR.

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 4, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 4, 2026

@harche: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift/instaslice-operator/next/e2e-bundle-4-19-runc d6771f6 link unknown /pj-rehearse pull-ci-openshift-instaslice-operator-next-e2e-bundle-4-19-runc

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 0aeb022 into openshift:master Feb 4, 2026
14 of 15 checks passed
@harche harche deleted the fix-instaslice-golang-version branch February 4, 2026 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants