Skip to content

Conversation

@jianli-wei
Copy link
Contributor

@jianli-wei jianli-wei commented Feb 4, 2026

  • merge step ipi-conf-gcp-control-plane-node-type into step ipi-conf-gcp
  • append step ipi-conf-gcp-zones to chain ipi-conf-gcp
  • update step ipi-conf-gcp-zone, to support one new env var EXCLUDE_ZONES_PATTERN, default empty, and when set, zones matching the pattern will be excluded, and then zones will be set according to either explicit env vars of control-plane & compute/worker nodes types, or from install-config.yaml controlPlane.platform.gcp.type / compute[0].platform.gcp.type / platform.gcp.defaultMachinePlatform.type
  • update step ipi-conf-gcp, to remove the changes introduced by Filter out AI zones for standard machine types and randomize zone selection #74093

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 4, 2026
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 4, 2026

@jianli-wei: This pull request references OCPQE-31577 which is a valid jira issue.

Details

In response to this:

WIP

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 4, 2026
@openshift-ci-robot
Copy link
Contributor

@jianli-wei, pj-rehearse: unable to determine affected jobs. This could be due to a branch that needs to be rebased. ERROR:

could not determine changed registry steps: could not load step registry: [chain/cucushift-installer-rehearse-gcp-ipi-c3-metal-private-provision: duplicate name: ipi-conf-gcp-zones, workflow/cucushift-installer-rehearse-gcp-ipi-c3-metal-private: chain/cucushift-installer-rehearse-gcp-ipi-c3-metal-private-provision: duplicate name: ipi-conf-gcp-zones]
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci openshift-ci bot requested review from dgoodwin and elmiko February 4, 2026 08:14
@jianli-wei jianli-wei force-pushed the gcp-zones-enhancement branch from 31b967c to cff7ba1 Compare February 4, 2026 08:27
@openshift-ci-robot
Copy link
Contributor

@jianli-wei, pj-rehearse: unable to determine affected jobs. This could be due to a branch that needs to be rebased. ERROR:

could not determine changed registry steps: could not load step registry: [chain/cucushift-installer-rehearse-gcp-ipi-c3-metal-private-provision: duplicate name: ipi-conf-gcp-zones, workflow/cucushift-installer-rehearse-gcp-ipi-c3-metal-private: chain/cucushift-installer-rehearse-gcp-ipi-c3-metal-private-provision: duplicate name: ipi-conf-gcp-zones]
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@jianli-wei jianli-wei force-pushed the gcp-zones-enhancement branch from cff7ba1 to f5000f2 Compare February 4, 2026 08:44
@openshift-ci-robot
Copy link
Contributor

@jianli-wei, pj-rehearse: unable to determine affected jobs. This could be due to a branch that needs to be rebased. ERROR:

could not determine changed registry steps: could not load step registry: [chain/cucushift-installer-rehearse-gcp-ipi-c3-metal-private-provision: duplicate name: ipi-conf-gcp-zones, workflow/cucushift-installer-rehearse-gcp-ipi-c3-metal-private: chain/cucushift-installer-rehearse-gcp-ipi-c3-metal-private-provision: duplicate name: ipi-conf-gcp-zones]
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 4, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jianli-wei
Once this PR has been reviewed and has the lgtm label, please assign csams, jhuttana, jianlinliu, joelspeed for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jianli-wei jianli-wei force-pushed the gcp-zones-enhancement branch from f5000f2 to 430cedd Compare February 4, 2026 09:16
@openshift-ci-robot
Copy link
Contributor

@jianli-wei, pj-rehearse: unable to determine affected jobs. This could be due to a branch that needs to be rebased. ERROR:

could not determine changed registry steps: could not load step registry: [chain/cucushift-installer-rehearse-gcp-ipi-c3-metal-private-provision: duplicate name: ipi-conf-gcp-zones, workflow/cucushift-installer-rehearse-gcp-ipi-c3-metal-private: chain/cucushift-installer-rehearse-gcp-ipi-c3-metal-private-provision: duplicate name: ipi-conf-gcp-zones]
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 4, 2026

@jianli-wei: This pull request references OCPQE-31577 which is a valid jira issue.

Details

In response to this:

  • merge step ipi-conf-gcp-control-plane-node-type into step ipi-conf-gcp
  • append step ipi-conf-gcp-zones to chain ipi-conf-gcp
  • update step ipi-conf-gcp-zone, to support one new env var EXCLUDE_ZONES_PATTERN, default empty, and when set, zones matching the pattern will be excluded, and then zones will be set according to either explicit env vars of control-plane & compute/worker nodes types, or from install-config.yaml controlPlane.platform.gcp.type / compute[0].platform.gcp.type / platform.gcp.defaultMachinePlatform.type

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jianli-wei jianli-wei force-pushed the gcp-zones-enhancement branch from 430cedd to b18b4a8 Compare February 4, 2026 10:02
@openshift-ci-robot
Copy link
Contributor

@jianli-wei, pj-rehearse: unable to determine affected jobs. This could be due to a branch that needs to be rebased. ERROR:

could not determine changed registry steps: could not load step registry: [chain/cucushift-installer-rehearse-gcp-ipi-c3-metal-private-provision: duplicate name: ipi-conf-gcp-zones, workflow/cucushift-installer-rehearse-gcp-ipi-c3-metal-private: chain/cucushift-installer-rehearse-gcp-ipi-c3-metal-private-provision: duplicate name: ipi-conf-gcp-zones]
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@jianli-wei jianli-wei force-pushed the gcp-zones-enhancement branch from b18b4a8 to 31c8506 Compare February 4, 2026 10:14
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 4, 2026

@jianli-wei: This pull request references OCPQE-31577 which is a valid jira issue.

Details

In response to this:

  • merge step ipi-conf-gcp-control-plane-node-type into step ipi-conf-gcp
  • append step ipi-conf-gcp-zones to chain ipi-conf-gcp
  • update step ipi-conf-gcp-zone, to support one new env var EXCLUDE_ZONES_PATTERN, default empty, and when set, zones matching the pattern will be excluded, and then zones will be set according to either explicit env vars of control-plane & compute/worker nodes types, or from install-config.yaml controlPlane.platform.gcp.type / compute[0].platform.gcp.type / platform.gcp.defaultMachinePlatform.type
  • update step ipi-conf-gcp, to remove the changes introduced by Filter out AI zones for standard machine types and randomize zone selection #74093

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

@jianli-wei, pj-rehearse: unable to determine affected jobs. This could be due to a branch that needs to be rebased. ERROR:

could not determine changed registry steps: could not load step registry: [chain/cucushift-installer-rehearse-gcp-ipi-c3-metal-private-provision: duplicate name: ipi-conf-gcp-zones, workflow/cucushift-installer-rehearse-gcp-ipi-c3-metal-private: chain/cucushift-installer-rehearse-gcp-ipi-c3-metal-private-provision: duplicate name: ipi-conf-gcp-zones]
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants