Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move ocp-qe-perfscale-ci repository from openshift-qe to openshift-eng org #62193

Merged
merged 25 commits into from
Mar 7, 2025
Merged

Move ocp-qe-perfscale-ci repository from openshift-qe to openshift-eng org #62193

merged 25 commits into from
Mar 7, 2025
+1,120 −1,095

Conversation

paigerube14
Copy link
Contributor

@paigerube14 paigerube14 commented Feb 27, 2025 •
edited
Loading

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 27, 2025
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 27, 2025
@openshift-ci-robot
Copy link
Contributor

@paigerube14, pj-rehearse: unable to determine affected jobs. This could be due to a branch that needs to be rebased. ERROR:

could not load configuration from candidate revision of release repo: failed to load ci-operator configuration from release repo: failed to load ci-operator config (error converting YAML to JSON: yaml: line 46: did not find expected key)
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci openshift-ci bot requested review from afcollins and droslean February 27, 2025 19:55
@qiliRedHat
Copy link
Contributor

qiliRedHat commented Feb 28, 2025 •
edited
Loading

@paigerube14 I noticed this is still WIP, but I hope to add my comments proactively

  1. Let's add the links to the first comment and update the title so the other reviewers will be more clear.
    https://issues.redhat.com/browse/DPP-16552
    https://issues.redhat.com/browse/PERFSCALE-3739.
    Title update to "[WIP] Move ocp-qe-perfscale-ci repository from openshift-qe to openshift-eng org".

  2. The content in the below files need updates too. Some failure test jobs provided some steps to take that maybe helpful?
    https://github.com/openshift/release/blob/master/core-services/prow/02_config/_config.yaml
    https://github.com/openshift/release/blob/master/core-services/prow/02_config/openshift-qe/ocp-qe-perfscale-ci/_pluginconfig.yaml
    https://github.com/openshift/release/blob/master/core-services/prow/02_config/openshift-qe/ocp-qe-perfscale-ci/_prowconfig.yaml
    https://github.com/openshift/release/blob/master/core-services/prow/02_config/openshift-qe/ocp-qe-perfscale-ci/OWNERS

  3. Job names in files like https://github.com/openshift/release/blob/master/core-services/release-controller/_releases/priv/release-ocp-4.19.json need updates too

  4. Not necessary in this pr, but let's update or remove http://github.com/openshift/release/blob/master/core-services/testgrid-config-generator/_allow-list.yaml#L52-L54

@paigerube14 paigerube14 changed the title [WIP] Perfscale CI Rename org [WIP] Move ocp-qe-perfscale-ci repository from openshift-qe to openshift-eng org Feb 28, 2025
@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Feb 28, 2025
@qiliRedHat
Copy link
Contributor

@paigerube14 I had some comments above, would you check and see if there is any update needed?

@paigerube14
Copy link
Contributor Author

@paigerube14 I had some comments above, would you check and see if there is any update needed?

@qiliRedHat yes I updated on 1, 2 and 3. Going to remove references for 4
The problem is here because I moved over the files. Any changes that go in now I won't have properly ported over so going to have to fully redo this work every time. we need to go ahead and move over sooner rather than later

@qiliRedHat
Copy link
Contributor

@paigerube14 I like to move as soon as possible. I asked in https://issues.redhat.com/browse/DPP-16552 a proper time for both you and Jone.

@qiliRedHat
Copy link
Contributor

@paigerube14 For 2 in my comment, the files are moved to the new folder but not updated. I saw the files contents are updated in another pr https://github.com/openshift/release/pull/62152/files#diff-15d20f11a2923b986f8bfae9cc391484ee296fd3fb5aaf7bafe52be8723c9b89

@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 6, 2025
@openshift-ci-robot openshift-ci-robot removed the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Mar 6, 2025
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 6, 2025
@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Mar 6, 2025
@paigerube14
Copy link
Contributor Author

@bradmwilliams @pruan-rht @bear-redhat @smg247 PTAL

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@paigerube14: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-eng-ocp-qe-perfscale-ci-main-aws-4.14-nightly-arm-control-plane-24nodes openshift-eng/ocp-qe-perfscale-ci presubmit Presubmit changed
pull-ci-openshift-eng-ocp-qe-perfscale-ci-main-aws-4.14-nightly-arm-data-path-9nodes openshift-eng/ocp-qe-perfscale-ci presubmit Presubmit changed
pull-ci-openshift-eng-ocp-qe-perfscale-ci-main-aws-4.14-nightly-arm-node-density-cni-24nodes openshift-eng/ocp-qe-perfscale-ci presubmit Presubmit changed
pull-ci-openshift-eng-ocp-qe-perfscale-ci-main-aws-4.14-nightly-arm-node-density-heavy-24nodes openshift-eng/ocp-qe-perfscale-ci presubmit Presubmit changed
pull-ci-openshift-eng-ocp-qe-perfscale-ci-main-aws-4.14-nightly-x86-cilium-control-plane-120nodes openshift-eng/ocp-qe-perfscale-ci presubmit Presubmit changed
pull-ci-openshift-eng-ocp-qe-perfscale-ci-main-aws-4.14-nightly-x86-cilium-control-plane-24nodes openshift-eng/ocp-qe-perfscale-ci presubmit Presubmit changed
pull-ci-openshift-eng-ocp-qe-perfscale-ci-main-aws-4.14-nightly-x86-cilium-data-path-9nodes openshift-eng/ocp-qe-perfscale-ci presubmit Presubmit changed
pull-ci-openshift-eng-ocp-qe-perfscale-ci-main-aws-4.14-nightly-x86-cilium-node-density-cni-24nodes openshift-eng/ocp-qe-perfscale-ci presubmit Presubmit changed
pull-ci-openshift-eng-ocp-qe-perfscale-ci-main-aws-4.14-nightly-x86-conc-builds-3nodes openshift-eng/ocp-qe-perfscale-ci presubmit Presubmit changed
pull-ci-openshift-eng-ocp-qe-perfscale-ci-main-aws-4.14-nightly-x86-control-plane-etcdencrypt-24nodes openshift-eng/ocp-qe-perfscale-ci presubmit Presubmit changed
pull-ci-openshift-eng-ocp-qe-perfscale-ci-main-aws-4.14-nightly-x86-cpou-loaded-upgrade-from-4.12-loaded-upgrade-412to414-120nodes openshift-eng/ocp-qe-perfscale-ci presubmit Presubmit changed
pull-ci-openshift-eng-ocp-qe-perfscale-ci-main-aws-4.14-nightly-x86-cpou-loaded-upgrade-from-4.12-loaded-upgrade-412to414-24nodes openshift-eng/ocp-qe-perfscale-ci presubmit Presubmit changed
pull-ci-openshift-eng-ocp-qe-perfscale-ci-main-aws-4.14-nightly-x86-cpou-loaded-upgrade-from-4.12-loaded-upgrade-ipsec-412to414-120nodes openshift-eng/ocp-qe-perfscale-ci presubmit Presubmit changed
pull-ci-openshift-eng-ocp-qe-perfscale-ci-main-aws-4.14-nightly-x86-cpou-loaded-upgrade-from-4.12-loaded-upgrade-ipsec-412to414-24nodes openshift-eng/ocp-qe-perfscale-ci presubmit Presubmit changed
pull-ci-openshift-eng-ocp-qe-perfscale-ci-main-aws-4.14-nightly-x86-loaded-upgrade-from-4.12-loaded-upgrade-412to413to414-5nodes openshift-eng/ocp-qe-perfscale-ci presubmit Presubmit changed
pull-ci-openshift-eng-ocp-qe-perfscale-ci-main-aws-4.14-nightly-x86-node-density-cni-24nodes openshift-eng/ocp-qe-perfscale-ci presubmit Presubmit changed
pull-ci-openshift-eng-ocp-qe-perfscale-ci-main-aws-4.14-nightly-x86-router-perf-24nodes openshift-eng/ocp-qe-perfscale-ci presubmit Presubmit changed
pull-ci-openshift-eng-ocp-qe-perfscale-ci-main-aws-4.14-nightly-x86-sno-control-plane openshift-eng/ocp-qe-perfscale-ci presubmit Presubmit changed
pull-ci-openshift-eng-ocp-qe-perfscale-ci-main-aws-4.15-nightly-arm-control-plane-120nodes openshift-eng/ocp-qe-perfscale-ci presubmit Presubmit changed
pull-ci-openshift-eng-ocp-qe-perfscale-ci-main-aws-4.15-nightly-arm-control-plane-24nodes openshift-eng/ocp-qe-perfscale-ci presubmit Presubmit changed
pull-ci-openshift-eng-ocp-qe-perfscale-ci-main-aws-4.15-nightly-arm-data-path-9nodes openshift-eng/ocp-qe-perfscale-ci presubmit Presubmit changed
pull-ci-openshift-eng-ocp-qe-perfscale-ci-main-aws-4.15-nightly-arm-node-density-cni-24nodes openshift-eng/ocp-qe-perfscale-ci presubmit Presubmit changed
pull-ci-openshift-eng-ocp-qe-perfscale-ci-main-aws-4.15-nightly-arm-node-density-heavy-24nodes openshift-eng/ocp-qe-perfscale-ci presubmit Presubmit changed
pull-ci-openshift-eng-ocp-qe-perfscale-ci-main-aws-4.15-nightly-x86-cilium-control-plane-120nodes openshift-eng/ocp-qe-perfscale-ci presubmit Presubmit changed
pull-ci-openshift-eng-ocp-qe-perfscale-ci-main-aws-4.15-nightly-x86-cilium-control-plane-24nodes openshift-eng/ocp-qe-perfscale-ci presubmit Presubmit changed

A total of 472 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@bradmwilliams
Copy link
Contributor

/label tide/merge-method-squash

@openshift-ci openshift-ci bot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Mar 6, 2025
@bradmwilliams
Copy link
Contributor

/approve
It won't mean much, but from the release-controller's perspective, I approve

@pruan-rht
Copy link
Member

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 6, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 6, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bradmwilliams, paigerube14, pruan-rht

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 6, 2025
@paigerube14
Copy link
Contributor Author

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@paigerube14: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Mar 6, 2025
@qiliRedHat
Copy link
Contributor

/pj-rehearse reject

@openshift-ci-robot
Copy link
Contributor

@qiliRedHat: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot removed the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Mar 7, 2025
@qiliRedHat
Copy link
Contributor

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@qiliRedHat: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Mar 7, 2025
@qiliRedHat
Copy link
Contributor

/retest

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 7, 2025

@paigerube14: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 7216a39 into openshift:master Mar 7, 2025
21 checks passed
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 7, 2025

@paigerube14: Updated the following 2 configmaps:

  • config configmap in namespace ci at cluster app.ci using the following files:
    • key config.yaml using file core-services/prow/02_config/_config.yaml
    • key core-services-prow-02_config-openshift-qe-ocp-qe-perfscale-ci-_prowconfig.yaml using file ``
    • key core-services-prow-02_config-openshift-eng-ocp-qe-perfscale-ci-_prowconfig.yaml using file core-services/prow/02_config/openshift-eng/ocp-qe-perfscale-ci/_prowconfig.yaml
  • plugins configmap in namespace ci at cluster app.ci using the following files:
    • key core-services-prow-02_config-openshift-qe-ocp-qe-perfscale-ci-_pluginconfig.yaml using file ``
    • key core-services-prow-02_config-openshift-eng-ocp-qe-perfscale-ci-_pluginconfig.yaml using file core-services/prow/02_config/openshift-eng/ocp-qe-perfscale-ci/_pluginconfig.yaml

In response to this:

https://issues.redhat.com/browse/DPP-16552
https://issues.redhat.com/browse/PERFSCALE-3739.

CC: @qiliRedHat

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@qiliRedHat qiliRedHat mentioned this pull request Mar 10, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bradmwilliams bradmwilliams bradmwilliams requested changes

@afcollins afcollins Awaiting requested review from afcollins

@droslean droslean Awaiting requested review from droslean

Assignees

@pruan-rht pruan-rht

@bradmwilliams bradmwilliams

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@paigerube14 @openshift-ci-robot @qiliRedHat @bradmwilliams @pruan-rht @openshift-merge-robot