-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Vsphere coverage for chaos tests #62097
base: master
Are you sure you want to change the base?
Conversation
/pj-rehearse pull-ci-redhat-chaos-prow-scripts-main-4.18-nightly-vsphere-krkn-hub-tests-10nodes |
@shahsahil264: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
/pj-rehearse pull-ci-redhat-chaos-prow-scripts-main-4.18-nightly-vsphere-krkn-hub-node-tests-10nodes |
@shahsahil264: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
/retest |
/pj-rehearse pull-ci-redhat-chaos-prow-scripts-main-4.18-nightly-vsphere-krkn-hub-node-tests-10nodes |
@shahsahil264: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
/pj-rehearse pull-ci-redhat-chaos-prow-scripts-main-4.18-nightly-vsphere-krkn-hub-node-tests-10nodes |
@shahsahil264: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
/pj-rehearse pull-ci-redhat-chaos-prow-scripts-main-4.18-nightly-vsphere-krkn-hub-node-tests-10nodes |
@shahsahil264: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
@shahsahil264 remember we said here you need to add the setting of the VSPHERE_* parameters into the commands script |
@paigerube14 Yup yup, my bad I was triggering the other nutanix PR that I have open, got confused XD |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: shahsahil264 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/pj-rehearse pull-ci-redhat-chaos-prow-scripts-main-4.18-nightly-vsphere-krkn-hub-node-tests-10nodes |
@shahsahil264: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
/pj-rehearse pull-ci-redhat-chaos-prow-scripts-main-4.18-nightly-vsphere-krkn-hub-node-tests-10nodes |
@shahsahil264: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
@shahsahil264: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
/pj-rehearse pull-ci-redhat-chaos-prow-scripts-main-4.18-nightly-vsphere-krkn-hub-node-tests-10nodes |
@shahsahil264: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
/pj-rehearse pull-ci-redhat-chaos-prow-scripts-main-4.18-nightly-vsphere-krkn-hub-node-tests-10nodes |
@shahsahil264: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
/pj-rehearse pull-ci-redhat-chaos-prow-scripts-main-4.18-nightly-vsphere-krkn-hub-node-tests-10nodes |
@shahsahil264: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
@@ -12,6 +12,9 @@ ref: | |||
- namespace: test-credentials | |||
name: ocp-qe-perfscale-es | |||
mount_path: /secret/es | |||
- namespace: test-credentials | |||
name: devqe-secrets |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the name here for the profile we are using should be https://github.com/openshift/ci-tools/blob/e7e8a8cb02b2b39797fdfacfe2f1a25e5ef0cb27/pkg/load/load_test.go#L311 I think
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think you actually will need this. Hopefully setting what was the vsphere_center to vsphere_ip will be the only change you need
# export VSPHERE_USERNAME | ||
# VSPHERE_PASSWORD=$(oc get secret vsphere-creds -n kube-system -o jsonpath="$jsonpath_password") | ||
# export VSPHERE_PASSWORD | ||
vcenter_username_minimal_permission=$(cat "/var/run/vault/devqe-secrets/vcenter_username_minimal_permission") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these keys won't be correct for the other credential name
I'm guessing it has a "secrets.sh" file with username/password. You'll want to source and see the variables created
# jsonpath_username="{.data.${VSPHERE_IP_WITHOUTDOT}\.username}" | ||
# jsonpath_password="{.data.${VSPHERE_IP_WITHOUTDOT}\.password}" | ||
# VSPHERE_USERNAME=$(oc get secret vsphere-creds -n kube-system -o jsonpath="$jsonpath_username") | ||
# export VSPHERE_USERNAME |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i thikn the way you were getting this is more correct than using the credentials and it would be better for if we ever use different profiles. Just want to find a way to mask it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I agree
/pj-rehearse pull-ci-redhat-chaos-prow-scripts-main-4.18-nightly-vsphere-krkn-hub-node-tests-10nodes |
@shahsahil264: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
/pj-rehearse pull-ci-redhat-chaos-prow-scripts-main-4.18-nightly-vsphere-krkn-hub-node-tests-10nodes |
@shahsahil264: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
/pj-rehearse pull-ci-redhat-chaos-prow-scripts-main-4.18-nightly-vsphere-krkn-hub-node-tests-10nodes |
@shahsahil264: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
/pj-rehearse pull-ci-redhat-chaos-prow-scripts-main-4.18-nightly-vsphere-krkn-hub-node-tests-10nodes |
@shahsahil264: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
/pj-rehearse pull-ci-redhat-chaos-prow-scripts-main-4.18-nightly-vsphere-krkn-hub-node-tests-10nodes |
@shahsahil264: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
@shahsahil264: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
[REHEARSALNOTIFIER]
A total of 35 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
@chaitanyaenr @paigerube14