[WIP] refactor vertical-pod-autoscaler-operator tests for operator-sdk upgrade #55425
Conversation
openshift-ci
bot
added
the
do-not-merge/work-in-progress
maxcao13
force-pushed
the
vpa-operator-upgrade
branch
from
4cfe801
to
129afd3
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: maxcao13 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/pj-rehearse |
|
@maxcao13: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
maxcao13
force-pushed
the
vpa-operator-upgrade
branch
from
129afd3
to
070b57a
Compare
|
/pj-rehearse |
|
@maxcao13: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
maxcao13
force-pushed
the
vpa-operator-upgrade
branch
from
070b57a
to
c8fa2d1
Compare
|
/pj-rehearse |
|
@maxcao13: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
maxcao13
force-pushed
the
vpa-operator-upgrade
branch
from
c8fa2d1
to
e37f65b
Compare
|
Fixed some vendoring issue in upgrade branch, and used a golangci-lint image to run the |
|
/pj-rehearse more |
|
@maxcao13: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
maxcao13
force-pushed
the
vpa-operator-upgrade
branch
from
e37f65b
to
7c6146f
Compare
|
/pj-rehearse more |
|
@maxcao13: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
maxcao13
force-pushed
the
vpa-operator-upgrade
branch
from
7c6146f
to
e915ace
Compare
|
/pj-rehearse pull-ci-maxcao13-vertical-pod-autoscaler-operator-operator-sdk-upgrade-v2.1-unit pull-ci-maxcao13-vertical-pod-autoscaler-operator-operator-sdk-upgrade-v2.1-manifest-diff |
|
@maxcao13: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
maxcao13
force-pushed
the
vpa-operator-upgrade
branch
from
e915ace
to
a8e8c4b
Compare
|
/pj-rehearse pull-ci-maxcao13-vertical-pod-autoscaler-operator-operator-sdk-upgrade-v2.1-unit pull-ci-maxcao13-vertical-pod-autoscaler-operator-operator-sdk-upgrade-v2.1-manifest-diff |
|
@maxcao13: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-maxcao13-vertical-pod-autoscaler-operator-operator-sdk-upgrade-v2.1-unit |
|
I'm adding the scorecard test suite to the CI as well. And I will also retest all the rehearsals just as a sanity check. I expect the lint check to fail because of a deprecation warning. /pj-rehearse max |
|
@maxcao13: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
maxcao13
force-pushed
the
vpa-operator-upgrade
branch
from
3fd176c
to
92aae4f
Compare
|
/pj-rehearse max |
|
@maxcao13: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@maxcao13, Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
@maxcao13, If the problem persists, please contact Test Platform. |
maxcao13
force-pushed
the
vpa-operator-upgrade
branch
from
92aae4f
to
2538546
Compare
|
/pj-rehearse max |
|
@maxcao13: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
maxcao13
force-pushed
the
vpa-operator-upgrade
branch
from
2538546
to
e4b172d
Compare
|
/pj-rehearse pull-ci-maxcao13-vertical-pod-autoscaler-operator-operator-sdk-upgrade-v2.1-scorecard pull-ci-maxcao13-vertical-pod-autoscaler-operator-operator-sdk-upgrade-v2.1-unit |
|
@maxcao13: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-maxcao13-vertical-pod-autoscaler-operator-operator-sdk-upgrade-v2.1-scorecard |
|
@maxcao13: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
maxcao13
force-pushed
the
vpa-operator-upgrade
branch
from
e4b172d
to
765ce71
Compare
|
@maxcao13: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-maxcao13-vertical-pod-autoscaler-operator-operator-sdk-upgrade-v2.1-scorecard |
|
@maxcao13: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
maxcao13
force-pushed
the
vpa-operator-upgrade
branch
from
765ce71
to
65383a3
Compare
|
@maxcao13: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse pull-ci-maxcao13-vertical-pod-autoscaler-operator-operator-sdk-upgrade-v2.1-scorecard |
|
@maxcao13: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@maxcao13: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Scorecard tests finally pass as I was finally able to figure out how to request a hypershift cluster to run it on (which should reduce time and cost to spin up). I'm assuming it took so long because it was a rehearsal which had to build everything on its own. |
Ignore for now, just checking to see if it works against my branch.
This is so that we can fix tests that have to migrated to the operator-sdk upgrade in the VPA-operator sooner than later since a lot has changed in the repo.
The first commit is to make sure that images get pulled correctly and simple tests (go vet, fmt ,etc. get tested correctly).
Further commits will test the e2e tests that require a cluster.
Which should let us get instant feedback on test changes when we merge VPA upgrade PR instead of having to change there, then come back here and change it.
PR in question here: openshift/vertical-pod-autoscaler-operator#169