-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPEDGE-799: feat: make aggregated sno upgrade job blocking #55395
OCPEDGE-799: feat: make aggregated sno upgrade job blocking #55395
Conversation
Signed-off-by: ehila <[email protected]>
@eggfoobar: This pull request references OCPEDGE-799 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target either version "4.18." or "openshift-4.18.", but it targets "openshift-4.17" instead. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[REHEARSALNOTIFIER] |
/lgtm |
Hey @neisw, if we're good with the branching, this should be good to merge in, wdyt? |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eggfoobar, neisw, suleymanakbas91 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/unhold |
@eggfoobar: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
…)" This reverts commit d954275.
/hold
Hold until after branch cut.